From patchwork Wed Jun 5 18:51:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 1110632 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="LJvajUz6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45JyYj3vT8z9s3Z for ; Thu, 6 Jun 2019 04:51:21 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbfFESvU (ORCPT ); Wed, 5 Jun 2019 14:51:20 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42142 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbfFESvU (ORCPT ); Wed, 5 Jun 2019 14:51:20 -0400 Received: by mail-pf1-f196.google.com with SMTP id q10so5145231pff.9 for ; Wed, 05 Jun 2019 11:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=avnH/rTOKRMkgxFUDWDVsgJ2ihOT3G2xoITfG7gj3qA=; b=LJvajUz6kOCmKIvRa9mXKVaL4E/MUcumUj4nqHD4mOVPjPVTDcK5v/F44sicMM0qnE RYsFTKA7+88OCVGnQYWS2hFkJ3MwQFPuX+Xx07GJTqk/72ka5RI6RTUKV/7Wk4njlK27 1aZPOSx1/q01z8mvg52O2XTg1t6blV5QxgB/4n/vlJQuo6zd65XuLpkaja6u94YS1XWk EgWGXhehBde80hiZiS40uTuXtqziiMFotJXXtZuNGSCP5fZTgGSAN4U/5ssOq356KhNu YUPkuf/NAOLOm5vzVu0hK3289JQJSccDlrD36EQ20hFSotnx+rvKNPUEK73oVWKmqXX9 mURQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=avnH/rTOKRMkgxFUDWDVsgJ2ihOT3G2xoITfG7gj3qA=; b=RQvGA9Y4mIVqpJF8OE68LUYZA9qBWEMId0+P0GTIGDH8lJJUTQlI3NtyhjDhKVW9t4 tAeztZfRbalJ0tCQWm5Q5T864iukfrf9FpJkdKLX/vrkVI/zmYpYPnIxkITmu8zQz1gz 2XlKeqmJz9aHcPheU6cSMPrSbyzYMJXTUjZhpjftw8kOjL9Ex0laDZ2VHjmlXJSxcx8r sE72B3g7mZNl/3mIgeuMWd2iiEere4MGH3FmW+ndNnYdyWOuzF0MeoUowRZoXi2BA0HO 1oGsKfPpJXm2VPLXmWeZQJnWTm3m2vkgBvglL8xMtjOXfqU+B64jSG39cCgU/cFG/szV JxRA== X-Gm-Message-State: APjAAAXNshKm+dbow8Qn9gr1jpZtmaQ0ULGXzifMr71B8Qe4+yl0UTRo jqSkbZ9lMk6rX7bBgxwj+dkN4DZMcD0= X-Google-Smtp-Source: APXvYqyV/VN+NomYp9iM62pXrywv+7KniaTRJNmOSaONG6DQ0PAUNDOq/b6pUKqKobKqIXPFxCEkxg== X-Received: by 2002:a62:7990:: with SMTP id u138mr4592791pfc.191.1559760679194; Wed, 05 Jun 2019 11:51:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l7sm27713688pfl.9.2019.06.05.11.51.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 05 Jun 2019 11:51:18 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: netdev@vger.kernel.org Cc: linux-hyperv@vger.kernel.org, Stephen Hemminger Subject: [PATCH] revert async probing of VMBus network devices. Date: Wed, 5 Jun 2019 11:51:14 -0700 Message-Id: <20190605185114.12456-1-sthemmin@microsoft.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Doing asynchronous probing can lead to reordered network device names. And because udev doesn't have any useful information to construct a persistent name, this causes VM's to sporadically boot with reordered device names and no connectivity. This shows up on the Ubuntu image on larger VM's where 30% of the time eth0 and eth1 get swapped. Note: udev MAC address policy is disabled on Azure images because the netvsc and PCI VF will have the same mac address. Fixes: af0a5646cb8d ("use the new async probing feature for the hyperv drivers") Signed-off-by: Stephen Hemminger Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 06393b215102..1a2c32111106 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -2411,9 +2411,6 @@ static struct hv_driver netvsc_drv = { .id_table = id_table, .probe = netvsc_probe, .remove = netvsc_remove, - .driver = { - .probe_type = PROBE_PREFER_ASYNCHRONOUS, - }, }; /*