From patchwork Tue Jun 4 14:58:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 1109964 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-502309-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="vv/Sv87k"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="WOgx1p0a"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45JFRL1JSfz9s4Y for ; Wed, 5 Jun 2019 00:58:19 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; q=dns; s=default; b=V2tIiBUcmrdkTj2FwdTV2BxQTkk4/6bJrrkVRGhtjHOLryxGcc e9KJP9jMTvcbmLHlnohLOnXEzbAZ1I60qlfXw2jDAaPG1S73Lz7mSlhB42E9sign RQdOTscf8XlmOI10mA+iBwWE2IMc+CpL4Hj1EJe1F6dlo8P2Q/j1efgHI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; s= default; bh=WHK2au8bmL5CWHmn6o79uEzxI8E=; b=vv/Sv87kmitfsk0/ZfDD VsUqqOEMJKJzMcSRAIUM6rWepJA0PrE4LV8efqlc76IgrYFDYroHlob8qeQ1V3Xo 5Xvo+uayhUfGlSg63VCWSDhd1qMgp6qiYwo600CuXfvfbaUOvBTyhIhYfgt2oQui 6phRxtKQAqaHdnF+icISdF0= Received: (qmail 42816 invoked by alias); 4 Jun 2019 14:58:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 42802 invoked by uid 89); 4 Jun 2019 14:58:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1796, H*c:HHH X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40066.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jun 2019 14:58:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dufDqb4/8gJkJrZctX4A9KuFhfjqGbEky0atmfk9I3U=; b=WOgx1p0ad8KEGnruOf6TL+H8C3BCgDjSejRI3qitScIy0Gs0PqhWqINoOCLQ73y69hAPGszfE1di8DynW7wtjcKatgf6vwwQZYKdsFxs/EeFBl8LsvJqBf0I/bbGScDtYbCbUYv4HDubo6kIAPjLzouIquJafXXqrBLvpqPgy4E= Received: from VE1PR08MB4637.eurprd08.prod.outlook.com (10.255.27.14) by VE1PR08MB5038.eurprd08.prod.outlook.com (10.255.159.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Tue, 4 Jun 2019 14:58:08 +0000 Received: from VE1PR08MB4637.eurprd08.prod.outlook.com ([fe80::91d0:a7fb:baa1:9a20]) by VE1PR08MB4637.eurprd08.prod.outlook.com ([fe80::91d0:a7fb:baa1:9a20%7]) with mapi id 15.20.1943.018; Tue, 4 Jun 2019 14:58:08 +0000 From: Szabolcs Nagy To: GCC Patches CC: nd , James Greenhalgh Subject: [PATCH] aarch64: fix asm visibility for extern symbols Date: Tue, 4 Jun 2019 14:58:07 +0000 Message-ID: <5c754d95-cd82-0399-1ae6-d35bc8c5be49@arm.com> user-agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:3513; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Szabolcs.Nagy@arm.com X-IsSubscribed: yes Commit r271869 broke visibility declarations in asm for extern symbols, because the new ASM_OUTPUT_EXTERNAL hook failed to call the default hook for elf. gcc/ChangeLog: 2019-06-04 Szabolcs Nagy * config/aarch64/aarch64-protos.h (aarch64_asm_output_external): Remove const. * config/aarch64/aarch64.c (aarch64_asm_output_external): Call default_elf_asm_output_external. diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h index 6dccabc8cf7..1e3b1c91db1 100644 --- a/gcc/config/aarch64/aarch64-protos.h +++ b/gcc/config/aarch64/aarch64-protos.h @@ -437,7 +437,7 @@ bool aarch64_is_noplt_call_p (rtx); bool aarch64_label_mentioned_p (rtx); void aarch64_declare_function_name (FILE *, const char*, tree); void aarch64_asm_output_alias (FILE *, const tree, const tree); -void aarch64_asm_output_external (FILE *, const tree, const char*); +void aarch64_asm_output_external (FILE *, tree, const char*); bool aarch64_legitimate_pic_operand_p (rtx); bool aarch64_mask_and_shift_for_ubfiz_p (scalar_int_mode, rtx, rtx); bool aarch64_masks_and_shift_for_bfi_p (scalar_int_mode, unsigned HOST_WIDE_INT, diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 263ed21442c..7acc3227a78 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -15650,8 +15650,9 @@ aarch64_asm_output_alias (FILE *stream, const tree decl, const tree target) function symbol references. */ void -aarch64_asm_output_external (FILE *stream, const tree decl, const char* name) +aarch64_asm_output_external (FILE *stream, tree decl, const char* name) { + default_elf_asm_output_external (stream, decl, name); aarch64_asm_output_variant_pcs (stream, decl, name); }