From patchwork Thu May 9 09:55:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1097443 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-500354-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="pRgEhFe0"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4507yN2k4gz9sBp for ; Thu, 9 May 2019 19:55:54 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=uaCo1ui5DaZOq1+M Qep3hAiX69pBBZ1CsSkubdI8+r7H1eo48xeLrdSjyzMJEsOd2RjHRZ/7+7RZ/tlD niFQiMFQjlcKJ3AodvvsxEO9+MRJvvFPFthLibnensdyWU11ndtrWhTGVLvlyiuv UEdAuJwI1ZresdIXdOODFsmi3O8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=MOhzbv4G1s6kTTFB7ztsb8 GkoPA=; b=pRgEhFe0dLbvgEMj/6HGjIUpH83BGiwtsMM8cpDNHs90FXyu4iKpZw z3ERUAR2jTaBvfrQgo3vWWZdNvLhLPzKie4tXRjsXIMZSQ6mt8LsPedNLbOJCpq8 JhaTxS1C5fWdkhiIsCnGGVpPawqaY2z7y9JL93UE2vkgA+BFVLVQo= Received: (qmail 1400 invoked by alias); 9 May 2019 09:55:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1388 invoked by uid 89); 9 May 2019 09:55:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=Until, sk:tschwin, H*Ad:D*debian.org, sk:amodra X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 May 2019 09:55:45 +0000 Received: from svr-orw-mbx-06.mgc.mentorg.com ([147.34.90.206]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hOfm9-0004WO-05 from Thomas_Schwinge@mentor.com ; Thu, 09 May 2019 02:55:41 -0700 Received: from svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) by SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 9 May 2019 02:55:38 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Thu, 9 May 2019 02:55:38 -0700 Received: by tftp-cs (Postfix, from userid 49978) id 3B033C2322; Thu, 9 May 2019 02:55:38 -0700 (PDT) From: Thomas Schwinge To: Uros Bizjak , CC: Rainer Orth , Eric Botcazou , "H. J. Lu" , Jonathan Yong <10walls@gmail.com>, , Subject: [committed] [PR89221] Continue to default to '--disable-frame-pointer' for x86 GNU systems (was: [PATCH v2, i386]: Fix PR89221, --enable-frame-pointer does not work as intended) In-Reply-To: References: User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Thu, 9 May 2019 11:55:25 +0200 Message-ID: <87zhnwdkaa.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak wrote: > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak wrote: > > Attached patch fixes --enable-frame-pointer handling [...] ACK. > Please note that this fix will re-enable frame pointer for all targets > but linux* or darwin[[8912]]. However, since builds for e.g. cygwin > and mingw survived just well without frame pointers in the mean time, > we should probably list these targets as targets without frame > pointers by default. I agree, this would cause the least surprise, to simply keep the previous default of '--disable-frame-pointer'. Until such a global change is agreed on, and made... > Maintainers should decide. The GNU/Hurd maintainer has decided (and also made a decision for GNU/k*BSD); committed the attached to trunk in r271028. Grüße Thomas From 679a49952fe543043047267cc8500c5cc1065b7b Mon Sep 17 00:00:00 2001 From: tschwinge Date: Thu, 9 May 2019 09:51:59 +0000 Subject: [PATCH] [PR89221] Continue to default to '--disable-frame-pointer' for x86 GNU systems The recent trunk r270914 for PR89221 "--enable-frame-pointer does not work as intended" fixed a scripting defect in the x86 '--enable-frame-pointer' handling. This has the side effect that, for example, for '--target=i686-gnu' this is now enabled by default: 'USE_IX86_FRAME_POINTER=1' is added to 'tm_defines'. Given that it's highly unlikely that anyone would now suddenly want '--enable-frame-pointer' as the default for any kind of GNU system, I'm changing the default back for GNU systems, to match that of a 'target_os' of 'linux* | darwin[8912]*'. gcc/ PR target/89221 * configure.ac (--enable-frame-pointer): Disable by default for GNU systems. * configure: Regenerate. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@271028 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 7 +++++++ gcc/configure | 4 ++-- gcc/configure.ac | 4 ++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 37447f854c0..ea96146b5b8 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2019-05-09 Thomas Schwinge + + PR target/89221 + * configure.ac (--enable-frame-pointer): Disable by default for + GNU systems. + * configure: Regenerate. + 2019-05-09 Alan Modra PR target/89271 diff --git a/gcc/configure b/gcc/configure index 08cce6f1980..947d263a617 100755 --- a/gcc/configure +++ b/gcc/configure @@ -12197,8 +12197,8 @@ if test "${enable_frame_pointer+set}" = set; then : else case $target_os in -linux* | darwin[8912]*) - # Enable -fomit-frame-pointer by default for Linux and Darwin with DWARF2. +linux* | gnu* | darwin[8912]*) + # Enable -fomit-frame-pointer by default for these systems with DWARF2. enable_frame_pointer=no ;; *) diff --git a/gcc/configure.ac b/gcc/configure.ac index 7c526b9ada4..bfcdf526e44 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -1884,8 +1884,8 @@ AC_ARG_ENABLE(frame-pointer, [enable -fno-omit-frame-pointer by default for x86])], [], [ case $target_os in -linux* | darwin[[8912]]*) - # Enable -fomit-frame-pointer by default for Linux and Darwin with DWARF2. +linux* | gnu* | darwin[[8912]]*) + # Enable -fomit-frame-pointer by default for these systems with DWARF2. enable_frame_pointer=no ;; *) -- 2.17.1