From patchwork Fri Oct 27 21:37:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manlunas, Felix" X-Patchwork-Id: 831518 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="MwidQhHF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yNxzX6FDvz9t4X for ; Sat, 28 Oct 2017 08:37:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdJ0VhK (ORCPT ); Fri, 27 Oct 2017 17:37:10 -0400 Received: from mail-cys01nam02on0066.outbound.protection.outlook.com ([104.47.37.66]:43194 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751515AbdJ0VhJ (ORCPT ); Fri, 27 Oct 2017 17:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6svGwXxC4kbBFHE1bhRlYQPzw9YqmmMSfrmyZhNQBv8=; b=MwidQhHF45hiOpF0P48/Ag509tSK3rrpitqzZoKhe4Ml9S4IzWBAHFIOnVSfgUFKe7WFiiKxYKCI3Ok7W7DoF6LNZqBIsKxkyOguczc5G3DnKyrzJ6gkv/8wZyE/haHzWesn9hDdKvOXaHw0A2Q/Qn1yInKqOeM+eeouQJ5U1Oo= Received: from localhost (50.233.148.156) by MWHPR07MB3184.namprd07.prod.outlook.com (10.172.96.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Fri, 27 Oct 2017 21:37:06 +0000 Date: Fri, 27 Oct 2017 14:37:03 -0700 From: Felix Manlunas To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com Subject: [PATCH net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg Message-ID: <20171027213703.GA1107@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: DM5PR16CA0009.namprd16.prod.outlook.com (10.173.216.19) To MWHPR07MB3184.namprd07.prod.outlook.com (10.172.96.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8bb4a07d-82d1-47c3-21d7-08d51d82df3d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603238); SRVR:MWHPR07MB3184; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3184; 3:Efgm6CAlx1XKOZsJBVBWKkaXzQuw0kE7MDT5DlZV9k+RrsqXCj4khmDSL1ao1TuoHQb+QDs4L9qDhRtz6lx9AJHhgLy9J30Qg9TPt/fMQZzRcOnINldz9Xy5zWq0CofANqrlQJZwe7mGlKv1KJVVeRr7f9q0S9fGl+Lf9kU19fULjNqL9qEgw683h1o1z6s5F8qKZWv1xyBxqtjr2iLSV7j1Fodps+uGCQq6Z6HRo4W+qHZL7un2sTYYctNOyvnY; 25:51ORz3vuIYTWuNtMkf9ETxyVXhvPe42FZo+yA05zpWOGhgNIBHSSNwO4H2wk9CIa70zCOUi4WaHGR/uo980mtc+ThY2D6xtUK1MJU4Q6XUinahQf2nWj7eLiXrvoNRHMH+aC21kLAJGVPO78VvD2v3PsCCAnh9ZIqwM8NcC0s+lZVNIRuE/K08XyQ5c9KzaOHqRSN3pgEN1luJOO+snqL8J3Oa4viP4ORIrz/RtXafTZlbr/KkxTM8IzslwhPfmoXlTNIHg2CcZJsQ6L+I72Np9k70+iym4N2/Y5/cM3PCB9HQ8/ASM9lEWo6cw/enqlhwP5OWIiVldwMyaYxy6uXA==; 31:+/wW9OGeJ+1wA6p7ycYDG5FnJyvNZxHFFOQityHoUVZhsfYw/wPDAaHnpG8j8T7D7el7+dCNrshasWtsLTkg4V4ODumqWeHnYdfWVmNslR34HXQOb24qZ4TqI+OFHehOhS6Poom6UQDNWf+6fgWaUzD8LISKTMAy0fizLmd/iVnWsCnWGSF4o0k9ki7Mzuir4hd+cM9MZ45DfrHxoGYr1Hdng35ntoR10z9FRk9YdCs= X-MS-TrafficTypeDiagnostic: MWHPR07MB3184: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3184; 20:tXeoMQzLiad4glTdr2l+gGb5Ruht8IcOt5ORgQuNxEDd74sS7gvtOLqEcyFvxnN1PMbeTFh5r/Lo4v6TrjLEr8CFSUFKJTvjAZ3S8kA6AQRBhDpGwUgXsEkFPSUML+/+uwWX33jvUDHR1mkq6i2zug0P6VZOGocoJdFutLy/wB4/1ReCI5aS/a3m+iUISbvEw4EE8sOkSHHAMZi88uOIDOhxcLRT+3I55YwmAldCfTwZ6IM65JXWtUd2qrqKzFXQJWGgpWk6vNsOMNSGYebTqgqlA7I6b5dxQmXRtoTb7ygNW4ZT/aES1LMWtrcSWnLcsij5gt/TFZ418CMDLlB/JJLv5Os1s0Ruz3MoKjtzLbc4NRooFy3A1wXHyKBqee6ZZmMpiyGzWcAoGIgpnt2lopeh00fPQlnoEE3m/CWZWLMl+vr70li0hDDzZc5j7mD5A3bSGmXU3Ln9uj25AlNKnJlwpOlzUVp96ln1Xa8k6dC9ev2Hk41KuNKK+u6Fthho; 4:/xQfHqS9BRHubBYeEgUX9wIyoofSlFWDaq6XiIIbRtiYkn1QQn2GkzoDgC3xIGKU1pVeFya4IQ7dRge2HFSbRB/4TeWOzYshJaZFCgwOIzE4sh7Qs+NfaUsuvPyvWn00Ke9W6kbt5nFdfHX8y1vEQ9fSZanrHna6dx7wyRgYZoWLezS4Ebv2YyLLlyRlRSdfWX7Wnr4DTYH+fl6T5FIf4w9PlzJPytypWwPo5iBSH0CKelXH6wtX72oLmsJdpBVZ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3184; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3184; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(346002)(376002)(189002)(199003)(478600001)(97736004)(25786009)(189998001)(72206003)(16526018)(47776003)(6496005)(86362001)(6666003)(8676002)(5660300001)(50466002)(8936002)(6916009)(81156014)(105586002)(54356999)(1076002)(68736007)(81166006)(6116002)(76506005)(101416001)(53936002)(16586007)(66066001)(58126008)(316002)(7736002)(23726003)(305945005)(106356001)(2906002)(2351001)(4326008)(33656002)(83506002)(50986999)(6486002)(2361001)(107886003)(3846002)(26583001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3184; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3184; 23:Lw0guoE4ukpKEa0b5RXdiVk/3Jqyshjrq+CJkIAxpgQVnjsdyrYG2MB7gz7q+TPKJIe3KAuFeqIEiN8YO4PVP6zRWEuD21rGgRASvnDC8XBPrrd3Hpk++8fGd6T/fzO8EZ4b3cQSe+lfPrgYfkCBVj7GWQ1hv5m+4LwVaqvGWyh9V2CO31lcVV1uTRJ/3yPZQ9FicpmRurhuwIMqCfwgmdygsZ8o2cCMPyrUhPKL3icdw6jNVBDMX61ycfUqwgGx47YW8ny7rrcHrJLUBnoFnA1u2sN4qvsleSs9HMr6RSdgHFzMPlORSsrG8WEOIp4QfmgXrwiQsIbOEOZHgqSkZTzWOt+bLmhoCRjZG1Bx7oY8Jpotd9GfhBEx2CcoUcfGwINdX0r0p3QWDiffbX3IBAVW6le38Lne9qI1y6JtvQ8J67YWVRzZ5XdiaDgqUNeeuoARAju9tOiKLJunoOEVHl8MZK8PQC3q7F68yHm0mgYZiB46gZoamfHDtzOZ6leG8yt4CSNaaZ4FWJlt2lYgFjZ92tYdaAn6txx/pUySnRvGeFPpi25Er0IirH4OnHsk5ekx7ovC7gf6gm0Uya1zgGaA3X/tVrf+S60gvwwJsPJVR4vzJgCE9Ad+wNblem+Y9ORuSuLEopx8RuJKwL3wcyBR9PgJkZuZ39nXhXPFGhg8YkTppNIaMoHN4OuJxEqYDcT5MQzec/7BxPfZsKkabfAxvWKHog+opdEJwUm6hAlCijFAhTZZE1l3QRDvtgElWtDDVlfCyOiApP0uNE/1NKoSy+lK2Fi51eW47RFawCT/Eopm+KjdDPp3UnR3hWzUewKd/tsQFS0vIlIdj9v7O8LZr+odA7QK0/FF4CVEF08O/cLmVBW0gVaietUN3utw4lReXUOSz3NpcYNr6KLBRHdptYBTwn3W2Ffs70ERwTItbs1qS0SdlrM+THV909zACnRanBjmfzr3y4jaITClPMvB2Wwz8X2GxZfMyCUOKp2NcuNpYObG1aZEIyHVn7d86cdG+jKcbdpyU+rxvTac6AniKFQ13S+aVoO6NdxZwTe8u0soe4Ox40cagFsmgwpQvkvUekgbu0sqximH7v6e2wGO0GrYm1mU6vUcknxlL0urnSzx3gNOR7A9rGq8n5BcSkdMFkbXonHgHjV7UiaKq+h05ieodVnL5XyIpTW51XU= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3184; 6:KE5ap/d2uGavBFRqIO/zck4FwYyopYH2TMnRCPeLGxFYEtsSA4ikHBPCXylzWvI4QvUNk6pBFmN8BcvdeMr8I0IQ9VlD1EuiMFZydyl9hJ40/natCO9gCHrz5e0eVPcKDH9ilT0Aw2T8sjZclUdKG5NWzZw7VXkMOEdAU0vHGejKaPvh9aG9hop23mj0UZM5FCVVjQ74Avm3GojfGH1hugQ1ltaID1i0bNqn7LDtlJh6DoZitymZ7qkP8e2LG5VmnCM/vKvdWzYPiTqqMAbFBZIFoIypHbw5vi4/0vw+sLGzSlgor8hcTpr8/cYdIqvR0ndQYKrynKyohuevUC6SbA==; 5:LFAqYZR60oygqpteRxSAxcgYb7dIw7rmIfiIvsb7h4nyLcAzq2+4f7tQNMHu6ii/mwV4WzJ8dCEFgva3g6v5wbKyjIslnhJjxD5lwSuGf/GKhRNP5NFDd09yY84ZszYobHILs+x90lrGlIGVi8vegQ==; 24:FKP9ngMW5YajcUtRrqDLXScY9DzO4B44wRaaI1IfjIJe/FSr8SS6mGgbd2SScxugmEZFacQJvxquYaYNMx0uUD13ISCjQrmFBEzyRS0d8zg=; 7:iyfd4VKAZsfIMHoTXDdr/FF4dWkW5JoGSelmBEKn8DL2K9cMPwE28NZGVIxzEM1sFuRQTYE4EZ2/utms9q422gkE8n/mhnpN+VFP7TwGIUZ/wmWRPgKZB5tKfh3qEgg56EFBN1pTA4niBGvTlmJt/OLufp9oeXAvshJ9fu5sRtTVWv1OtqKvQ8JM2DYg9Yd6Vpktx/i2NfA/DUTdT1kQ/hEEPTR8cjniYsfm7WFmCkM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 21:37:06.8885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bb4a07d-82d1-47c3-21d7-08d51d82df3d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3184 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Creating a macvtap interface with the liquidio VF driver as lower device causes this alarming message to show up in dmesg: liquidio_link_ctrl_cmd_completion Unknown cmd 27 That's actually a false alarm because cmd 27 is the value of the macro OCTNET_CMD_SET_UC_LIST which is known. It's a control command sent from host to NIC firmware to set the unicast MAC address list of the macvtap lower device. Make the false alarm go away by adding a case for OCTNET_CMD_SET_UC_LIST in liquidio_link_ctrl_cmd_completion(). Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index b891d85..89b7820 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -143,6 +143,7 @@ void liquidio_link_ctrl_cmd_completion(void *nctrl_ptr) switch (nctrl->ncmd.s.cmd) { case OCTNET_CMD_CHANGE_DEVFLAGS: case OCTNET_CMD_SET_MULTI_LIST: + case OCTNET_CMD_SET_UC_LIST: break; case OCTNET_CMD_CHANGE_MACADDR: