From patchwork Fri Apr 26 10:54:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikolay Aleksandrov X-Patchwork-Id: 1091468 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cumulusnetworks.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="ZUCScdBv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44r9t070vdz9s00 for ; Fri, 26 Apr 2019 20:54:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbfDZKyb (ORCPT ); Fri, 26 Apr 2019 06:54:31 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50600 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbfDZKya (ORCPT ); Fri, 26 Apr 2019 06:54:30 -0400 Received: by mail-wm1-f67.google.com with SMTP id p21so1487573wmc.0 for ; Fri, 26 Apr 2019 03:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GbBOiI0luRdJ4TU1uhQPbrOpz6Zj/LRNTSnYFlir+/8=; b=ZUCScdBv4Kmpz8vy67r2z4Ibn2pQQxOrOV/ZeKAU9WJtLTlJ49zt0tsAk5/Ma/2mAK z7CfxrcKmxO+tvSaee5XfV4BtVwnGErh8l3EfvS8/ky0dGOq2p+9GF9+qhTsVM52SrTn seM7J+SxMPBfSe9CHzvcqRHVNFhQnnUlsuBrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GbBOiI0luRdJ4TU1uhQPbrOpz6Zj/LRNTSnYFlir+/8=; b=kypIHSh1JyYCu7CQIP2T0LV+ml8T8SWDPcT06cqDv9ZwRsvdb8ueXpa+o7dDMthl07 lUSp6t4gP4n/rn83XRRT2tNQhKPG3l/x8DR093ACf+B0KJHZINQmr8Rb/YAPRXOcMPK9 4vocTBRUbfHd2aZaRmBzllSeqKoQe2Uazdagw5/p+eqKO7pOc62nNz+m3xxEMSbtf9Xl MRMsTdTv/oZwKf8L14kCm/v7u2Qe2PygyxnKYfwJvl4rQPEvikRsmjaF+6tj6KgtdMKE eOnoa+atDc9WJyoFQ5UNQ9emKENiFVQqTAeUOANDeITkRReI/2Mf5bwbMlieQBS6qcp8 Kzhw== X-Gm-Message-State: APjAAAX+3RZW2GbiPWeopkZRx8+CgyqAO4M25I4zt3c6AzAOa3cARaIf b/+60ONf/7RlWDTbXlgzjkIDCza+bTHiVcu5 X-Google-Smtp-Source: APXvYqyBL9AgXoG4ug3wNb1Zt+WntCNNxtKPsqBgIz9LFaGFJZ18x2UZT63OgDh7ECw6/WWtwfGNLA== X-Received: by 2002:a1c:dc84:: with SMTP id t126mr6962723wmg.143.1556276068896; Fri, 26 Apr 2019 03:54:28 -0700 (PDT) Received: from localhost.localdomain (84-238-136-197.ip.btc-net.bg. [84.238.136.197]) by smtp.gmail.com with ESMTPSA id c20sm32259294wre.28.2019.04.26.03.54.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 03:54:28 -0700 (PDT) From: Nikolay Aleksandrov To: netdev@vger.kernel.org Cc: roopa@cumulusnetworks.com, stephen@networkplumber.org, Nikolay Aleksandrov Subject: [PATCH iproute2] ip: mroute: add fflush to print_mroute Date: Fri, 26 Apr 2019 13:54:21 +0300 Message-Id: <20190426105421.32139-1-nikolay@cumulusnetworks.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Similar to other print functions we need to flush buffered data in order to work with pipes and output redirects. After this patch ip monitor mroute &>log works properly. Signed-off-by: Nikolay Aleksandrov --- ip/ipmroute.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipmroute.c b/ip/ipmroute.c index b29c78e4cc86..ede09ca96412 100644 --- a/ip/ipmroute.c +++ b/ip/ipmroute.c @@ -57,6 +57,7 @@ int print_mroute(struct nlmsghdr *n, void *arg) struct rtmsg *r = NLMSG_DATA(n); int len = n->nlmsg_len; struct rtattr *tb[RTA_MAX+1]; + FILE *fp = (FILE *)arg; const char *src, *dst; SPRINT_BUF(b1); SPRINT_BUF(b2); @@ -209,6 +210,7 @@ int print_mroute(struct nlmsghdr *n, void *arg) print_string(PRINT_FP, NULL, "\n", NULL); close_json_object(); + fflush(fp); return 0; }