From patchwork Fri Apr 19 11:01:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1088249 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44m9zx3VHfz9s9G for ; Sat, 20 Apr 2019 08:45:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727405AbfDSWps (ORCPT ); Fri, 19 Apr 2019 18:45:48 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:46987 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfDSWpq (ORCPT ); Fri, 19 Apr 2019 18:45:46 -0400 Received: from mail-pf1-f198.google.com ([209.85.210.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hHRGv-0007gP-UE for netdev@vger.kernel.org; Fri, 19 Apr 2019 11:01:34 +0000 Received: by mail-pf1-f198.google.com with SMTP id e128so3290044pfc.22 for ; Fri, 19 Apr 2019 04:01:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4zumaoHX4/zdp5RahruJBE+aNHMM3t7aIPQU+OcoHVU=; b=RhkqblUazzYZNvVFf568Watc0w1b4ix/Rc5T/HDNe9obLp2EqZCqTAw0qf/ARAhQNJ f3he9lyBkLXl2qkhId7vbSxtpQt9xH8jURZAuQWFEHVyygdyjgmUprORNDbyINwoWjoA qsn6huuixFOw7c9kamLdj1Drm2mgk8hOZAPCcz/RbaENIG43YLFBdzRBNehFjvVvj93K 1km2ZTslj8FcqSNwVZmNZqJWtil+kjBrERJ1AWBqkqxxhqv30SmO1DisTfRn+oZ/s9ps LiEOM7ym9hUW++rUCwQcwFuYlzW8KBKx71ZyB/I5N0GG4DIFwP/E74DnVBemGGSd/6RM ZGpg== X-Gm-Message-State: APjAAAVsNPCJ8kKt2WQUafqUTfHpNo1neqWIbsybsozEaffspi0aP0Jz xacVkHzWK/n56S3g3qttSjw737g3LDsVyxH9AGIDKNbXcTX8TyeVPqvqsd8KHe8y5fGVtFvVYCN F3qz3YgNNN5TswJpa3NBBAKS+2N2mu+DD X-Received: by 2002:a17:902:2e83:: with SMTP id r3mr3125966plb.153.1555671692389; Fri, 19 Apr 2019 04:01:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/umxfLgneWYgiIPHMQ/V3HSAR433aTxgXGkSxHXmeyy5mTvECAO/hjxqKWm4KV3QtQrUl1g== X-Received: by 2002:a17:902:2e83:: with SMTP id r3mr3125908plb.153.1555671691786; Fri, 19 Apr 2019 04:01:31 -0700 (PDT) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id r87sm8044020pfa.71.2019.04.19.04.01.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 04:01:30 -0700 (PDT) From: Po-Hsu Lin To: shuah@kernel.org, davem@davemloft.net Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/net: correct the return value for run_afpackettests Date: Fri, 19 Apr 2019 19:01:13 +0800 Message-Id: <20190419110113.21883-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The run_afpackettests will be marked as passed regardless the return value of those sub-tests in the script: -------------------- running psock_tpacket test -------------------- [FAIL] selftests: run_afpackettests [PASS] Fix this by changing the return value for each tests. Signed-off-by: Po-Hsu Lin --- tools/testing/selftests/net/run_afpackettests | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/run_afpackettests b/tools/testing/selftests/net/run_afpackettests index 2dc95fd..ea5938e 100755 --- a/tools/testing/selftests/net/run_afpackettests +++ b/tools/testing/selftests/net/run_afpackettests @@ -6,12 +6,14 @@ if [ $(id -u) != 0 ]; then exit 0 fi +ret=0 echo "--------------------" echo "running psock_fanout test" echo "--------------------" ./in_netns.sh ./psock_fanout if [ $? -ne 0 ]; then echo "[FAIL]" + ret=1 else echo "[PASS]" fi @@ -22,6 +24,7 @@ echo "--------------------" ./in_netns.sh ./psock_tpacket if [ $? -ne 0 ]; then echo "[FAIL]" + ret=1 else echo "[PASS]" fi @@ -32,6 +35,8 @@ echo "--------------------" ./in_netns.sh ./txring_overwrite if [ $? -ne 0 ]; then echo "[FAIL]" + ret=1 else echo "[PASS]" fi +exit $ret