From patchwork Thu Apr 18 11:57:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1087556 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44lHfs3gBpz9s5c for ; Thu, 18 Apr 2019 21:57:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388906AbfDRL5x (ORCPT ); Thu, 18 Apr 2019 07:57:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:37011 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388535AbfDRL5v (ORCPT ); Thu, 18 Apr 2019 07:57:51 -0400 Received: from mail-pg1-f198.google.com ([209.85.215.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hH5fp-0004ZJ-CB for netdev@vger.kernel.org; Thu, 18 Apr 2019 11:57:49 +0000 Received: by mail-pg1-f198.google.com with SMTP id 33so1221233pgv.17 for ; Thu, 18 Apr 2019 04:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=etpmiN+xcWyQHOYZT0YCvEMFjAgyXGH8FrUy6K2Kx3w=; b=Disa6h5lJkmhQ8309uAWl/PL+qWHsxB7kc1I5kBW/cXGXFwitgePGFjGIaOpKEyFjT IRSfvFIqy8oT6JoLJBhjgANlh13HqUjYy8XsEK/zfpYmWkF4nxWLUda473ezfOD3f6pq /jDifjCEb78dfKAit/sJUPcNuBHbkoCAkBvqkL0AvNepM+nJIweHZAEXIGpNZORHRrmD Nbwhl6JPBBaK4dAZjV0qEQ/U2oSy0LdEvpLNvut2HbZEIjgChz5Lz4Q6FeKs2hHpwa/t /ayjV4t1qUN2FXImOmsk0wvdWqtiOaZeXU7tXk1XaQZFWewmHdPnv5UxIJu/esDaENvk Tvtg== X-Gm-Message-State: APjAAAVi3X1gHXUB9npMYU071/Eazm3SNGrFuGeAmnLlKe7+E89198s/ m49yXOUOFMgcZ51MaL2/P9y/Dy5R3wQGXDpT3ASAwwBzQJGo+ByaQrbsr8iRy+mWCD9qKfqdzBf 6R1z4ISxt+MTbfjDlnEFuUWm8xyWHAkO5 X-Received: by 2002:a63:dd10:: with SMTP id t16mr5205603pgg.446.1555588667913; Thu, 18 Apr 2019 04:57:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCeCihKAZ3Cz74jx9FqsFyclFv67+Cd1vJpg1Rqha19b+iOYdufXpNs5femRBF2vGeLftk9g== X-Received: by 2002:a63:dd10:: with SMTP id t16mr5205577pgg.446.1555588667511; Thu, 18 Apr 2019 04:57:47 -0700 (PDT) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 8sm3321382pfs.50.2019.04.18.04.57.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 04:57:46 -0700 (PDT) From: Po-Hsu Lin To: shuah@kernel.org, davem@davemloft.net Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/net: correct the return value for run_netsocktests Date: Thu, 18 Apr 2019 19:57:25 +0800 Message-Id: <20190418115725.6833-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The run_netsocktests will be marked as passed regardless the actual test result from the ./socket: selftests: net: run_netsocktests ======================================== -------------------- running socket test -------------------- [FAIL] ok 1..6 selftests: net: run_netsocktests [PASS] This is because the test script itself has been successfully executed. Fix this by exit 1 when the test failed. Signed-off-by: Po-Hsu Lin --- tools/testing/selftests/net/run_netsocktests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests index b093f39c2..14e41fa 100755 --- a/tools/testing/selftests/net/run_netsocktests +++ b/tools/testing/selftests/net/run_netsocktests @@ -7,7 +7,7 @@ echo "--------------------" ./socket if [ $? -ne 0 ]; then echo "[FAIL]" + exit 1 else echo "[PASS]" fi -