From patchwork Fri Sep 1 11:56:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 808668 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YJAS81h8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xkHqY2J2pz9sRV for ; Fri, 1 Sep 2017 22:00:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdIAL75 (ORCPT ); Fri, 1 Sep 2017 07:59:57 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34127 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755AbdIAL6P (ORCPT ); Fri, 1 Sep 2017 07:58:15 -0400 Received: by mail-wm0-f65.google.com with SMTP id l19so12399wmi.1; Fri, 01 Sep 2017 04:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gvROtUfymQ7THv1hV7eRAf8onsm4EXMKfr4EszPA0zY=; b=YJAS81h8pruxeIWKiT41V0v3NNp6fY2uLKWBsf2AodiOULk88Dm0rScveonLCvSBaZ kOofE5yVNLNnh5pTJkLP0JoLLi25hpTb8QJ44utHECo3h+8hRilz/eHzP2I4uZJyvrPf CItzo7WG+IJAgyQbET2cD5iQ8CY5AwR495kcM1JI7O4QS8c1Pn2RLj/HK0ov/xLVW4VT jlwlbIHKyh0x+eLAl4skfjyM7mFCx3ntrJt1oHteeOkNJz1tcOHtRsu56V8zJjszmLlZ O9QOBR5PP7YW6/3DgOfQ4u1/BdCToSTlJ6h4zuzPHdEjf9eAnmiPEeEx0S9hdyxAsH0U rqcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gvROtUfymQ7THv1hV7eRAf8onsm4EXMKfr4EszPA0zY=; b=Kgv16foFuT/AgoXCAia9qaEsh/6Bdw1QEDW84l4Wtjk1ZV0Sq3R0dHYbY8VttrRIbq F6rqxFrMxy9PDLTvBmmthFUL5cOPZtZ67lUMR3Aw40jPsEqerXqyiCBg1TSbMtHCPHno 2RmUlKd5c1DqlvjF1c6SkDLbKWLq56pvST4+Yhk8VKhYwZPipayYjZiVeayQBW1K244C 1P4P1Hp3G0CzP6vN2fMiEXrWEwhA1Pt86N8czWJzqrNuEb74RstvF0V1GeFE+YOiobpV S07laasK7gimFjl8GpMgIzCuKkm4NEMEGVJq2/3oqjMKN9WGFlyKIFyG9/Jo1VnQIv2y 6ETg== X-Gm-Message-State: AHPjjUgR5adLGicwcPvzVIGMeNQgSQOVD/JS4PLVP/EfYPBsk4J+TzeV vI/TMuXsr3jT5Q== X-Google-Smtp-Source: ADKCNb4KSPWXYw5aS2PIT77u+HVacOY+/Ak1DpTrr7EECpK7Qlryu3tOtV43f+l30LGGofdGE2/59g== X-Received: by 10.28.151.85 with SMTP id z82mr278757wmd.67.1504267093968; Fri, 01 Sep 2017 04:58:13 -0700 (PDT) Received: from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr. [90.118.156.78]) by smtp.googlemail.com with ESMTPSA id p80sm3292wmf.13.2017.09.01.04.58.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 04:58:13 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 1/5] net: mdio-mux: Fix NULL Comparison style Date: Fri, 1 Sep 2017 13:56:00 +0200 Message-Id: <20170901115604.27513-2-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com> References: <20170901115604.27513-1-clabbe.montjoie@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fix checkpatch warning about NULL Comparison style. Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 942ceaf3fd3f..b18ad7082b88 100644 --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -120,7 +120,7 @@ int mdio_mux_init(struct device *dev, } pb = devm_kzalloc(dev, sizeof(*pb), GFP_KERNEL); - if (pb == NULL) { + if (!pb) { ret_val = -ENOMEM; goto err_pb_kz; } @@ -144,7 +144,7 @@ int mdio_mux_init(struct device *dev, } cb = devm_kzalloc(dev, sizeof(*cb), GFP_KERNEL); - if (cb == NULL) { + if (!cb) { dev_err(dev, "Error: Failed to allocate memory for child %pOF\n", child_bus_node); From patchwork Fri Sep 1 11:56:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 808663 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kWTNo+zK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xkHnW1Pk3z9t1t for ; Fri, 1 Sep 2017 21:58:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbdIAL6U (ORCPT ); Fri, 1 Sep 2017 07:58:20 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33212 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdIAL6Q (ORCPT ); Fri, 1 Sep 2017 07:58:16 -0400 Received: by mail-wm0-f67.google.com with SMTP id m85so17667wma.0; Fri, 01 Sep 2017 04:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cPck0iDFsroWtQQwlVv1tnaWseUHC2gQQ9tJrWPs+/E=; b=kWTNo+zKOyCPd34GpWoUUQDfJOqEWCndnh1KvxABQo+D0LhGwr7iDRlwK9Fr4tMhmH RJrnZG63Oz2v0o52R3WYi03CkktpQZjNrbhtueV+A7cqfAYMrB0t+1YCEgS2hnkdLQdN NORWp1zBN6pos/Fzc0vsEWZJHHV0by43qPHjW1WsgL0xPY/88UcfuWnVmTtz5uPgrXCJ GLVSeIzoKRq1xQTWDLzzb2pgb5kvCXRqgIwh08Zs9BkjlciMgM+8CkkRmKf8KIO54UPn fQ7yaothPDn8/2YLi4JLpmd/7oUhZd96U5UU59LPLqTOljEOdUXvk/0eqbYj2aA7kTQa 6dWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cPck0iDFsroWtQQwlVv1tnaWseUHC2gQQ9tJrWPs+/E=; b=oowXV2dKMTOdQKmz2b33RZex7L5gteFEWzXXhcZ3JSJ+WU6cOJvAdLxEgCgHXmj/Hp iQSLhXdiJBxaMUuIhQzyqdiMzBxcGJJVgckBEw13c9KUu4BMbW+sXuJskX8dZgPyKusV vZqLfqbrNX/3cfoygfCC0NpiIjvyz8EUbnjmviVSq5xZT4N8JP6Ftx9G654iXcuWNnLe gnp2Fa1y46G2A4zgsyM2WPrE6D+BrkKLxtbgxHNHfGTLowty4pugd10ousMfUWoCc2a4 eiw/hGv1Ocb/j/cp+ckG/58Kydz0OFcqGM4zIwmXo+aAhYmloY/ggFx1ET2XMqb1/pj5 25Sg== X-Gm-Message-State: AHPjjUieUb5WCGmdAJUKlVb1tKuVhH/r5nbIpliqjT1CrywDPEUEbuAJ h87BoHVT2G5R9E6e X-Google-Smtp-Source: ADKCNb7w0uvXrfw7PxW64CBz+7MXchKhF9tNCAZpuoNZ0c66ONagVKcGYMsgOBBwgRu/0Wub7CEqrQ== X-Received: by 10.28.232.157 with SMTP id f29mr313063wmi.56.1504267094943; Fri, 01 Sep 2017 04:58:14 -0700 (PDT) Received: from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr. [90.118.156.78]) by smtp.googlemail.com with ESMTPSA id p80sm3292wmf.13.2017.09.01.04.58.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 04:58:14 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Date: Fri, 1 Sep 2017 13:56:01 +0200 Message-Id: <20170901115604.27513-3-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com> References: <20170901115604.27513-1-clabbe.montjoie@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fix checkpatch warning about unnecessary 'out of memory' message. Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio-mux.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index b18ad7082b88..5e08e89465c5 100644 --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -145,9 +145,6 @@ int mdio_mux_init(struct device *dev, cb = devm_kzalloc(dev, sizeof(*cb), GFP_KERNEL); if (!cb) { - dev_err(dev, - "Error: Failed to allocate memory for child %pOF\n", - child_bus_node); ret_val = -ENOMEM; continue; } @@ -156,9 +153,6 @@ int mdio_mux_init(struct device *dev, cb->mii_bus = mdiobus_alloc(); if (!cb->mii_bus) { - dev_err(dev, - "Error: Failed to allocate MDIO bus for child %pOF\n", - child_bus_node); ret_val = -ENOMEM; devm_kfree(dev, cb); continue; From patchwork Fri Sep 1 11:56:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 808665 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tyl93eVg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xkHph2MqBz9sRV for ; Fri, 1 Sep 2017 21:59:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbdIAL6T (ORCPT ); Fri, 1 Sep 2017 07:58:19 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35246 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbdIAL6R (ORCPT ); Fri, 1 Sep 2017 07:58:17 -0400 Received: by mail-wr0-f194.google.com with SMTP id a47so3538wra.2; Fri, 01 Sep 2017 04:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NxUydxjyulKeV95X6hMqeoHF2yjezd5qKdT06836Ll0=; b=tyl93eVgGwQN5y2dDRRbU9dZTwmMaGzQDrjpZPUzMTQTvrNtWXydvnrmMBxw1cC1o9 6Qfieig0kqCGbzWIwwWejIsmosHOwc36fkYXV2pb/5uwGZCHIs7Hsu2xzVLYYE1NCqIt 2QIzqJudfrbeaNhgbMAq+LlhstP1teZLWvagTBG1+vv0o5x2IQQS2UCHyFOhy3f1/qA9 h3rfzwsrU3pYM5guRyzudKi0K0c6DSdJbEjwmGcAVXyTfytdwfw3eIP0Zqu+VIPEBrrt nK7i2oRrvz3sLy/TUeVX+BLMhSjIgCbnmQtktrtP4Defnqkv7RPe7Vn5d86NxS9dc74q aZRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NxUydxjyulKeV95X6hMqeoHF2yjezd5qKdT06836Ll0=; b=ZPSQmJifGMyBNDrj0Mtc08WWs+wesqTI4pupKQkFp9UnCStu9o5PeAIT1Hot+HRrOH TxEYbEVtdWyvcLlXYo4dXFsBL579o2V6N4du3ZcKk+hu5wYu5HIkpnRB10iUKefXaP8I I3lztI3o0Zkt2VqvbjMJm9sUPdSqdbR3kN0erRcbZgsL6XnZKhw86n4zKUSXk4afKl42 JVf7MV6qvtO4vNHE95jsbfYoRNQ5fmfsnNTRk7nSeh+CnwoSP69ub6i1tPZXYwPgQ+fp xBCAJLW6DS4o9SqvVMepxUMCpVQfYE7/3lsIqoIrnX6BQSqmUS0j4zEzycS7PIIqvdQ4 I2CA== X-Gm-Message-State: AHPjjUjEqBG/cjpvCptWhjAarQh1PJJ2gYNPurmBeU4aMP08zoFWeu5g tAFk4l2qdevkBQ== X-Google-Smtp-Source: ADKCNb7RlBnWF9ccgA8JQdUa60WK/vdm0hPGya92WBB0o2CPy6HhJhGoMegm4qVt+QAaP93oFairFg== X-Received: by 10.223.130.40 with SMTP id 37mr999939wrb.333.1504267095929; Fri, 01 Sep 2017 04:58:15 -0700 (PDT) Received: from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr. [90.118.156.78]) by smtp.googlemail.com with ESMTPSA id p80sm3292wmf.13.2017.09.01.04.58.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 04:58:15 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 3/5] net: mdio-mux: printing driver version is useless Date: Fri, 1 Sep 2017 13:56:02 +0200 Message-Id: <20170901115604.27513-4-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com> References: <20170901115604.27513-1-clabbe.montjoie@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove the driver version information because this information is not useful in an upstream kernel driver. Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio-mux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 5e08e89465c5..282828551bdd 100644 --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -13,7 +13,6 @@ #include #include -#define DRV_VERSION "1.0" #define DRV_DESCRIPTION "MDIO bus multiplexer driver" struct mdio_mux_child_bus; @@ -179,7 +178,6 @@ int mdio_mux_init(struct device *dev, } if (pb->children) { *mux_handle = pb; - dev_info(dev, "Version " DRV_VERSION "\n"); return 0; } @@ -212,6 +210,5 @@ void mdio_mux_uninit(void *mux_handle) EXPORT_SYMBOL_GPL(mdio_mux_uninit); MODULE_DESCRIPTION(DRV_DESCRIPTION); -MODULE_VERSION(DRV_VERSION); MODULE_AUTHOR("David Daney"); MODULE_LICENSE("GPL"); From patchwork Fri Sep 1 11:56:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 808666 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IufRVJmy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xkHq21QKqz9s7M for ; Fri, 1 Sep 2017 21:59:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbdIAL72 (ORCPT ); Fri, 1 Sep 2017 07:59:28 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35248 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715AbdIAL6S (ORCPT ); Fri, 1 Sep 2017 07:58:18 -0400 Received: by mail-wr0-f196.google.com with SMTP id a47so3561wra.2; Fri, 01 Sep 2017 04:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zdxlwoWwSQe6cJCSvJJ47Vobly+MygkCTskdI+WtCMk=; b=IufRVJmydXZPB7ZOgo2jGU82OFUeaJtf3p79dbORm196u/VApap7u/dkllbPJn/X/a vU5C1tjJArfe02cbBfVKgmObpEzaZage/TRfC1ySkM7kV46rx5C8HY81zlHcTto6I1Ve VrHhc7T6EvgtcRvxvsUxhJxSnWJmDpoQ45FfkYqLEQ0ZJhreRgdfdwxsJfs3FA3Bi1g5 PZYE+0lhFYGr67RSxYdcHY+e3xCgz/sEECDetnl2dzbHZI/SGISeMq30UtwnBwXSESo3 /jsaqodJupnoerd9wP/tJxqGOthiNnnnESAkhgknWGxzwVHr9ZZiJi65VNndfG9FcVhC 3rtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zdxlwoWwSQe6cJCSvJJ47Vobly+MygkCTskdI+WtCMk=; b=OC2JPyhvy1hEZ1oIkchC7zL0Pyxdt5b3o/+iljCUgnPqijX1i1at2SeCgV1KHdFsAe bP8GlPjFcVWLFGHPQ8VYD3ducrQoevIQUgQYPIgNt+YRIxovRsXEPLFuRtkj1k+bQpqy KpgjlgLcfy3HBspnda3FdrrJwsePIs9I4cetRp1MqS4v7j1RuvbYnJyi9X0+dAqBOmiA nQiJCd6t0MOK9pOAKhth2GqhxAoEGVy+g2kgBVpD9OfyHVAjjqfT8jJMAZXc8Qnu4W/3 WjtciS0yxEXEBWyriPalut8tHyTGIRCYzgwkFa8LZwbq8wfqotvwa9mnY/Fffe+CI8N7 0ILw== X-Gm-Message-State: AHPjjUjgHiwbwX1pS0KHhE9FbLqTCDmrRr9FUF78sj6MHKQj3tEbPmeq BEP4LzRF9sQH6w== X-Google-Smtp-Source: ADKCNb4C9W07TLTBu9xUQ+H2cDcjG28YzqBeNEZz/lTOuM1qYWDuG20B9ryMwsZPIH0VZgOc7xoRoQ== X-Received: by 10.223.166.38 with SMTP id k35mr1003156wrc.183.1504267097003; Fri, 01 Sep 2017 04:58:17 -0700 (PDT) Received: from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr. [90.118.156.78]) by smtp.googlemail.com with ESMTPSA id p80sm3292wmf.13.2017.09.01.04.58.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 04:58:16 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Date: Fri, 1 Sep 2017 13:56:03 +0200 Message-Id: <20170901115604.27513-5-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com> References: <20170901115604.27513-1-clabbe.montjoie@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fix an old information that mdio-mux-mmioreg can only handle 8bit registers. This is not true anymore. Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 5afe6fdcc968..a9d16a3af514 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -85,7 +85,7 @@ config MDIO_BUS_MUX_MMIOREG parent bus. Child bus selection is under the control of one of the FPGA's registers. - Currently, only 8-bit registers are supported. + Currently, only 8/16/32 bits registers are supported. config MDIO_CAVIUM tristate From patchwork Fri Sep 1 11:56:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 808664 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l2nyDb/J"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xkHpT4tMQz9sRV for ; Fri, 1 Sep 2017 21:59:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdIAL7B (ORCPT ); Fri, 1 Sep 2017 07:59:01 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35252 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbdIAL6T (ORCPT ); Fri, 1 Sep 2017 07:58:19 -0400 Received: by mail-wr0-f195.google.com with SMTP id a47so3578wra.2; Fri, 01 Sep 2017 04:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8VJWXzlTgtoWB6G6ZFoyXEF+RflzUmXRwen/GWujV5U=; b=l2nyDb/JX2i508wSce/C3BbjjE+TvKaZ7orcyOvJfEv0qHfMUBrCaQhp86LEds1c+3 ZyTKpnIjj0JQaU6RiiCIO4fyXzUM87KEmeb2jwUp7K9RdI+V5z4VUHo7zi4BMhCAplPo r6GPMvnIXZjaNv+5c8p/9n8wKU633lRgMccz3Kfbq2pt7BsrOFgm52EWl2pyM1QcqiWc YAOJOEYYLjAMn76h/U7TYaI8UEqiXh24jdPVhs9Fq2yrmEGlsSGk9O7QrpzGyPeYQiTV k1O4fmFwLQqrOwYQjeeLFgae8KQXBAxwY/EKMfT6Unk86kGTrAEu5MpfQASmdbQewgg8 KeRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8VJWXzlTgtoWB6G6ZFoyXEF+RflzUmXRwen/GWujV5U=; b=OtWwrdzpjE0jBD96wUOJIg84jSd7itwsyYhxvgNuQFrHqazxZbR8brycejI9TncF13 wsOBTcU4NchFE7/aJKVehf5hWKYpBO0QDMMoep3TIo2DtEraivfdC4KxUX0mJEvChjCZ CqiP1535IlR4F5gfcppLZAzQtuKeXdiflnLS9DLax525oDyHE1uYUvBrMgU3CkK3Zv7f 2MrNj3kpWJKHpVxAtWSeTBfX2dHIFqSu0F5IbgQXulfLDIe/SevsINR3K/MvoM8SNGJE HRLjmfpEibmoM+GMBzw4mH8L3U4Fg3TrLYEioKM8h5rA+2KTZ5mHqFLqgGBJlacqZkie ClNw== X-Gm-Message-State: AHPjjUgHAN3ToqpQTmotRm9O3K6T7/8j9FpQDlgJmKBenEV3raZ3N7uZ BSg8urN6LxuvDA== X-Google-Smtp-Source: ADKCNb6PmpEqKBRi/p+cj/PStVFp1CuRgmMkNTl0+S88kV7WBWC3If9vNHMLIvN8TjGUunkvWQd4vw== X-Received: by 10.223.137.17 with SMTP id s17mr1090541wrs.285.1504267097982; Fri, 01 Sep 2017 04:58:17 -0700 (PDT) Received: from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr. [90.118.156.78]) by smtp.googlemail.com with ESMTPSA id p80sm3292wmf.13.2017.09.01.04.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 04:58:17 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device Date: Fri, 1 Sep 2017 13:56:04 +0200 Message-Id: <20170901115604.27513-6-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com> References: <20170901115604.27513-1-clabbe.montjoie@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org mdio_mux_uninit() call put_device (unconditionally) because of of_mdio_find_bus() in mdio_mux_init. But of_mdio_find_bus is only called if mux_bus is empty. If mux_bus is set, mdio_mux_uninit will print a "refcount_t: underflow" trace. This patch add a get_device in the other branch of "if (mux_bus)". Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio-mux.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 282828551bdd..6f75e9f27fed 100644 --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -116,6 +116,7 @@ int mdio_mux_init(struct device *dev, } else { parent_bus_node = NULL; parent_bus = mux_bus; + get_device(&parent_bus->dev); } pb = devm_kzalloc(dev, sizeof(*pb), GFP_KERNEL); @@ -184,9 +185,7 @@ int mdio_mux_init(struct device *dev, dev_err(dev, "Error: No acceptable child buses found\n"); devm_kfree(dev, pb); err_pb_kz: - /* balance the reference of_mdio_find_bus() took */ - if (!mux_bus) - put_device(&parent_bus->dev); + put_device(&parent_bus->dev); err_parent_bus: of_node_put(parent_bus_node); return ret_val; @@ -204,7 +203,6 @@ void mdio_mux_uninit(void *mux_handle) cb = cb->next; } - /* balance the reference of_mdio_find_bus() in mdio_mux_init() took */ put_device(&pb->mii_bus->dev); } EXPORT_SYMBOL_GPL(mdio_mux_uninit);