From patchwork Wed Apr 3 21:57:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1076484 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dNhJuD0D"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44ZKj065Kcz9sSW for ; Thu, 4 Apr 2019 08:58:44 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbfDCV6n (ORCPT ); Wed, 3 Apr 2019 17:58:43 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:39585 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfDCV6m (ORCPT ); Wed, 3 Apr 2019 17:58:42 -0400 Received: by mail-pl1-f196.google.com with SMTP id b65so76131plb.6 for ; Wed, 03 Apr 2019 14:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=oweg3xQum4NpLUt15PWLAjw4wmrFzLtlu9RZq1LKdM0=; b=dNhJuD0DV1tQgKoSeDXUSoNx4Ct8vJLxA0Yw2DpBVVH2wNFPp/p6QRz8oEd4IpaH4Z jBNn0R8KxuUh6pOgYII0H6e+1H4uLdVXADAfKhOtQMdlzHTPHRZ94lhVmzr9JgHodttT gT6myhMzwLKrq1sh99ayYTF25GVfL3SK4L7fFyrrl/iDVBy2c6sCsYMQSRC86CDvamUO w0E2lrRjdRjNUvvU+U7jvyJuVfQ89GzoHzC4NDpNa5G8fiFNjGDrakIuap0GTXWUnMNh tWiGK8VOmNb78smZycAlyIsJyK+I+fY85P6ZeHkllN+tZcFbaTgAYTGWk6tIvWFFGltm XDfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=oweg3xQum4NpLUt15PWLAjw4wmrFzLtlu9RZq1LKdM0=; b=ZcN0al+v+J5aD5m52qB2nqsTnCfa9TD5liQiiIllH2+2E561whqddSfkMnOcBUl4y1 AUy9doHxMdpUULRcjR7s/cLZLRf4D+PUGeGtauwC0amYNlkirZ3y8O8Y1cpW8Pr5mJM8 Cp7Sj8gXwFfUid1+slMmtpdyXjpsE+MgNUCR1AAWKytyok5hxS1obJfBX4WVgC+f4d6/ TKyBkVdea7CgZfOBy5i8A7pjGAqpIr86C7HkFLZW2u2tDee/lQSNxLfvZIYEEQ+HM3uZ 7vslnswWPZtfPfxBcMVk8Z8j/W/71KYgsTkeeyXwrFQXlJozktyUma8uesBnPlC88stz pIBg== X-Gm-Message-State: APjAAAU2ndO/3mWG5GAy9E+n6aq9/QE0vfhTRcPJOacs/keNGsZ6hlOz HnmE5xbI5pjmDot0iIU7KajCmkSB X-Google-Smtp-Source: APXvYqwxYK885lvDxR44IXR1sFzH9+qHJoJZ8WY9vIRG/a38/aUdUm+zON+ZkYBckc5bthdf7jnkJg== X-Received: by 2002:a17:902:765:: with SMTP id 92mr2366012pli.95.1554328721571; Wed, 03 Apr 2019 14:58:41 -0700 (PDT) Received: from sc9-mailhost3.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id b2sm18078001pfo.150.2019.04.03.14.58.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Apr 2019 14:58:40 -0700 (PDT) From: William Tu To: netdev@vger.kernel.org, bjorn.topel@intel.com, daniel@iogearbox.net, ast@kernel.org, magnus.karlsson@intel.com Subject: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Date: Wed, 3 Apr 2019 14:57:55 -0700 Message-Id: <1554328676-10715-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The tx bytecount is done twice. When running './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' The avg packet size is 120 instead of 60. So remove the extra one. Signed-off-by: William Tu --- drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c index bfe95ce0bd7f..71b8474a9b4c 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, xsk_frames++; tx_bi->xdpf = NULL; - total_bytes += tx_bi->bytecount; tx_bi++; tx_desc++; From patchwork Wed Apr 3 21:57:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1076485 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D/zsj3xx"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44ZKj20g8kz9sSX for ; Thu, 4 Apr 2019 08:58:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbfDCV6n (ORCPT ); Wed, 3 Apr 2019 17:58:43 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35995 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfDCV6n (ORCPT ); Wed, 3 Apr 2019 17:58:43 -0400 Received: by mail-pl1-f194.google.com with SMTP id ck15so83122plb.3 for ; Wed, 03 Apr 2019 14:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=GjL4bb2djrsBh2JYt2MXTTEB6EJaPWnZyfsvTgrzvBo=; b=D/zsj3xxIKnu/bjtDbQToKP97siswRder46aV6tti9+8OqOgUQw+e50H7wYFWf48/P TFw/ApkI9mldHAse972C248+/DqMrxahKK0Y0QlDxVmj52HDoGnlUx8Ynbip7buc56zf WZiNBLvadIWYDUmSDD9fh233Pe3xNVUwz+kDBS9QdoqZrDTUh1PofUewm+3isIVo/JGU 3oK8xpxWebcdl7T3gs79SFbyj+mU59tQb+GAT1tITwOKrEzw3WaI2A44QWFhtYBJYSls n4qaTTQlx1l/8LoHgxjErRlwhX6l10mqyXrE4m5anqKaSPGFkdco2gp97aH1CwwVP3Yq Whzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=GjL4bb2djrsBh2JYt2MXTTEB6EJaPWnZyfsvTgrzvBo=; b=E7nqtrGfys3ALZ0Iwg8lBa4KKGCyXwyfV5jrIEHpSDjCHb7O0Nwl70fXLbjGXsidLM MRebJhohqYpBQ847JxYo5XlKW8NJMIX00TGuJJbGehu/yJTOYr4FUSTIf+fUke4taiVg yMSRCGDxnuWkC6fcYeJcs1jmt5HxjqXOP6TM8qQX7nFw2cjBgsQVjUC9zeccgLOy9d/A YLczGqhOeHd9s6WpRX4naNUoQE0H6TMW7J3JLX0Kt/8ZoZYj9XOppv4nFB2oqxyC3aHK hehOLkRTqfLQDrkyyg3BxQgXRG+TJOs9OfwteULPNuxlc5R39ilArRC+0uTj23xr34yB ADYQ== X-Gm-Message-State: APjAAAXFS736qLgOSFQnBxv8t+zE+WAyw0YYbXYM5IkScqqZoMV7k4J3 9zra1Mm4OAnqrKkgfFPdZ8u+IJ+v X-Google-Smtp-Source: APXvYqzBA6D6aQj45qwCdw/+4xZeunGHdn+hNPoublfB4OHzGJGrOLtBCTEjWzB0zoo+lYsi9wWXGA== X-Received: by 2002:a17:902:31c3:: with SMTP id x61mr2345010plb.143.1554328722468; Wed, 03 Apr 2019 14:58:42 -0700 (PDT) Received: from sc9-mailhost3.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id b2sm18078001pfo.150.2019.04.03.14.58.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Apr 2019 14:58:41 -0700 (PDT) From: William Tu To: netdev@vger.kernel.org, bjorn.topel@intel.com, daniel@iogearbox.net, ast@kernel.org, magnus.karlsson@intel.com Subject: [PATCH bpf 2/2] ixgbe: fix AF_XDP tx packet count. Date: Wed, 3 Apr 2019 14:57:56 -0700 Message-Id: <1554328676-10715-2-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554328676-10715-1-git-send-email-u9012063@gmail.com> References: <1554328676-10715-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The total_packets count at ixgbe_clean_xdp_tx_irq is always zero when testing with xdpsock -t -N. Set the gso_segs to 1 to make the tx packet count correct. Signed-off-by: William Tu --- drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c index 71b8474a9b4c..1a60764fb39b 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c @@ -640,6 +640,7 @@ static bool ixgbe_xmit_zc(struct ixgbe_ring *xdp_ring, unsigned int budget) tx_bi = &xdp_ring->tx_buffer_info[xdp_ring->next_to_use]; tx_bi->bytecount = len; tx_bi->xdpf = NULL; + tx_bi->gso_segs = 1; tx_desc = IXGBE_TX_DESC(xdp_ring, xdp_ring->next_to_use); tx_desc->read.buffer_addr = cpu_to_le64(dma);