| Message ID | 1431011522-28610-1-git-send-email-andrew.burgess@embecosm.com |
|---|---|
| State | Accepted |
| Commit | ec0827d3c2af5c9569c04cbb6f57a3c581583722 |
| Headers | show |
On Thursday 07 May 2015 08:42 PM, Andrew Burgess wrote: > When attempting to build uClibc under buildroot, including building the > tests, the silly tests don't currently compile, a result of attempting > to build using a compiler that does not yet have an installed version of > uClibc available. The error is a missing header file, specifically > atomic.h. > > Taking inspiration from the nptl tests, I have extended the EXTRA_CFLAGS > variable to add the required include paths. The tests can now be built > under buildroot. > > Signed-off-by: Andrew Burgess <andrew.burgess@embecosm.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Thx, -Vineet
On Fri, May 08, 2015 at 10:30:37AM +0000, Vineet Gupta wrote: > On Thursday 07 May 2015 08:42 PM, Andrew Burgess wrote: > > When attempting to build uClibc under buildroot, including building the > > tests, the silly tests don't currently compile, a result of attempting > > to build using a compiler that does not yet have an installed version of > > uClibc available. The error is a missing header file, specifically > > atomic.h. > > > > Taking inspiration from the nptl tests, I have extended the EXTRA_CFLAGS > > variable to add the required include paths. The tests can now be built > > under buildroot. > > > > Signed-off-by: Andrew Burgess <andrew.burgess@embecosm.com> > > Acked-by: Vineet Gupta <vgupta@synopsys.com> Applied, thanks!
diff --git a/test/silly/Makefile.in b/test/silly/Makefile.in index 9bb4032..faaff9c 100644 --- a/test/silly/Makefile.in +++ b/test/silly/Makefile.in @@ -6,3 +6,7 @@ RET_tiny := 42 # missing internal headers, disable these GLIBC_TESTS_DISABLED := tst-atomic_glibc tst-atomic-long_glibc + +EXTRA_CFLAGS := -I$(top_srcdir)libc/sysdeps/linux/$(TARGET_ARCH) \ + -I$(top_srcdir)libc/sysdeps/linux \ + -I$(top_builddir)include
When attempting to build uClibc under buildroot, including building the tests, the silly tests don't currently compile, a result of attempting to build using a compiler that does not yet have an installed version of uClibc available. The error is a missing header file, specifically atomic.h. Taking inspiration from the nptl tests, I have extended the EXTRA_CFLAGS variable to add the required include paths. The tests can now be built under buildroot. Signed-off-by: Andrew Burgess <andrew.burgess@embecosm.com> --- test/silly/Makefile.in | 4 ++++ 1 file changed, 4 insertions(+)