| Message ID | 1409221890-2516-11-git-send-email-wbx@openadk.org |
|---|---|
| State | Accepted |
| Commit | 697dbb016e4bc63d20a7c871a9580e7dce32d1b0 |
| Headers | show |
On Thu, Aug 28, 2014 at 12:31:29PM +0200, Waldemar Brodkorb wrote: > When bind() fails in this test, then /tmp get filled up with > temp files and upcoming tests will fail, because they need to create > temp files, too. Better exit from the loop. > Test still needs to be investigated to fix the failing bind(). That would be the correct thing to do first, yes. But i agree we don't have to thrash /tmp needlessly so applied. Thanks!
diff --git a/test/nptl/tst-cancel4.c b/test/nptl/tst-cancel4.c index 53abf83..4ba4045 100644 --- a/test/nptl/tst-cancel4.c +++ b/test/nptl/tst-cancel4.c @@ -1015,6 +1015,8 @@ tf_accept (void *arg) if (++tries > 10) { printf ("%s: too many unsuccessful bind calls\n", __FUNCTION__); + /* prevent endless loop, when bind fails forever */ + exit (1); } strcpy (sun.sun_path, "/tmp/tst-cancel4-socket-1-XXXXXX");
When bind() fails in this test, then /tmp get filled up with temp files and upcoming tests will fail, because they need to create temp files, too. Better exit from the loop. Test still needs to be investigated to fix the failing bind(). Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> --- test/nptl/tst-cancel4.c | 2 ++ 1 file changed, 2 insertions(+)