| Message ID | 1386585702-43020-1-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Dec 09, 2013 at 10:41:42AM +0000, Vicente Olivert Riera wrote: > Add "__pid_t _tid" member which is used for some packages, like rt-test > for instance, which fails with an error like this one: > > src/cyclictest/cyclictest.c:638:9: error: 'union <anonymous>' has no > member named '_tid' alpha, mips and sparc seem to still use an int si_band instead of a long int. Also, our __SIGEV_PAD_SIZE does not take __WORDSIZE into account. Can you update this accordingly and resubmit after successful testing, please? TIA, > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > libc/sysdeps/linux/mips/bits/siginfo.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libc/sysdeps/linux/mips/bits/siginfo.h b/libc/sysdeps/linux/mips/bits/siginfo.h > index 79fb15a..84b08ca 100644 > --- a/libc/sysdeps/linux/mips/bits/siginfo.h > +++ b/libc/sysdeps/linux/mips/bits/siginfo.h > @@ -281,6 +281,10 @@ typedef struct sigevent > { > int _pad[__SIGEV_PAD_SIZE]; > > + /* When SIGEV_SIGNAL and SIGEV_THREAD_ID set, LWP ID of the > + thread to receive the signal. */ > + __pid_t _tid; > + > struct > { > void (*_function) (sigval_t); /* Function to start. */
On 12/20/2013 02:39 PM, Bernhard Reutner-Fischer wrote: > On Mon, Dec 09, 2013 at 10:41:42AM +0000, Vicente Olivert Riera wrote: >> Add "__pid_t _tid" member which is used for some packages, like rt-test >> for instance, which fails with an error like this one: >> >> src/cyclictest/cyclictest.c:638:9: error: 'union <anonymous>' has no >> member named '_tid' > > alpha, mips and sparc seem to still use an int si_band instead of a long > int. > > Also, our __SIGEV_PAD_SIZE does not take __WORDSIZE into account. > Can you update this accordingly and resubmit after successful testing, > please? Hello Bernhard, I sent the updated patches few days ago. Have you seen them? Best regards, Vincent > TIA, >> >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >> --- >> libc/sysdeps/linux/mips/bits/siginfo.h | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/libc/sysdeps/linux/mips/bits/siginfo.h b/libc/sysdeps/linux/mips/bits/siginfo.h >> index 79fb15a..84b08ca 100644 >> --- a/libc/sysdeps/linux/mips/bits/siginfo.h >> +++ b/libc/sysdeps/linux/mips/bits/siginfo.h >> @@ -281,6 +281,10 @@ typedef struct sigevent >> { >> int _pad[__SIGEV_PAD_SIZE]; >> >> + /* When SIGEV_SIGNAL and SIGEV_THREAD_ID set, LWP ID of the >> + thread to receive the signal. */ >> + __pid_t _tid; >> + >> struct >> { >> void (*_function) (sigval_t); /* Function to start. */
diff --git a/libc/sysdeps/linux/mips/bits/siginfo.h b/libc/sysdeps/linux/mips/bits/siginfo.h index 79fb15a..84b08ca 100644 --- a/libc/sysdeps/linux/mips/bits/siginfo.h +++ b/libc/sysdeps/linux/mips/bits/siginfo.h @@ -281,6 +281,10 @@ typedef struct sigevent { int _pad[__SIGEV_PAD_SIZE]; + /* When SIGEV_SIGNAL and SIGEV_THREAD_ID set, LWP ID of the + thread to receive the signal. */ + __pid_t _tid; + struct { void (*_function) (sigval_t); /* Function to start. */
Add "__pid_t _tid" member which is used for some packages, like rt-test for instance, which fails with an error like this one: src/cyclictest/cyclictest.c:638:9: error: 'union <anonymous>' has no member named '_tid' Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- libc/sysdeps/linux/mips/bits/siginfo.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)