diff mbox series

[uclibc-ng-devel] kvx: fix asm syntax

Message ID 20230914152218.30453-1-yann@sionneau.net
State Accepted
Headers show
Series [uclibc-ng-devel] kvx: fix asm syntax | expand

Commit Message

Yann Sionneau Sept. 14, 2023, 3:22 p.m. UTC 
From: Paul Iannetta <piannetta@kalray.eu>

Previously kvx assembler considered all separators (",", "?", "=", "[]")
to be the same, this is not the case anymore hence we need to fix all
the misformed assembly.

Signed-off-by: Paul Iannetta <piannetta@kalray.eu>
Acked-by: Yann Sionneau <ysionneau@kalray.eu>
Tested-by: Yann Sionneau <ysionneau@kalray.eu>
Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
---
 libc/string/kvx/memcpy.S       | 4 ++--
 libc/sysdeps/linux/kvx/clone.S | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Waldemar Brodkorb Sept. 16, 2023, 12:12 p.m. UTC | #1 
Hi Yann,

patch applied and pushed,
 best regards
  Waldemar

yann@sionneau.net wrote,

> From: Paul Iannetta <piannetta@kalray.eu>
> 
> Previously kvx assembler considered all separators (",", "?", "=", "[]")
> to be the same, this is not the case anymore hence we need to fix all
> the misformed assembly.
> 
> Signed-off-by: Paul Iannetta <piannetta@kalray.eu>
> Acked-by: Yann Sionneau <ysionneau@kalray.eu>
> Tested-by: Yann Sionneau <ysionneau@kalray.eu>
> Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
diff mbox series

Patch

diff --git a/libc/string/kvx/memcpy.S b/libc/string/kvx/memcpy.S
index 290e705b4..70e8db910 100644
--- a/libc/string/kvx/memcpy.S
+++ b/libc/string/kvx/memcpy.S
@@ -53,7 +53,7 @@  ENTRY(memcpy)
 	;;
 	cb.deqz $r7? .Lstreaming_loop_end
 	;;
-	loopdo $r7? .Lstreaming_loop_end
+	loopdo $r7, .Lstreaming_loop_end
 		;;
 		sq 0[$r0] = $r32r33
 		addd $r2 = $r2, -256
@@ -162,7 +162,7 @@  ENTRY(memcpy)
 	;;
 	cb.deqz $r7? .Lloop_32_end
 	;;
-	loopdo $r7? .Lloop_32_end
+	loopdo $r7, .Lloop_32_end
 		;;
 		lo $r32r33r34r35 = 0[$r1]
 		addd $r1 = $r1, 32
diff --git a/libc/sysdeps/linux/kvx/clone.S b/libc/sysdeps/linux/kvx/clone.S
index 71ea80a01..71553a4a9 100644
--- a/libc/sysdeps/linux/kvx/clone.S
+++ b/libc/sysdeps/linux/kvx/clone.S
@@ -59,10 +59,10 @@  ENTRY (__clone)
 	scall SYS_ify(clone)
 	;;
 	/* If 0, then we are the child */
-	cb.deqz $r0, L(child_start)
+	cb.deqz $r0? L(child_start)
 	;;
 	/* Else we are the parent, and we need to check for errors */
-	cb.dltz $r0, L(clone_error)
+	cb.dltz $r0? L(clone_error)
 	;;
 	/* No error ! Yeepa ! */
 	ret