| Message ID | 164975563232.1938924.9962127554425949228@helium.openadk.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [uclibc-ng-devel] Re: Bug in memset on ARM | expand |
>>>>> "tombannink" == tombannink <tombannink@gmail.com> writes: > It looks like I mixed up some tabs/spaces. Here is a patch where the tabs are consistent with the existing code: > From 5e0845fc2dd20a3a7334663f55a1f349f98d4835 Mon Sep 17 00:00:00 2001 > From: Tom Bannink <tombannink@gmail.com> > Date: Tue, 12 Apr 2022 11:15:41 +0200 > Subject: [PATCH] Fix bug in ARM memset implementation Why did you drop the description of the issue from your first mail?
Hi Peter, I'm not sure what you mean, I'm not familiar with this style of sending patches (I'm used to pull-requests on github/gitlab). Should I copy the full contents of my first email (reproducible example, bug explanation, etc) in the commit message and then generate another patch file? Best, Tom
>>>>> "tombannink" == tombannink <tombannink@gmail.com> writes: > Hi Peter, > I'm not sure what you mean, I'm not familiar with this style of sending patches (I'm used to pull-requests on github/gitlab). > Should I copy the full contents of my first email (reproducible > example, bug explanation, etc) in the commit message and then generate > another patch file? Well, your commit just says "Fix bug in ARM memset implementation", which isn't really helpful. Please describe what the issue is, like you did in your initial mail.
diff --git a/libc/string/arm/memset.S b/libc/string/arm/memset.S index 412270f50..f4b30b3dc 100644 --- a/libc/string/arm/memset.S +++ b/libc/string/arm/memset.S @@ -32,6 +32,7 @@ memset: cmp r2, #8 @ at least 8 bytes to do? bcc 2f + uxtb r1, r1 lsl r3, r1, #8 orr r1, r3 lsl r3, r1, #16 @@ -68,6 +69,7 @@ memset: mov a4, a1 cmp a3, $8 @ at least 8 bytes to do? blo 2f + uxtb a2, a2 orr a2, a2, a2, lsl $8 orr a2, a2, a2, lsl $16 1:
It looks like I mixed up some tabs/spaces. Here is a patch where the tabs are consistent with the existing code: From 5e0845fc2dd20a3a7334663f55a1f349f98d4835 Mon Sep 17 00:00:00 2001 From: Tom Bannink <tombannink@gmail.com> Date: Tue, 12 Apr 2022 11:15:41 +0200 Subject: [PATCH] Fix bug in ARM memset implementation --- libc/string/arm/memset.S | 2 ++ 1 file changed, 2 insertions(+)