| Message ID | a10a63f7bd20bc860992b5ccca216b99d3a960b7.1481225852.git.joseph.salisbury@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 12/13/2016 12:51 PM, Joseph Salisbury wrote: > BugLink: http://bugs.launchpad.net/bugs/1630238 > > CONFIG_PINCTRL_CHERRYVIEW=y (must be y, not m) in addition to CONFIG_TOUCHSCREEN_ELAN to get the touchscreen working on CYAN. > The change of Intel related PINCTRLs (specifically the CHERRYVIEW one) to m instead of y causes at least the touchscreen regression. > > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> > --- > debian.master/config/config.common.ubuntu | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu > index 73bf67f..41c481f 100644 > --- a/debian.master/config/config.common.ubuntu > +++ b/debian.master/config/config.common.ubuntu > @@ -5917,7 +5917,7 @@ CONFIG_PINCTRL_BCM2835=y > CONFIG_PINCTRL_BERLIN=y > CONFIG_PINCTRL_BERLIN_BG4CT=y > CONFIG_PINCTRL_BROXTON=m > -CONFIG_PINCTRL_CHERRYVIEW=m > +CONFIG_PINCTRL_CHERRYVIEW=y > CONFIG_PINCTRL_DOVE=y > CONFIG_PINCTRL_EXYNOS=y > CONFIG_PINCTRL_EXYNOS5440=y > @@ -8181,7 +8181,7 @@ CONFIG_TOUCHSCREEN_EDT_FT5X06=m > CONFIG_TOUCHSCREEN_EETI=m > CONFIG_TOUCHSCREEN_EGALAX=m > CONFIG_TOUCHSCREEN_EGALAX_SERIAL=m > -CONFIG_TOUCHSCREEN_ELAN=m > +CONFIG_TOUCHSCREEN_ELAN=y > CONFIG_TOUCHSCREEN_ELO=m > CONFIG_TOUCHSCREEN_FT6236=m > CONFIG_TOUCHSCREEN_FUJITSU=m > Do we really need to build these drivers into all architectures ? And can we get by with only building in PINCTRL_CHERRYVIEW on amd64 whilst leaving CONFIG_TOUCHSCREEN_ELAN=m ? rtg
On 12/13/2016 03:04 PM, Tim Gardner wrote: > On 12/13/2016 12:51 PM, Joseph Salisbury wrote: >> BugLink: http://bugs.launchpad.net/bugs/1630238 >> >> CONFIG_PINCTRL_CHERRYVIEW=y (must be y, not m) in addition to CONFIG_TOUCHSCREEN_ELAN to get the touchscreen working on CYAN. >> The change of Intel related PINCTRLs (specifically the CHERRYVIEW one) to m instead of y causes at least the touchscreen regression. >> >> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> >> --- >> debian.master/config/config.common.ubuntu | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu >> index 73bf67f..41c481f 100644 >> --- a/debian.master/config/config.common.ubuntu >> +++ b/debian.master/config/config.common.ubuntu >> @@ -5917,7 +5917,7 @@ CONFIG_PINCTRL_BCM2835=y >> CONFIG_PINCTRL_BERLIN=y >> CONFIG_PINCTRL_BERLIN_BG4CT=y >> CONFIG_PINCTRL_BROXTON=m >> -CONFIG_PINCTRL_CHERRYVIEW=m >> +CONFIG_PINCTRL_CHERRYVIEW=y >> CONFIG_PINCTRL_DOVE=y >> CONFIG_PINCTRL_EXYNOS=y >> CONFIG_PINCTRL_EXYNOS5440=y >> @@ -8181,7 +8181,7 @@ CONFIG_TOUCHSCREEN_EDT_FT5X06=m >> CONFIG_TOUCHSCREEN_EETI=m >> CONFIG_TOUCHSCREEN_EGALAX=m >> CONFIG_TOUCHSCREEN_EGALAX_SERIAL=m >> -CONFIG_TOUCHSCREEN_ELAN=m >> +CONFIG_TOUCHSCREEN_ELAN=y >> CONFIG_TOUCHSCREEN_ELO=m >> CONFIG_TOUCHSCREEN_FT6236=m >> CONFIG_TOUCHSCREEN_FUJITSU=m >> > Do we really need to build these drivers into all architectures ? And > can we get by with only building in PINCTRL_CHERRYVIEW on amd64 whilst > leaving CONFIG_TOUCHSCREEN_ELAN=m ? > > rtg This bug has only been reported against amd64, so that architecture is the only one that needs it. I'll build a test kernel with CONFIG_TOUCHSCREEN_ELAN set to m instead of y and see if it still resolves the bug. Joe
On 12/13/2016 03:09 PM, Joseph Salisbury wrote: > On 12/13/2016 03:04 PM, Tim Gardner wrote: >> On 12/13/2016 12:51 PM, Joseph Salisbury wrote: >>> BugLink: http://bugs.launchpad.net/bugs/1630238 >>> >>> CONFIG_PINCTRL_CHERRYVIEW=y (must be y, not m) in addition to CONFIG_TOUCHSCREEN_ELAN to get the touchscreen working on CYAN. >>> The change of Intel related PINCTRLs (specifically the CHERRYVIEW one) to m instead of y causes at least the touchscreen regression. >>> >>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> >>> --- >>> debian.master/config/config.common.ubuntu | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu >>> index 73bf67f..41c481f 100644 >>> --- a/debian.master/config/config.common.ubuntu >>> +++ b/debian.master/config/config.common.ubuntu >>> @@ -5917,7 +5917,7 @@ CONFIG_PINCTRL_BCM2835=y >>> CONFIG_PINCTRL_BERLIN=y >>> CONFIG_PINCTRL_BERLIN_BG4CT=y >>> CONFIG_PINCTRL_BROXTON=m >>> -CONFIG_PINCTRL_CHERRYVIEW=m >>> +CONFIG_PINCTRL_CHERRYVIEW=y >>> CONFIG_PINCTRL_DOVE=y >>> CONFIG_PINCTRL_EXYNOS=y >>> CONFIG_PINCTRL_EXYNOS5440=y >>> @@ -8181,7 +8181,7 @@ CONFIG_TOUCHSCREEN_EDT_FT5X06=m >>> CONFIG_TOUCHSCREEN_EETI=m >>> CONFIG_TOUCHSCREEN_EGALAX=m >>> CONFIG_TOUCHSCREEN_EGALAX_SERIAL=m >>> -CONFIG_TOUCHSCREEN_ELAN=m >>> +CONFIG_TOUCHSCREEN_ELAN=y >>> CONFIG_TOUCHSCREEN_ELO=m >>> CONFIG_TOUCHSCREEN_FT6236=m >>> CONFIG_TOUCHSCREEN_FUJITSU=m >>> >> Do we really need to build these drivers into all architectures ? And >> can we get by with only building in PINCTRL_CHERRYVIEW on amd64 whilst >> leaving CONFIG_TOUCHSCREEN_ELAN=m ? >> >> rtg > This bug has only been reported against amd64, so that architecture is > the only one that needs it. I'll build a test kernel with > CONFIG_TOUCHSCREEN_ELAN set to m instead of y and see if it still > resolves the bug. > > > Joe > > I found that the kernel will not build if I do not set CONFIG_TOUCHSCREEN_ELAN to y after setting CONFIG_PINCTRL_CHERRYVIEW to y.
>> > I found that the kernel will not build if I do not set > CONFIG_TOUCHSCREEN_ELAN to y after setting CONFIG_PINCTRL_CHERRYVIEW to y. > Then I suppose enabling it is the only thing we can do.
Applied to xenial and yakkety master-next branches. Thanks. Cascardo.
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu index 73bf67f..41c481f 100644 --- a/debian.master/config/config.common.ubuntu +++ b/debian.master/config/config.common.ubuntu @@ -5917,7 +5917,7 @@ CONFIG_PINCTRL_BCM2835=y CONFIG_PINCTRL_BERLIN=y CONFIG_PINCTRL_BERLIN_BG4CT=y CONFIG_PINCTRL_BROXTON=m -CONFIG_PINCTRL_CHERRYVIEW=m +CONFIG_PINCTRL_CHERRYVIEW=y CONFIG_PINCTRL_DOVE=y CONFIG_PINCTRL_EXYNOS=y CONFIG_PINCTRL_EXYNOS5440=y @@ -8181,7 +8181,7 @@ CONFIG_TOUCHSCREEN_EDT_FT5X06=m CONFIG_TOUCHSCREEN_EETI=m CONFIG_TOUCHSCREEN_EGALAX=m CONFIG_TOUCHSCREEN_EGALAX_SERIAL=m -CONFIG_TOUCHSCREEN_ELAN=m +CONFIG_TOUCHSCREEN_ELAN=y CONFIG_TOUCHSCREEN_ELO=m CONFIG_TOUCHSCREEN_FT6236=m CONFIG_TOUCHSCREEN_FUJITSU=m
BugLink: http://bugs.launchpad.net/bugs/1630238 CONFIG_PINCTRL_CHERRYVIEW=y (must be y, not m) in addition to CONFIG_TOUCHSCREEN_ELAN to get the touchscreen working on CYAN. The change of Intel related PINCTRLs (specifically the CHERRYVIEW one) to m instead of y causes at least the touchscreen regression. Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com> --- debian.master/config/config.common.ubuntu | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)