From patchwork Sat Apr 28 12:49:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 155657 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 92EB1B6FEA for ; Sat, 28 Apr 2012 23:07:31 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SO7Mo-0000CA-Pm; Sat, 28 Apr 2012 13:07:14 +0000 Received: from mail-qc0-f177.google.com ([209.85.216.177]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SO75w-00069A-71 for kernel-team@lists.ubuntu.com; Sat, 28 Apr 2012 12:49:48 +0000 Received: by qcsu28 with SMTP id u28so1035962qcs.8 for ; Sat, 28 Apr 2012 05:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ZQDmkmBMNu/xkj6xvhgftjCch0UqLZx4cX5AgnyhQuQ=; b=j10G4o9QFnUxAMV8irWV3EMQIhjgCptFo4i77C1ed/PeqkVZxDEdWOJrUyqYhJgV7q l0LJmBoqRuCTUf/uPur00/ymLxFloGPGaNXmSCrtTvjmuyyL02WS/J788TctZT0DsHII 9ZDhWrwSC03PS1mqSkQ9JSunuqywMjT/v15ebvJ1I44af3r3eukEp8lBKb9n1L63e2so A6KIwR+GCS5rRSFCEouR9p315Y54t+IFt9jwvCIIp5x6LQzNRmkDvJdI/GCnzCGnHw4g OGJsdo1EGreLFIscD2w3822ThhMY7knsX+cX+wZE80D5SrQrsGCqtt+mzJwbBE8QBeQ1 WlMQ== MIME-Version: 1.0 Received: by 10.229.106.25 with SMTP id v25mr3675165qco.54.1335617387458; Sat, 28 Apr 2012 05:49:47 -0700 (PDT) Received: by 10.229.109.138 with HTTP; Sat, 28 Apr 2012 05:49:47 -0700 (PDT) In-Reply-To: References: Date: Sat, 28 Apr 2012 14:49:47 +0200 Message-ID: Subject: Re: [overlayfs] Fixes against ubuntu-quantal.git#master-next From: Sedat Dilek To: kernel-team@lists.ubuntu.com, Leann Ogasawara , Andy Whitcroft , Miklos Szeredi X-Mailman-Approved-At: Sat, 28 Apr 2012 13:07:11 +0000 Cc: linux-fsdevel , Al Viro X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list Reply-To: sedat.dilek@gmail.com List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On Sat, Apr 28, 2012 at 1:59 PM, Sedat Dilek wrote: > Hi, > > I wanted to play with OverlayFS against Linux-3.4-rc4. > > As Ubuntu kernel-team has rebased it in ubuntu-quantal.git#master-next. > I made my life easy and took this repo as base for my fixes (or trying to fix). > > [2] says: > UBUNTU: [Config] Temporarily disable overlayfs > Fails to build after rebase to v3.4-rc1 > > So, I tried to fix that myself. > OK, ovl compiles here, but when I try to follow the testcase in [1], I > get call-traces in mnt_want_write(). > Not sure if I borked more than I fixed it up. > > Any comments welcome! > Thanks. > > Kind regards, > - Sedat - > > [1] http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-quantal.git;a=shortlog;h=refs/heads/master-next > [2] http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-quantal.git;a=commit;h=17be56b59c8535ab835befa9555078687305bc76 > [3] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/944386 Grrr..., followup to d_make_root() fix. $ git diff fs/overlayfs/super.c - Sedat - diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 36e254d..6137475 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -626,8 +626,6 @@ out_put_lowerpath: path_put(&lowerpath); out_put_upperpath: path_put(&upperpath); -out_put_root: - iput(root_inode); out_free_oe: kfree(oe); out_free_config: