From patchwork Wed Sep 21 14:26:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 115790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 7321CB6F8B for ; Thu, 22 Sep 2011 00:26:53 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1R6Nl1-0007vo-IP; Wed, 21 Sep 2011 14:26:39 +0000 Received: from mail.tpi.com ([70.99.223.143]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1R6Nkz-0007vd-3Y for kernel-team@lists.ubuntu.com; Wed, 21 Sep 2011 14:26:37 +0000 Received: from [10.0.2.5] (host-174-44-187-184.hln-mt.client.bresnan.net [174.44.187.184]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail.tpi.com (Postfix) with ESMTP id D30CA2E6961 for ; Wed, 21 Sep 2011 07:26:29 -0700 (PDT) Message-ID: <4E79F41A.5000806@canonical.com> Date: Wed, 21 Sep 2011 08:26:34 -0600 From: Tim Gardner User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Thunderbird/3.1.13 MIME-Version: 1.0 To: Ubuntu Kernel Team Subject: Re: Lucid SRU: UBUNTU: SAUCE: igb: Protect stats update References: <4E79E9EB.2060302@canonical.com> In-Reply-To: <4E79E9EB.2060302@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On 09/21/2011 07:43 AM, Tim Gardner wrote: > This patch is a partial backport of upstream > 12dcd86b75d571772512676ab301279952efc0b0. Its purpose is twofold; 1) > Protect simultaneous readers and writers, 2) refresh statistics when > read from ethtool. > > rtg > It was pointed out to me on IRC that this change requires an additional patch. rtg From fccdf41f8b3748e3808a2e52fe35f78fd75cfcc9 Mon Sep 17 00:00:00 2001 From: Len Brown Date: Fri, 15 Jul 2011 17:37:15 -0400 Subject: [PATCH] x86, intel, power: Correct the MSR_IA32_ENERGY_PERF_BIAS message BugLink: http://bugs.launchpad.net/bugs/829566 Fix the printk_once() so that it actually prints (didn't print before due to a stray comma.) [ hpa: changed to an incremental patch and adjusted the description accordingly. ] Signed-off-by: Len Brown Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1107151732480.18606@x980 Cc: Signed-off-by: H. Peter Anvin (cherry picked from commit 17edf2d79f1ea6dfdb4c444801d928953b9f98d6) Signed-off-by: Tim Gardner --- arch/x86/kernel/cpu/intel.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index 7c1ca07..24cba78 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -457,11 +457,11 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c) u64 epb; rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); - if ((epb & 0xF) == 0) { - printk_once(KERN_WARNING, "x86: updated energy_perf_bias" - " to 'normal' from 'performance'\n" - "You can view and update epb via utility," - " such as x86_energy_perf_policy(8)\n"); + if ((epb & 0xF) == ENERGY_PERF_BIAS_PERFORMANCE) { + printk_once(KERN_WARNING "ENERGY_PERF_BIAS:" + " Set to 'normal', was 'performance'\n" + "ENERGY_PERF_BIAS: View and update with" + " x86_energy_perf_policy(8)\n"); epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL; wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); } -- 1.7.0.4