From patchwork Wed Oct 14 20:35:08 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Frey X-Patchwork-Id: 36026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 4EBB6B70B3 for ; Thu, 15 Oct 2009 07:35:26 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MyAZ2-0002E8-2F; Wed, 14 Oct 2009 21:35:16 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MyAYw-0002Dd-CZ for kernel-team@lists.ubuntu.com; Wed, 14 Oct 2009 21:35:10 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1MyAYw-0000Se-8f; Wed, 14 Oct 2009 21:35:10 +0100 Received: from [91.189.91.3] (helo=[10.0.1.124]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MyAYw-0003q0-0i; Wed, 14 Oct 2009 21:35:10 +0100 Message-ID: <4AD635FC.6050802@canonical.com> Date: Wed, 14 Oct 2009 16:35:08 -0400 From: Michael Frey User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Andy Whitcroft Subject: Re: [PATCH] [JAUNTY NETBOOK] Fix for Distorted recorded audio on ALC662 References: <4AD5E892.4010707@canonical.com> <20091014190400.GJ21346@shadowen.org> In-Reply-To: <20091014190400.GJ21346@shadowen.org> X-Enigmail-Version: 0.95.7 Cc: Ubuntu Kernel Team X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.8 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Andy Whitcroft wrote: > On Wed, Oct 14, 2009 at 11:04:50AM -0400, Michael Frey wrote: > >> Attached patch fixes bug: https://bugs.edge.launchpad.net/athens/+bug/409289 >> >> Please apply to Jaunty Netbook branch. >> >> Patch was created by pshou@realtek.com from Realtek. >> >> Thanks, >> Michael >> >> > > Be good to have a description of what this patch fixes, and your signoff > while you are at it. > > >> diff -Nru alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c >> --- alsa-driver-1.0.20/alsa-kernel/pci/hda/patch_realtek.c 2009-05-06 15:06:04.000000000 +0800 >> +++ alsa-driver-1.0.20-new/alsa-kernel/pci/hda/patch_realtek.c 2009-08-21 14:35:19.000000000 +0800 >> > > This doens't look like a patch against the jaunty netbook tree. Has it > been tested? > > >> @@ -15745,6 +15745,7 @@ >> }; >> >> static struct hda_verb alc663_m51va_init_verbs[] = { >> + {0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, >> @@ -16409,6 +16410,8 @@ >> >> static struct snd_pci_quirk alc662_cfg_tbl[] = { >> SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS), >> + SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13), >> + SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13), >> SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL), >> SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1), >> SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1), >> > > I think the patch is in here twice, else something mad is happening > here? > > >> diff -Nru alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c >> --- alsa-driver-1.0.20/sound/pci/hda/patch_realtek.c 2009-05-06 15:06:04.000000000 +0800 >> +++ alsa-driver-1.0.20-new/sound/pci/hda/patch_realtek.c 2009-08-21 14:35:19.000000000 +0800 >> @@ -15745,6 +15745,7 @@ >> }; >> >> static struct hda_verb alc663_m51va_init_verbs[] = { >> + {0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, >> {0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, >> @@ -16409,6 +16410,8 @@ >> >> static struct snd_pci_quirk alc662_cfg_tbl[] = { >> SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS), >> + SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13), >> + SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13), >> SND_PCI_QUIRK(0x1028, 0x02d6, "DELL", ALC272_DELL), >> SND_PCI_QUIRK(0x1028, 0x02f4, "DELL ZM1", ALC272_DELL_ZM1), >> SND_PCI_QUIRK(0x1043, 0x1000, "ASUS N50Vm", ALC663_ASUS_MODE1), >> > > >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team >> > > Sent the wrong patch. Please find the proper attached patch against the jaunty netbook branch. This patch sets the verb table to set up the Mic on the 2 Acer units. The patch was prepared by Realtek (pshou@realtek.com) Signed-off-by: Michael Frey Thanks, Michael diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a4422e5..6b8edff 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -15217,6 +15217,7 @@ static struct hda_verb alc663_auto_init_verbs[] = { }; static struct hda_verb alc663_m51va_init_verbs[] = { + {0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, {0x16, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN}, {0x21, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, @@ -15904,6 +15905,8 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = { ALC662_3ST_6ch_DIG), SND_PCI_QUIRK(0x17aa, 0x101e, "Lenovo", ALC662_LENOVO_101E), SND_PCI_QUIRK(0x1019, 0x9087, "ECS", ALC662_ECS), + SND_PCI_QUIRK(0x1025, 0x022c, "Acer JM11_ML", ALC663_ASUS_H13), + SND_PCI_QUIRK(0x1025, 0x0244, "Acer JM11_ML", ALC663_ASUS_H13), SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS), SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L", ALC662_3ST_6ch_DIG),