| Message ID | 20240909150709.118761-3-aleksandr.mikhalitsyn@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | UBUNTU: SAUCE: fan: fixes | expand |
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index d19c1900e52b..9c9ad01e6027 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -2916,7 +2916,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev) netdev_dbg(vxlan->dev, "vxlan_xmit p %x d %pM\n", eth->h_proto, eth->h_dest); if (vxlan_fan_build_rdst(vxlan, skb, &fan_rdst)) { - dev->stats.tx_dropped++; + dev_core_stats_tx_dropped_inc(dev); kfree_skb(skb); return NETDEV_TX_OK; }
BugLink: https://bugs.launchpad.net/bugs/2064176 Let's use a proper API to increase netdevice's tx_dropped statistics. Since upstream commit 6dee402daba4eb ("vxlan: Fix racy device stats updates.") we have to use dev_core_stats_tx_dropped_inc() function for that. This one was found while I was debugging an original issues from LP bug #2064176 and was reviewing a whole Ubuntu FAN implementation. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> --- drivers/net/vxlan/vxlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)