diff mbox series

[SRU,J] drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc

Message ID 20240822042652.4072048-3-cengiz.can@canonical.com
State New
Headers show
Series [SRU,J] drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc | expand

Commit Message

Cengiz Can Aug. 22, 2024, 4:26 a.m. UTC 
From: Jesse Zhang <jesse.zhang@amd.com>

Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
V2: To really improve the handling we would actually
   need to have a separate value of 0xffffffff.(Christian)

Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(backported from commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944)
[cengizcan: commit f10984a353c8 ("drm/amd/amdgpu: Fix errors & warnings
in amdgpu _uvd, _vce.c") is missing from tree so adjust context]
CVE-2024-42228
Signed-off-by: Cengiz Can <cengiz.can@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
index 8e8dee9fac9f..9f7450a8d004 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
@@ -733,7 +733,8 @@  int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p, uint32_t ib_idx)
 	uint32_t created = 0;
 	uint32_t allocated = 0;
 	uint32_t tmp, handle = 0;
-	uint32_t *size = &tmp;
+	uint32_t dummy = 0xffffffff;
+	uint32_t *size = &dummy;
 	unsigned idx;
 	int i, r = 0;