| Message ID | 20240805152341.105004-2-portia.stephens@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | Update IMX547 out-of-tree driver code | expand |
On Mon, Aug 05, 2024 at 11:23:41AM -0400, Portia Stephens wrote: > BugLink: https://bugs.launchpad.net/bugs/2076108 > > Updated the out-of-tree xilinx-mv-camera-sensor-module driver. > > (cherry-picked from git@github.com:Xilinx/mv-camera-sensor-module.git v0.3) Did you omit the original commit subject and body from a58acc5 imx547 : Used devm_* resource management functions instead of gpiod_* on purpose? The information from that commit message is available on launchpad but I feel like it might be useful to also have access to it directly via git history.
On Mon, Aug 5, 2024 at 11:51 AM Manuel Diewald <manuel.diewald@canonical.com> wrote: > > On Mon, Aug 05, 2024 at 11:23:41AM -0400, Portia Stephens wrote: > > BugLink: https://bugs.launchpad.net/bugs/2076108 > > > > Updated the out-of-tree xilinx-mv-camera-sensor-module driver. > > > > (cherry-picked from git@github.com:Xilinx/mv-camera-sensor-module.git v0.3) > > Did you omit the original commit subject and body from > > a58acc5 imx547 : Used devm_* resource management functions instead of gpiod_* > > on purpose? The information from that commit message is available on > launchpad but I feel like it might be useful to also have access to it > directly via git history. eh sort of. In the past for these out-of-tree drivers we have not done a 1 for 1 commit but instead just updated up to a tag in one commit. In this case though it is a single commit, I agree it makes sense to use the original commit message. I'll send a v2. > > -- > Manuel
On Mon, Aug 05, 2024 at 11:58:19AM -0400, Portia Stephens wrote: > On Mon, Aug 5, 2024 at 11:51 AM Manuel Diewald > <manuel.diewald@canonical.com> wrote: > > > > On Mon, Aug 05, 2024 at 11:23:41AM -0400, Portia Stephens wrote: > > > BugLink: https://bugs.launchpad.net/bugs/2076108 > > > > > > Updated the out-of-tree xilinx-mv-camera-sensor-module driver. > > > > > > (cherry-picked from git@github.com:Xilinx/mv-camera-sensor-module.git v0.3) > > > > Did you omit the original commit subject and body from > > > > a58acc5 imx547 : Used devm_* resource management functions instead of gpiod_* > > > > on purpose? The information from that commit message is available on > > launchpad but I feel like it might be useful to also have access to it > > directly via git history. > > eh sort of. In the past for these out-of-tree drivers we have not done > a 1 for 1 commit but instead just updated up to a tag in one commit. > In this case though it is a single commit, I agree it makes sense to > use the original commit message. I'll send a v2. > > > > > > -- > > Manuel > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Expecting a v2 submission.
diff --git a/ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c b/ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c index fc4f4a44b5cd..094dfc6d7e86 100644 --- a/ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c +++ b/ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c @@ -1037,7 +1037,7 @@ static int imx547_probe(struct i2c_client *client) } /* initialize gt trx reset gpio */ - imx547->gt_trx_reset_gpio = gpiod_get_index_optional(&client->dev, "reset", + imx547->gt_trx_reset_gpio = devm_gpiod_get_index_optional(&client->dev, "reset", 0, GPIOD_OUT_HIGH); if (IS_ERR(imx547->gt_trx_reset_gpio)) { if (PTR_ERR(imx547->gt_trx_reset_gpio) != -EPROBE_DEFER) @@ -1047,7 +1047,7 @@ static int imx547_probe(struct i2c_client *client) } /* initialize pipe reset gpio */ - imx547->pipe_reset_gpio = gpiod_get_index_optional(&client->dev, "reset", + imx547->pipe_reset_gpio = devm_gpiod_get_index_optional(&client->dev, "reset", 1, GPIOD_OUT_HIGH); if (IS_ERR(imx547->pipe_reset_gpio)) { if (PTR_ERR(imx547->pipe_reset_gpio) != -EPROBE_DEFER)
BugLink: https://bugs.launchpad.net/bugs/2076108 Updated the out-of-tree xilinx-mv-camera-sensor-module driver. (cherry-picked from git@github.com:Xilinx/mv-camera-sensor-module.git v0.3) Signed-off-by: Portia Stephens <portia.stephens@canonical.com> --- ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)