diff mbox series

[F] gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

Message ID 20240712011855.2233154-2-yuxuan.luo@canonical.com
State New
Headers show
Series [F] gfs2: Fix slab-use-after-free in gfs2_qd_dealloc | expand

Commit Message

Yuxuan Luo July 12, 2024, 1:18 a.m. UTC 
From: Juntong Deng <juntong.deng@outlook.com>

In gfs2_put_super(), whether withdrawn or not, the quota should
be cleaned up by gfs2_quota_cleanup().

Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu
callback) has run for all gfs2_quota_data objects, resulting in
use-after-free.

Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called
by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling
gfs2_make_fs_ro(), there is no need to call them again.

Reported-by: syzbot+29c47e9e51895928698c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
(backported from commit bdcb8aa434c6d36b5c215d02a9ef07551be25a37)
[yuxuan.luo: TODO]
CVE-2023-52760
Signed-off-by: Yuxuan Luo <yuxuan.luo@canonical.com>
---
 fs/gfs2/super.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 15e757f763806..09bb630185952 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -662,6 +662,8 @@  static void gfs2_put_super(struct super_block *sb)
 		error = gfs2_make_fs_ro(sdp);
 		if (error)
 			gfs2_io_error(sdp);
+	} else {
+		gfs2_quota_cleanup(sdp);
 	}
 	/*  At this point, we're through modifying the disk  */