From patchwork Mon Oct 9 22:29:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 1845521 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S4DJ942Wqz1yq7 for ; Tue, 10 Oct 2023 09:30:31 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qpylL-0007OU-QB; Mon, 09 Oct 2023 22:30:07 +0000 Received: from mail-mw2nam04on2077.outbound.protection.outlook.com ([40.107.101.77] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qpylA-0007N2-LT for kernel-team@lists.ubuntu.com; Mon, 09 Oct 2023 22:29:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHD7JbA4p+IkzCQvQL3jvtIWzbhJ7+/DHk+3dq8cRlQVwb26SpX2WMW5xvj64y9h/Zjyn7Nb3AVRLiPPKU+xGr1A0eZW+8cTu/cHzMTkQszDJv1ghawDeVa1eESvYNZjOa17KEuBUgnw3Dhah66HcrHRJXua2LqRvVsWjOfsMCEyC9rxDrVU/lQToc8e5DPJEL+bmPGTvgEpyzhzCggLBYMsYoYRl/U/xiqgy7o2fKSfwwbMxVDDROTWgOUrwMSJLc500xZkhrBcPHY8d1V2y/pwz/LkZnd9v18W8amtQ493QhDTI4h/ICOFYULqjI/Zs86E7Nwo5Uzao+54qpd2/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OmQd7Jkx3vCHRLrjWTNuAXTZAkj2Z1Mzz4RBw6iOiU=; b=OHrezM3c3UCk/FH7QwfPGqgp9sqHIITABRkw1eWbcCAUbX1u/ygm5EllPdwzJihsAKp2+p8Bp2T/Whzips+tn7fv2FAdz8W6EY4c9GNC2Dnn0CWytJ7/BnaIPE9G3ynETbb3q957gD6wHLmHadKDmmzbQMyL4lXDQ3DBztYmbQ3IgCzGtjWRpouR6M0OoNR8G1HLmdm4i6RduAbXOliIgMpDOCLhmz+Kj4pnBysWDJveV3rXimrQRCLiuQlUJ/I1Pv77cgpLawV81QwKMl0zRt+WSbZJhCyAtLGoeTaMUVUio6pi/UrS8sjUnde3poO/PQFEa2Xq6ZVWSBTAnYBRPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none Received: from SJ0PR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:334::14) by BL3PR12MB6523.namprd12.prod.outlook.com (2603:10b6:208:3bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36; Mon, 9 Oct 2023 22:29:53 +0000 Received: from CO1PEPF000044F0.namprd05.prod.outlook.com (2603:10b6:a03:334:cafe::96) by SJ0PR05CA0099.outlook.office365.com (2603:10b6:a03:334::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.20 via Frontend Transport; Mon, 9 Oct 2023 22:29:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F0.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Mon, 9 Oct 2023 22:29:52 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 9 Oct 2023 15:29:35 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 9 Oct 2023 15:29:35 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Mon, 9 Oct 2023 15:29:35 -0700 From: Asmaa Mnebhi To: Subject: [SRU][J:linux-bluefield][PATCH v1 1/1] UBUNTU: SAUCE: gpio-mlxbf3: support valid mask Date: Mon, 9 Oct 2023 18:29:30 -0400 Message-ID: <20231009222930.10020-2-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20231009222930.10020-1-asmaa@nvidia.com> References: <20231009222930.10020-1-asmaa@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F0:EE_|BL3PR12MB6523:EE_ X-MS-Office365-Filtering-Correlation-Id: 11f34c8c-98c2-49d0-7ebf-08dbc917417c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KwQ8TT4soU9udGX3ObiFpofWloKQs4ayISHRlj474Q0HCaE71F7jc/rg93aq15OeSRHtTlAo5zkBvSKUNzirwtUFzU9cVJcT/iobKKGSUW2OWDTdMs2zIQw4SC/kLSwIWLwT+EyesufKHEbDjwW9qgTrE8Rz29NPYxZatFZsv1HN9GoY4ILQYwXcXghzZVSQbXjq41qi+Xqkzq8zfzZZLjHeWhonzCDQ9z+kFiwBvi6dYRcu/5cYGqIZErB+QRwmlcbZFm2NO3NyNkEz5Am87Iwi0/Va98VlY3cbl5UJNJL2ltIsqZRdPBkShxDJ9zZ2JqMOp1xKMaIQV3mZne678dRoVR3qTcQ5bHfM/zyTq65L6PMnDXD58DS8PB/bubyoVesWL4hrKZGBIeyUDes/Ko68qEkNFDu6W0zyaOg5T29xlqbHHgVO7r77zF3bvgW/Dsq2lUZm6lFnjKyRu5dBEYy0vlMLhzqHhUxlcj+GQWXWHc+0bIVP89Bx00JLb/jNcQd465t7nr1Opd2tQeR7SwhcQIMjy4cNxP2j7492Hu7i1SghUbWWcnRdrbF8x/i/NnoemzL6KeemGGwcnrfqRynAq02kt23AxuGeLQA/gs5seU1uJCXjCNohLqaXqgwGcV5uMnwj5+y/3QfI50BuYBgTbt+tV3oqXG/hawHnUQC8Roat6CP+YAkIOCxDjW3hoVHme0iLW7WbpChXRFPmm0hVwAxItiC40FDpxKdT8Z5moibmRaZZxLlAjNp7f/elxG4uALcDc6isx0HyBUFIlA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(346002)(376002)(136003)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(82310400011)(36840700001)(46966006)(40470700004)(356005)(86362001)(7636003)(36756003)(40480700001)(2906002)(82740400003)(478600001)(41300700001)(7696005)(5660300002)(4326008)(966005)(336012)(2616005)(83380400001)(1076003)(426003)(107886003)(6666004)(40460700003)(8936002)(316002)(6916009)(70586007)(8676002)(70206006)(36860700001)(47076005)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 22:29:52.2228 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11f34c8c-98c2-49d0-7ebf-08dbc917417c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6523 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: asmaa@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2038868 After syncing up the gpio-mlxbf3.c driver with the upstreamed version, we dropped the use of the valid_mask variable because kernels greater or equal to 6.2.0 don't need it. This is no longer needed in kernel versions >= 6.2.0 because valid_mask is populated by core gpio code. 5.15 kernel, doesn't support that feature so we still need to explicitly define valid_mask as we did before. This doesnt impact the functionality of the GPIO driver but it is a security breach as it doesnt restrict the access to gpios defined in the acpi table by valid_mask. Signed-off-by: Asmaa Mnebhi --- drivers/gpio/gpio-mlxbf3.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpio/gpio-mlxbf3.c b/drivers/gpio/gpio-mlxbf3.c index e63b0e7e90bd..e1375756c487 100644 --- a/drivers/gpio/gpio-mlxbf3.c +++ b/drivers/gpio/gpio-mlxbf3.c @@ -49,6 +49,9 @@ struct mlxbf3_gpio_context { /* YU GPIO cause block address */ void __iomem *gpio_cause_io; + + /* Mask of valid gpios that can be accessed by software */ + unsigned int valid_mask; }; static void mlxbf3_gpio_irq_enable(struct irq_data *irqd) @@ -150,6 +153,17 @@ static void mlxbf3_gpio_irq_ack(struct irq_data *data) { } +static int mlxbf3_gpio_init_valid_mask(struct gpio_chip *gc, + unsigned long *valid_mask, + unsigned int ngpios) +{ + struct mlxbf3_gpio_context *gs = gpiochip_get_data(gc); + + *valid_mask = gs->valid_mask; + + return 0; +} + static struct irq_chip gpio_mlxbf3_irqchip = { .name = "MLNXBF33", .irq_ack = mlxbf3_gpio_irq_ack, @@ -205,6 +219,10 @@ static int mlxbf3_gpio_probe(struct platform_device *pdev) gs->gpio_clr_io = devm_platform_ioremap_resource(pdev, 3); if (IS_ERR(gs->gpio_clr_io)) return PTR_ERR(gs->gpio_clr_io); + + gs->valid_mask = 0x0; + device_property_read_u32(dev, "valid_mask", &gs->valid_mask); + gc = &gs->gc; ret = bgpio_init(gc, dev, 4, @@ -218,6 +236,7 @@ static int mlxbf3_gpio_probe(struct platform_device *pdev) gc->free = gpiochip_generic_free; gc->owner = THIS_MODULE; gc->add_pin_ranges = mlxbf3_gpio_add_pin_ranges; + gc->init_valid_mask = mlxbf3_gpio_init_valid_mask; irq = platform_get_irq(pdev, 0); if (irq >= 0) {