From patchwork Tue Aug 8 14:00:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 1818621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=tAnWCb9v; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RKvwv55hCz20G0 for ; Wed, 9 Aug 2023 00:01:03 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qTNGa-0002tv-H6; Tue, 08 Aug 2023 14:00:56 +0000 Received: from mail-dm3nam02on2051.outbound.protection.outlook.com ([40.107.95.51] helo=NAM02-DM3-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qTNGY-0002tD-RD for kernel-team@lists.ubuntu.com; Tue, 08 Aug 2023 14:00:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYBYqK06xx7RirnTD/2/AyCkBjuyWVI3IrGXlD/QZpxOKmymyudUSSiD10HsFs1OQrSwFvIuKPUvnyqfseUvrf08aKs9t9CoSHI5/02w45DDRdKYa6bGSSLV4z/cqn+YRvMV5YJo/2F7dq2llxSUu/6o/PUyzuitWBvnf63ZgCLo8Glt2BigGb5cuB44XqWwoqBRPQRvWa4UojTQwQXSDpqlc5Y56/9VsnDzGIqxQ1QU8pKxGBc0lpO06Vpyo4pN0QfVOza0DUXPyqCVKHC1jKuDGdHHDDAQTZ+nGEMvYBsuCqxp+IiDx7pHhMqlL5VQqYkIBMVfnDenPZnAkkjsNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=scv4cUVv37OFh+MPQefxCEHjzHBZFZx/eNmiZ5G8jsc=; b=QngOTe0FuZcp5dAR048RfnrESlBvgGbFj3ZD92qSO3aDkr6V6hxXo/vSbRUjy96ypGpWNIOxEmBgP/zVD2FtF+VMfedn/eswUy2iqTf3sKVMcHMfUtaIwAO6NpxHwFBIXQwATyiNP49PmnpcQBWGnqsX+iXE0IAOITNZWkfCnyYTpspGqPgWl8MVOzrYwFYDJOq8/dcjskVD1lrEIJxz4zrqoe+1yPkb0s7rPpycPaKlighJBVFnorx7CHz5XlkQu8vWKnxiCkeBLd6mBu/NlnkOBP9Q5wuKOIlfrtdEa+fTFWC5HFt8117QGj8VH4mKgk9AGBOtnqL9JHmuT31oFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=scv4cUVv37OFh+MPQefxCEHjzHBZFZx/eNmiZ5G8jsc=; b=tAnWCb9vEHi4CTxDRFzgvPegvwo7+mB8LFl8rutKI4fz1zFWyWgQ1oV3B7z6EMaKqys5Lp2PAqKcefO7Y3X5K0xf5WGpm9QNC9nohrzZ4HVxjpV3CTkIPlAQOvIzVV9sh/xzamYaYNeYdvxdceuhjR4AZLSCdM6L/aVJus7AZy2FZmLWul6VX7sA/fUzyN5URV1etwfa3rOQHT80ojzRjCxaR0UmFTucr6Yl2AMf1B5QkHzhbzFhd9dUSWsI7dJT82RJCal255WAMpwt8+MmwKN9RZpm6zWlxLf3FuvuXDZi0QxJQh2ztXTDC8OiLR3eJjTLqTSGCZb8jnFkEWSTAw== Received: from CY5P221CA0053.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:4::23) by BY5PR12MB4147.namprd12.prod.outlook.com (2603:10b6:a03:205::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 14:00:51 +0000 Received: from CY4PEPF0000EDD2.namprd03.prod.outlook.com (2603:10b6:930:4:cafe::c4) by CY5P221CA0053.outlook.office365.com (2603:10b6:930:4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 14:00:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EDD2.mail.protection.outlook.com (10.167.241.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Tue, 8 Aug 2023 14:00:51 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 8 Aug 2023 07:00:33 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 8 Aug 2023 07:00:32 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 8 Aug 2023 07:00:32 -0700 From: Asmaa Mnebhi To: Subject: [SRU][F/J:linux-bluefield][PATCH v1 2/2] UBUNTU: SAUCE: mlxbf-gige: Fix kernel panic after reboot Date: Tue, 8 Aug 2023 10:00:25 -0400 Message-ID: <20230808140025.12302-3-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20230808140025.12302-1-asmaa@nvidia.com> References: <20230808140025.12302-1-asmaa@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD2:EE_|BY5PR12MB4147:EE_ X-MS-Office365-Filtering-Correlation-Id: 24e4770d-1b3e-4c2e-7417-08db9817e00e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jpRIE0wauWPvu05zL8GUPbWYhvqSNR1XFwzHi19ckoOVwvglYL5SmFvc6hgDMhkNmidCvPz2K6YDTiiFtOJhPrQsbhIZHawxPwxw94t0NYElzb5PUDXHIUa1/x9qjD7BXN7R/Z54/uF2HzePzt5HRXTvIkRTdwHIWiz+jP0/bJ1XBgvTy2NrHLqx2yQvsO3mnwxgdgHCrNTAWeUBmlY5QqhXwZZfQqY6E7BB4t4QIqrd5gWQZyrp1BYkFrfBbl1+0EvetDj2rlsUEB5fqn3Q+Y3CASVhyvj4oMB1eYjzSjGduEmWLWg6zwhVQvwtNc8FqN4oC8OwEThB56iFSKgpHgd/2JSooQRcn/I8VDC6hlKw2Y7UVY1iWyXBKRY0kih58xR3n33EI+McjAQJGSAZXo8cS65qEFsfPHSxaiR4eW9sP7xSnjYPLjfnrKWqEmjDDhm7havt4I3s77o0aYMNqbINng2/2mwISAcgXqshevpjXRAG0NIpXIssrDXOO8DegDwZaibOdH/KmSkiUgYW+bjPyw66U0/r6i1O0WQ7F6ocmkFb6vbWcgvL+iogfcu4wbS59tdLShqPeB/1AADa7G30lW2R7Cb91luXguRCkpH5kM2LwH7aLG9AR4THaM5lMaQF4hnpjVikaqFsngJExJ7fr4sGxQijK8lk7vTZ+tYQ6n1pgbyXWT8d0JktRSMihOX9a1uSDqvTxNNLAPN/8fslTpO6dVD3r31gfYWefZTQGrxnNFkBMGRYZP7OGbCYwMp+nKGk9+lyG3x5D9+stK8gA7L6P2lrv9aGGTsRlKM= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199021)(82310400008)(186006)(1800799003)(46966006)(36840700001)(40470700004)(40480700001)(336012)(2616005)(40460700003)(36756003)(4326008)(966005)(316002)(6916009)(7636003)(54906003)(70206006)(356005)(82740400003)(6666004)(86362001)(70586007)(478600001)(7696005)(26005)(1076003)(107886003)(8936002)(426003)(41300700001)(47076005)(8676002)(36860700001)(2906002)(83380400001)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:00:51.2364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24e4770d-1b3e-4c2e-7417-08db9817e00e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4147 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vlad@nvidia.com, asmaa@nvidia.com, rsasson@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2030765 We occasionally see a race condition (once every 350 reboots) where napi is still running (mlxbf_gige_poll) while a shutdown has been initiated through "reboot". Since mlxbf_gige_poll is still running, it tries to access a NULL pointer and as a result causes a kernel panic. Add a check for when "priv" is NULL. Signed-off-by: Asmaa Mnebhi --- drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c index f21dafde490b..75466f713ade 100644 --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c @@ -298,6 +298,9 @@ int mlxbf_gige_poll(struct napi_struct *napi, int budget) priv = container_of(napi, struct mlxbf_gige, napi); + if (!priv) + return 0; + mlxbf_gige_handle_tx_complete(priv); data = readq(priv->base + MLXBF_GIGE_RX_DMA);