| Message ID | 20230420111555.530093-1-juerg.haefliger@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Unstable/Lunar] UBUNTU: [Packaging] Remove update-version-dkms | expand |
On 23/04/20 01:15PM, Juerg Haefliger wrote: > It's a legacy script that doesn't do anthing since 2021 so finally > remove it. > > Fixes: 5cc78bf956c7 ("UBUNTU: [Packaging] switch to kernel-versions") > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > --- > update-version-dkms | 4 ---- > 1 file changed, 4 deletions(-) > delete mode 100755 update-version-dkms > > diff --git a/update-version-dkms b/update-version-dkms > deleted file mode 100755 > index a266fecc06f8..000000000000 > --- a/update-version-dkms > +++ /dev/null > @@ -1,4 +0,0 @@ > -#!/bin/bash > - > -echo "EE: run update-dkms-versions after link-to-tracker" 1>&2 > -exit 1 > -- > 2.37.2 This looks good to me but I'm thinking, shouldn't this be a cranky thing as opposed to having a in tree script? Also, if we end up dropping it, we will need to also update the cranky docs to avoid confusion where the script is not found[1]. [1] https://canonical-kteam-docs.readthedocs-hosted.com/en/latest/docs/kteam_tools/cranking-the-kernel.html#dkms-package-update-stage-update-dkms-versions Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On Fri, Apr 21, 2023 at 12:15:45PM +0100, Andrei Gherzan wrote: > On 23/04/20 01:15PM, Juerg Haefliger wrote: > > It's a legacy script that doesn't do anthing since 2021 so finally > > remove it. > > > > Fixes: 5cc78bf956c7 ("UBUNTU: [Packaging] switch to kernel-versions") > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > > --- > > update-version-dkms | 4 ---- > > 1 file changed, 4 deletions(-) > > delete mode 100755 update-version-dkms > > > > diff --git a/update-version-dkms b/update-version-dkms > > deleted file mode 100755 > > index a266fecc06f8..000000000000 > > --- a/update-version-dkms > > +++ /dev/null > > @@ -1,4 +0,0 @@ > > -#!/bin/bash > > - > > -echo "EE: run update-dkms-versions after link-to-tracker" 1>&2 > > -exit 1 > > -- > > 2.37.2 > > This looks good to me but I'm thinking, shouldn't this be a cranky thing > as opposed to having a in tree script? Also, if we end up dropping it, > we will need to also update the cranky docs to avoid confusion where the > script is not found[1]. > > [1] https://canonical-kteam-docs.readthedocs-hosted.com/en/latest/docs/kteam_tools/cranking-the-kernel.html#dkms-package-update-stage-update-dkms-versions The doc looks correct (unless it was updated after this email), because it mentions update-dkms-versions. The one that we're dropping is update-version-dkms, that used the be the old equivalent, now deprecated. Anywa, applied to lunar/linux. Thanks, -Andrea
On 23/04/24 04:09PM, Andrea Righi wrote: > On Fri, Apr 21, 2023 at 12:15:45PM +0100, Andrei Gherzan wrote: > > On 23/04/20 01:15PM, Juerg Haefliger wrote: > > > It's a legacy script that doesn't do anthing since 2021 so finally > > > remove it. > > > > > > Fixes: 5cc78bf956c7 ("UBUNTU: [Packaging] switch to kernel-versions") > > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > > > --- > > > update-version-dkms | 4 ---- > > > 1 file changed, 4 deletions(-) > > > delete mode 100755 update-version-dkms > > > > > > diff --git a/update-version-dkms b/update-version-dkms > > > deleted file mode 100755 > > > index a266fecc06f8..000000000000 > > > --- a/update-version-dkms > > > +++ /dev/null > > > @@ -1,4 +0,0 @@ > > > -#!/bin/bash > > > - > > > -echo "EE: run update-dkms-versions after link-to-tracker" 1>&2 > > > -exit 1 > > > -- > > > 2.37.2 > > > > This looks good to me but I'm thinking, shouldn't this be a cranky thing > > as opposed to having a in tree script? Also, if we end up dropping it, > > we will need to also update the cranky docs to avoid confusion where the > > script is not found[1]. > > > > [1] https://canonical-kteam-docs.readthedocs-hosted.com/en/latest/docs/kteam_tools/cranking-the-kernel.html#dkms-package-update-stage-update-dkms-versions > > The doc looks correct (unless it was updated after this email), because > it mentions update-dkms-versions. The one that we're dropping is > update-version-dkms, that used the be the old equivalent, now > deprecated. Ugh. I misread it initially. I got it now. > > Anywa, applied to lunar/linux. > > Thanks, > -Andrea
diff --git a/update-version-dkms b/update-version-dkms deleted file mode 100755 index a266fecc06f8..000000000000 --- a/update-version-dkms +++ /dev/null @@ -1,4 +0,0 @@ -#!/bin/bash - -echo "EE: run update-dkms-versions after link-to-tracker" 1>&2 -exit 1
It's a legacy script that doesn't do anthing since 2021 so finally remove it. Fixes: 5cc78bf956c7 ("UBUNTU: [Packaging] switch to kernel-versions") Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> --- update-version-dkms | 4 ---- 1 file changed, 4 deletions(-) delete mode 100755 update-version-dkms