From patchwork Tue Mar 28 08:32:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1762206 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=EDBEq4lp; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pm2yF6RnFz1yYV for ; Tue, 28 Mar 2023 19:33:25 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ph4lZ-00009t-8w; Tue, 28 Mar 2023 08:33:17 +0000 Received: from mail-pg1-f175.google.com ([209.85.215.175]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ph4lR-0008Gd-Dk for kernel-team@lists.ubuntu.com; Tue, 28 Mar 2023 08:33:09 +0000 Received: by mail-pg1-f175.google.com with SMTP id bn14so6714646pgb.11 for ; Tue, 28 Mar 2023 01:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679992383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=YsVh19ezJzG6kIPsFAmZ4EGRiTJj8gDkzvp99Iqb8c4=; b=EDBEq4lpF9q33zK3KUGEzNunkGQezZcYCWVMhY4Flt89dxFwzCopQJuXFH2QMqSW99 AcmZKQHwpbdigi7PHHEy5+1Rv+7jJyzIc0A20QjRI1v+IKKbhO9FhGdhjUxnZOzoxWpF jBcgynFdCry4pYa9JCb92fsygYfRCw5Pk7gHdE7EO/NauzcXM8vu9gMDeEnVwyg45vL3 N91mVG9Yqn703kHgaG8M47ey0z0mE8x4eAAHayAdXgd85opfUQXDDq9JaOpxyt8kAYPD 8cFa0BIf2llgx+h6byxqxulOnhf4ct1uvDzDzNLUVQTwxNjkba6Do4SzKlPq/K3+VKCz fZrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679992383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YsVh19ezJzG6kIPsFAmZ4EGRiTJj8gDkzvp99Iqb8c4=; b=z/3oQg563H2iLsAiiKne7XMkuPPniNIv0vUQWtZWxAn4lFNlXrEsy/ql5r1oEPjsm8 cw1+IuRAY+rZPOIcYNsk8dNJJM5x0iLjoVE5R+DQI5AhBYJXtq55GUu2AzFjA3ZPVqdq dkgt6cKh1Mna9drOfKhaNLG6ceR+piD/sL55waDyobGoc0PUJrcz3b98QbjxZ2k/ry+4 SfYDC8Y1wb2CRyVJfsDH3tkWKNJP6kmh7463DfjMsAobbLoSwvWs8YrgJLxMyS8RP6um y1klKauNPWuOYrRlSnK1SeAm7B6cEcSucSw8xdPIPLOvV9n7Ks5uMsA+L76392YBYfEe xZTg== X-Gm-Message-State: AAQBX9dWtXL6DZYAA6X44cb68KiScuv4Y3kmXbqb+SJpltgRteIV60rO zSf9b9YYT+lan0LU2RGB9scV37vUsx0AFw== X-Google-Smtp-Source: AKy350YSB0R47eRGZCO0u+Y731khIUwrXU+RhZL768ARUnJ39b3i6fz3n4OvWEK8lr7QfcAa9LvU1Q== X-Received: by 2002:aa7:9afa:0:b0:626:e177:fc64 with SMTP id y26-20020aa79afa000000b00626e177fc64mr13309231pfp.19.1679992382916; Tue, 28 Mar 2023 01:33:02 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id y22-20020aa78056000000b0062d859a33d1sm3192352pfm.84.2023.03.28.01.33.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 01:33:02 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 7/9][SRU][L] drm/i915: Print the PPS registers using consistent format Date: Tue, 28 Mar 2023 16:32:44 +0800 Message-Id: <20230328083246.366669-8-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230328083246.366669-1-acelan.kao@canonical.com> References: <20230328083246.366669-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.175; envelope-from=acelan@gmail.com; helo=mail-pg1-f175.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Ville Syrjälä BugLink: https://launchpad.net/bugs/2001599 Use the consistent format when dumping out the PPS control/status registers. Helps with pattern matching. Cc: Animesh Manna Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20221125173156.31689-8-ville.syrjala@linux.intel.com Reviewed-by: Animesh Manna (cherry picked from commit 1e47e035bb733476128a5281bdd29ac27c91c603) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/gpu/drm/i915/display/intel_pps.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c index d18c1c58dfcf..f6bc896338de 100644 --- a/drivers/gpu/drm/i915/display/intel_pps.c +++ b/drivers/gpu/drm/i915/display/intel_pps.c @@ -527,7 +527,8 @@ void intel_pps_check_power_unlocked(struct intel_dp *intel_dp) if (!edp_have_panel_power(intel_dp) && !edp_have_panel_vdd(intel_dp)) { drm_WARN(&dev_priv->drm, 1, "eDP powered off while attempting aux channel communication.\n"); - drm_dbg_kms(&dev_priv->drm, "Status 0x%08x Control 0x%08x\n", + drm_dbg_kms(&dev_priv->drm, + "PP_STATUS: 0x%08x PP_CONTROL: 0x%08x\n", intel_de_read(dev_priv, _pp_stat_reg(intel_dp)), intel_de_read(dev_priv, _pp_ctrl_reg(intel_dp))); } @@ -559,7 +560,7 @@ static void wait_panel_status(struct intel_dp *intel_dp, pp_ctrl_reg = _pp_ctrl_reg(intel_dp); drm_dbg_kms(&dev_priv->drm, - "mask %08x value %08x status %08x control %08x\n", + "mask: 0x%08x value: 0x%08x PP_STATUS: 0x%08x PP_CONTROL: 0x%08x\n", mask, value, intel_de_read(dev_priv, pp_stat_reg), intel_de_read(dev_priv, pp_ctrl_reg)); @@ -567,7 +568,7 @@ static void wait_panel_status(struct intel_dp *intel_dp, if (intel_de_wait_for_register(dev_priv, pp_stat_reg, mask, value, 5000)) drm_err(&dev_priv->drm, - "Panel status timeout: status %08x control %08x\n", + "Panel status timeout: PP_STATUS: 0x%08x PP_CONTROL: 0x%08x\n", intel_de_read(dev_priv, pp_stat_reg), intel_de_read(dev_priv, pp_ctrl_reg));