diff mbox series

[SRU,Jammy,2/3] (upstream) NFS: Judge the file access cache's timestamp in rcu path

Message ID 20230118145721.36032-3-chengen.du@canonical.com
State New
Headers show
Series NFS: client permission error after adding user to permissible group | expand

Commit Message

Chengen Du Jan. 18, 2023, 2:57 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2003053

If the user's login time is newer than the cache's timestamp,
we expect the cache may be stale and need to clear.
The stale cache will remain in the list's tail if no other
users operate on that inode.
Once the user accesses the inode, the stale cache will be
returned in rcu path.

Signed-off-by: Chengen Du <chengen.du@canonical.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
(cherry picked from commit 029085b8949f5d269ae2bbd14915407dd0c7f902)
Signed-off-by: Chengen Du <chengen.du@canonical.com>
---
 fs/nfs/dir.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 131a65a870c1..6ade945620d2 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2765,6 +2765,7 @@  static int nfs_access_get_cached_rcu(struct inode *inode, const struct cred *cre
 	 * but do it without locking.
 	 */
 	struct nfs_inode *nfsi = NFS_I(inode);
+	u64 login_time = nfs_access_login_time(current, cred);
 	struct nfs_access_entry *cache;
 	int err = -ECHILD;
 	struct list_head *lh;
@@ -2779,6 +2780,8 @@  static int nfs_access_get_cached_rcu(struct inode *inode, const struct cred *cre
 		cache = NULL;
 	if (cache == NULL)
 		goto out;
+	if ((s64)(login_time - cache->timestamp) > 0)
+		goto out;
 	if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS))
 		goto out;
 	*mask = cache->mask;