diff mbox series

[Unstable/Lunar,2/5] UBUNTU: [Packaging] debian/rules: Mark PHONY targets individually

Message ID 20230113094537.265143-3-juerg.haefliger@canonical.com
State New
Headers show
Series Clean up rules.d/1-maintainer.mk | expand

Commit Message

Juerg Haefliger Jan. 13, 2023, 9:45 a.m. UTC
Mark all PHONY targets individually in rules.d/1-maintainer.mk rather
than listing them on a single line. This makes it easier to spot missing
PHONY markers and also matches the other rules files.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 debian/rules.d/1-maintainer.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/debian/rules.d/1-maintainer.mk b/debian/rules.d/1-maintainer.mk
index 8373b81ed2cb..712c152376f6 100644
--- a/debian/rules.d/1-maintainer.mk
+++ b/debian/rules.d/1-maintainer.mk
@@ -1,8 +1,7 @@ 
 # The following targets are for the maintainer only! do not run if you don't
 # know what they do.
 
-.PHONY: printenv updateconfigs defaultconfigs genconfigs migrateconfigs printchanges insertchanges startnewrelease help autoreconstruct finalchecks
-
+.PHONY: help
 help:
 	@echo "These are the targets in addition to the normal $(DEBIAN) ones:"
 	@echo
@@ -38,6 +37,7 @@  help:
 printdebian:
 	@echo "$(DEBIAN)"
 
+.PHONY: migrateconfigs
 migrateconfigs:
 	dh_testdir;
 	if [ -e "$(DEBIAN)/config/config.common.ubuntu" ]; then \
@@ -65,6 +65,7 @@  $(configs-targets):
 	fi;
 	rm -rf build
 
+.PHONY: printenv
 printenv:
 	dh_testdir
 	@echo "src package name  = $(src_pkg_name)"
@@ -117,6 +118,7 @@  printenv:
 	@echo "arch                      = $(arch)"
 	@echo "kmake                     = $(kmake)"
 
+.PHONY: printchanges
 printchanges:
 	@baseCommit=$$(git log --pretty=format:'%H %s' | \
 		gawk '/UBUNTU: '".*Ubuntu-.*`echo $(prev_fullver) | sed 's/+/\\\\+/'`"'(~.*)?$$/ { print $$1; exit }'); \
@@ -128,9 +130,11 @@  printchanges:
 	git log "$$baseCommit"..HEAD | \
 	$(DROOT)/scripts/misc/git-ubuntu-log
 
+.PHONY: insertchanges
 insertchanges: autoreconstruct finalchecks
 	$(DROOT)/scripts/misc/insert-changes $(DROOT) $(DEBIAN)
 
+.PHONY: autoreconstruct
 autoreconstruct:
 	# No need for reconstruct for -rc kernels since we don't upload an
 	# orig tarball, so just remove it.
@@ -140,12 +144,14 @@  autoreconstruct:
 		$(DROOT)/scripts/misc/gen-auto-reconstruct $(upstream_tag) $(DEBIAN)/reconstruct $(DROOT)/source/options; \
 	fi
 
+.PHONY: finalchecks
 finalchecks: debian/control
 ifeq ($(do_fips_checks),true)
 	$(DROOT)/scripts/misc/fips-checks
 endif
 	$(DROOT)/scripts/misc/final-checks "$(DEBIAN)" "$(prev_fullver)"
 
+.PHONY: startnewrelease
 startnewrelease:
 	dh_testdir
 	@[ -f "$(DEBIAN)/etc/update.conf" ] && . "$(DEBIAN)/etc/update.conf"; \