diff mbox series

[v2,1/1,SRU,Unstable/Kinetic/OEM-6.0] UBUNTU: SAUCE: t7xx: skip suspend to AP-CLDMA

Message ID 20221102083850.550342-2-vicamo.yang@canonical.com
State New
Headers show
Series Fix suspend failure on t7xx equipped platform | expand

Commit Message

You-Sheng Yang Nov. 2, 2022, 8:38 a.m. UTC 
From: "Sethuraman, Muralidharan" <muralidharan.sethuraman@intel.com>

BugLink: https://bugs.launchpad.net/bugs/1990700

The t7xx contains two Cross Layer DMA (CLDMA) interfaces to
communicate with AP and Modem processors respectively. So far only
MD-CLDMA was being used, and the other AP-CLDMA is to be enabled in
following fixes.

This patch skips suspend command to AP-CLDMA that actually fails.

Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com>
---
 drivers/net/wwan/t7xx/t7xx_pci.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

You-Sheng Yang Nov. 10, 2022, 8:32 a.m. UTC | #1 
Nack as an update coming.

On Wed, Nov 2, 2022 at 4:39 PM You-Sheng Yang <vicamo.yang@canonical.com> wrote:
>
> From: "Sethuraman, Muralidharan" <muralidharan.sethuraman@intel.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1990700
>
> The t7xx contains two Cross Layer DMA (CLDMA) interfaces to
> communicate with AP and Modem processors respectively. So far only
> MD-CLDMA was being used, and the other AP-CLDMA is to be enabled in
> following fixes.
>
> This patch skips suspend command to AP-CLDMA that actually fails.
>
> Signed-off-by: You-Sheng Yang (vicamo) <vicamo.yang@canonical.com>
> ---
>  drivers/net/wwan/t7xx/t7xx_pci.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/wwan/t7xx/t7xx_pci.c b/drivers/net/wwan/t7xx/t7xx_pci.c
> index 871f2a27a398..1b5bc5f57a76 100644
> --- a/drivers/net/wwan/t7xx/t7xx_pci.c
> +++ b/drivers/net/wwan/t7xx/t7xx_pci.c
> @@ -308,13 +308,6 @@ static int __t7xx_pci_pm_suspend(struct pci_dev *pdev)
>                 goto abort_suspend;
>         }
>
> -       ret = t7xx_send_pm_request(t7xx_dev, H2D_CH_SUSPEND_REQ_AP);
> -       if (ret) {
> -               t7xx_send_pm_request(t7xx_dev, H2D_CH_RESUME_REQ);
> -               dev_err(&pdev->dev, "[PM] SAP suspend error: %d\n", ret);
> -               goto abort_suspend;
> -       }
> -
>         list_for_each_entry(entity, &t7xx_dev->md_pm_entities, entity) {
>                 if (entity->suspend_late)
>                         entity->suspend_late(t7xx_dev, entity->entity_param);
> --
> 2.37.2
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/drivers/net/wwan/t7xx/t7xx_pci.c b/drivers/net/wwan/t7xx/t7xx_pci.c
index 871f2a27a398..1b5bc5f57a76 100644
--- a/drivers/net/wwan/t7xx/t7xx_pci.c
+++ b/drivers/net/wwan/t7xx/t7xx_pci.c
@@ -308,13 +308,6 @@  static int __t7xx_pci_pm_suspend(struct pci_dev *pdev)
 		goto abort_suspend;
 	}
 
-	ret = t7xx_send_pm_request(t7xx_dev, H2D_CH_SUSPEND_REQ_AP);
-	if (ret) {
-		t7xx_send_pm_request(t7xx_dev, H2D_CH_RESUME_REQ);
-		dev_err(&pdev->dev, "[PM] SAP suspend error: %d\n", ret);
-		goto abort_suspend;
-	}
-
 	list_for_each_entry(entity, &t7xx_dev->md_pm_entities, entity) {
 		if (entity->suspend_late)
 			entity->suspend_late(t7xx_dev, entity->entity_param);