From patchwork Wed Oct 26 04:12:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1694752 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MxwRC6YSgz23lJ for ; Wed, 26 Oct 2022 15:13:42 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1onXnH-0006C0-3N; Wed, 26 Oct 2022 04:13:31 +0000 Received: from mail-pj1-f49.google.com ([209.85.216.49]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1onXnD-0006BT-U6 for kernel-team@lists.ubuntu.com; Wed, 26 Oct 2022 04:13:28 +0000 Received: by mail-pj1-f49.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so1254847pjc.3 for ; Tue, 25 Oct 2022 21:13:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tDUvDN2pfNedladzJ5ZvmGVSMKRy1uffesa07aqTKLM=; b=Xs5YlWlAHoDGFOZ8oguJU6SiMu4WakC+nf09OlmchcPnYdybzVNerTsTi2HXP9x2JC mIG87JMGudgP4aFDlrqeLh6uE53H9jEY+DGempP/U98TlhO5U8m8t4i+rugsJ7B4wB6u rT8uKBP2YkeNPLXBk5sWJjQBN/Tu2H7Qx/ZLEfFfOF2QpsB86kiaUwwI/SD+l8m4glhw 4nnOX8i70aZX4sdK4inXrPWu+sS7JlB/GQ+h9cbkQUwxrLthTMFP0hk62DEIeprzcdeh tWqHJobRWy/KyDnKwxs/mBMCyImtHA/3KLk1rPlv6JU2r1vi2WGBKxN4aSG/WnaTmlnu WjFA== X-Gm-Message-State: ACrzQf2b5Ztn4kPck0EGdQf97TJ2PALq0uaDC7d1FFmZoTL1RfUk5C3d Xi4FPJWP/9svLix75r4RT8K5VmCSRqhHCA== X-Google-Smtp-Source: AMsMyM4e4mqPZaaaMLKaleHI/8mKVq/PULUrvZL6CuajaZTe0Oj/E+oc2WuMOHh0nxx6JaSyPInDRg== X-Received: by 2002:a17:902:6aca:b0:186:8431:d7e4 with SMTP id i10-20020a1709026aca00b001868431d7e4mr23880291plt.89.1666757605938; Tue, 25 Oct 2022 21:13:25 -0700 (PDT) Received: from localhost.localdomain (61-227-102-1.dynamic-ip.hinet.net. [61.227.102.1]) by smtp.gmail.com with ESMTPSA id t17-20020a17090340d100b001869e17baf4sm1923215pld.127.2022.10.25.21.13.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 21:13:25 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2][SRU][OEM-6.0] HID: amd_sfh: Change dev_err to dev_dbg for additional debug info Date: Wed, 26 Oct 2022 12:12:41 +0800 Message-Id: <20221026041242.657921-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221026041242.657921-1-vicamo.yang@canonical.com> References: <20221026041242.657921-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.49; envelope-from=vicamo@gmail.com; helo=mail-pj1-f49.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Basavaraj Natikar BugLink: https://bugs.launchpad.net/bugs/1993240 Users should only be notified at most one time on systems doesn't have any sensors connected or non-supported systems. Check the return code and don't display error messages in those conditions. Signed-off-by: Basavaraj Natikar Signed-off-by: Jiri Kosina (cherry picked from commit beb18bb22cd4fb88648bb2925d56f36131c1ac21) Signed-off-by: You-Sheng Yang (vicamo) --- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c index 70436f9fad2f..d840efb4a2e2 100644 --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c @@ -286,13 +286,13 @@ int amd_sfh1_1_init(struct amd_mp2_dev *mp2) phy_base <<= 21; if (!devm_request_mem_region(dev, phy_base, 128 * 1024, "amd_sfh")) { - dev_err(dev, "can't reserve mmio registers\n"); + dev_dbg(dev, "can't reserve mmio registers\n"); return -ENOMEM; } mp2->vsbase = devm_ioremap(dev, phy_base, 128 * 1024); if (!mp2->vsbase) { - dev_err(dev, "failed to remap vsbase\n"); + dev_dbg(dev, "failed to remap vsbase\n"); return -ENOMEM; } @@ -301,7 +301,7 @@ int amd_sfh1_1_init(struct amd_mp2_dev *mp2) memcpy_fromio(&binfo, mp2->vsbase, sizeof(struct sfh_base_info)); if (binfo.sbase.fw_info.fw_ver == 0 || binfo.sbase.s_list.sl.sensors == 0) { - dev_err(dev, "failed to get sensors\n"); + dev_dbg(dev, "failed to get sensors\n"); return -EOPNOTSUPP; } dev_dbg(dev, "firmware version 0x%x\n", binfo.sbase.fw_info.fw_ver);