From patchwork Mon Aug 29 13:51:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 1671476 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=oonmePuB; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MGX1R45RJz1ygc for ; Mon, 29 Aug 2022 23:52:11 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oSfBK-0000fz-Qf; Mon, 29 Aug 2022 13:52:02 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oSfBE-0000Yj-Jn for kernel-team@lists.ubuntu.com; Mon, 29 Aug 2022 13:51:56 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 2AA623F460 for ; Mon, 29 Aug 2022 13:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1661781116; bh=L0c17o89cGcsBmkd2WA7m7i38hq24AYmNGwr0DF01lo=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oonmePuBJrUdCIRrL+1GSJuzvVhBgOgw3uB1HSGVgNvAtlNt8/YsxVjOKLNYdqHfC 9CeprsOig/LB4rF+UV+FVzXjW7sy1W13eIQpkW8sTtOGCvTLOVUVEFpBI7uwp3S77c nOoAWYw4y4zep+DCaJRSsgjzhEQ89LMW0TUpNFX5QaH3TL0BbUeAOFFzF7IjV834xP zrtFaLaeX3cixz3aV8oule23oDitYmbnEO+vkPpsZ3KFt/vGJFY66yWLTzbVyVHbgR i6PW2nOOVL4IpR0NtYVzglNWfZJwp8uPqUHnBXg2C/CSh08cvgBxIcaphdJg4DiTHt HFaF3DWcWXHVg== Received: by mail-ed1-f71.google.com with SMTP id h6-20020aa7de06000000b004483647900fso3364352edv.21 for ; Mon, 29 Aug 2022 06:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=L0c17o89cGcsBmkd2WA7m7i38hq24AYmNGwr0DF01lo=; b=Tb7LY/++Gy7Zn9L6gIBNY9PRgwPhlkKIYJ+B3Mi489zlf6SspfcpYL4tFGD1VouGQG gW4GmZwi14yWhvnMyE/lFSLAuOCoJ+6T3PVya6UMCSdGJQiTbG4iZISKl0Aw5UxmoS0y YmC4hMcCIEAbs+UunCfkuq4wdRW2ga9Svvb+i33GVzGLtL+fzkTtHxA/QDGakq90BaZp w4k8gUTzoFxMXkA2g8cdtRtjH5cKc9nlKEIS2lAchFVSG9dbJB5jR/qCfsCRCyBJQ5zi uExtyWGM1lK3QhHd6Ym4z0B58b67JSFfoGDgPip8pR2t64zGG3YhgLEX2Jdl1TZctPxM MxNA== X-Gm-Message-State: ACgBeo2GubV4jHwX4+8rlDjxpuuxEJ3zsPSTVmW/71MnDfAjbc4jVdN0 nLjAfSiQ8ezsZLQM9oVTSstCrKg9tmbMrdXzv9Kx2FJBGmR7INkRUcZvYMw1R80+iWFW1A4L6wa BM2xb5QDTQByjYENJyeiUjBLkJmInxBq2nlJJ2lBC9w== X-Received: by 2002:a17:907:2bce:b0:73d:dd00:9ced with SMTP id gv14-20020a1709072bce00b0073ddd009cedmr11303935ejc.739.1661781113668; Mon, 29 Aug 2022 06:51:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR6sefvMpCfNGEb8d/mkyrWsdD9+uQuoclyqjIirKfbRLhVPfdCngY+9OWk+4l/JdTPW+trU0w== X-Received: by 2002:a17:907:2bce:b0:73d:dd00:9ced with SMTP id gv14-20020a1709072bce00b0073ddd009cedmr11303920ejc.739.1661781113397; Mon, 29 Aug 2022 06:51:53 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id g6-20020a170906198600b0073dc6def190sm4470416ejd.158.2022.08.29.06.51.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 06:51:53 -0700 (PDT) From: Emil Renner Berthing To: kernel-team@lists.ubuntu.com Subject: [SRU][K][PATCH 3/4] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove() Date: Mon, 29 Aug 2022 15:51:47 +0200 Message-Id: <20220829135148.1491968-5-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220829135148.1491968-1-emil.renner.berthing@canonical.com> References: <20220829135148.1491968-1-emil.renner.berthing@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Yang Yingliang BugLink: https://bugs.launchpad.net/bugs/1986970 clock source is prepared and enabled by clk_prepare_enable() in probe function, but no disable or unprepare in remove. Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller") Reported-by: Hulk Robot Reviewed-by: Conor Dooley Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220628140527.1404439-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman (cherry picked from commit 98ceba7559280cdd09feccc7af4406d93187fbfb) Signed-off-by: Emil Renner Berthing --- drivers/usb/musb/mpfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c index a69ca338eace..cea2e8108867 100644 --- a/drivers/usb/musb/mpfs.c +++ b/drivers/usb/musb/mpfs.c @@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev) { struct mpfs_glue *glue = platform_get_drvdata(pdev); + clk_disable_unprepare(glue->clk); platform_device_unregister(glue->musb); usb_phy_generic_unregister(pdev);