diff mbox

[SRU,J] UBUNTU: [Config] Enable CONFIG_GPIO_CDEV_V1

Message ID 20220720104025.1580222-3-emil.renner.berthing@canonical.com
State New
Headers show

Commit Message

Emil Renner Berthing July 20, 2022, 10:40 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1953613

Enable v1 of the character device interface for manipulating GPIOs from
userspace. The libgpiod2 library and gpiod tools in Jammy are still
using this interface.

Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
---
 debian.master/config/annotations          | 4 +++-
 debian.master/config/config.common.ubuntu | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Stefan Bader Aug. 5, 2022, 1:27 p.m. UTC | #1
On 20.07.22 12:40, Emil Renner Berthing wrote:
> BugLink: https://bugs.launchpad.net/bugs/1953613
> 
> Enable v1 of the character device interface for manipulating GPIOs from
> userspace. The libgpiod2 library and gpiod tools in Jammy are still
> using this interface.
> 
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---

Applied to jammy:linux/master-next and adjusted the annotation note format to 
produce a link. Thanks.

-Stefan

>   debian.master/config/annotations          | 4 +++-
>   debian.master/config/config.common.ubuntu | 2 +-
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 1d35cb971e3f..8386a2d0508f 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -1846,7 +1846,9 @@ CONFIG_GPIOLIB_FASTPATH_LIMIT                   policy<{'amd64': '512', 'arm64':
>   CONFIG_DEBUG_GPIO                               policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'ppc64el': 'n', 's390x': 'n'}>
>   CONFIG_GPIO_SYSFS                               policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
>   CONFIG_GPIO_CDEV                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -CONFIG_GPIO_CDEV_V1                             policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'ppc64el': 'n', 's390x': 'n'}>
> +CONFIG_GPIO_CDEV_V1                             policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> +
> +CONFIG_GPIO_CDEV_V1                             note<LP:1953613>
>   
>   # Menu: Device Drivers >> GPIO Support >> I2C GPIO expanders
>   CONFIG_GPIO_ADP5588                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 's390x': 'n'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index b2daa1157b7c..f48372e5d030 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3960,7 +3960,7 @@ CONFIG_GPIO_BRCMSTB=m
>   CONFIG_GPIO_BT8XX=m
>   CONFIG_GPIO_CADENCE=m
>   CONFIG_GPIO_CDEV=y
> -# CONFIG_GPIO_CDEV_V1 is not set
> +CONFIG_GPIO_CDEV_V1=y
>   CONFIG_GPIO_CRYSTAL_COVE=y
>   CONFIG_GPIO_DA9052=m
>   CONFIG_GPIO_DA9055=m
diff mbox

Patch

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 1d35cb971e3f..8386a2d0508f 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -1846,7 +1846,9 @@  CONFIG_GPIOLIB_FASTPATH_LIMIT                   policy<{'amd64': '512', 'arm64':
 CONFIG_DEBUG_GPIO                               policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'ppc64el': 'n', 's390x': 'n'}>
 CONFIG_GPIO_SYSFS                               policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
 CONFIG_GPIO_CDEV                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
-CONFIG_GPIO_CDEV_V1                             policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'ppc64el': 'n', 's390x': 'n'}>
+CONFIG_GPIO_CDEV_V1                             policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 's390x': 'y'}>
+
+CONFIG_GPIO_CDEV_V1                             note<LP:1953613>
 
 # Menu: Device Drivers >> GPIO Support >> I2C GPIO expanders
 CONFIG_GPIO_ADP5588                             policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 's390x': 'n'}>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index b2daa1157b7c..f48372e5d030 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3960,7 +3960,7 @@  CONFIG_GPIO_BRCMSTB=m
 CONFIG_GPIO_BT8XX=m
 CONFIG_GPIO_CADENCE=m
 CONFIG_GPIO_CDEV=y
-# CONFIG_GPIO_CDEV_V1 is not set
+CONFIG_GPIO_CDEV_V1=y
 CONFIG_GPIO_CRYSTAL_COVE=y
 CONFIG_GPIO_DA9052=m
 CONFIG_GPIO_DA9055=m