From patchwork Mon May 9 09:12:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juerg Haefliger X-Patchwork-Id: 1628406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=iKgfBesI; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kxb686Sz9z9sGJ for ; Mon, 9 May 2022 19:12:16 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1nnzR5-0000R4-Et; Mon, 09 May 2022 09:12:11 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1nnzR3-0000Qx-RT for kernel-team@lists.ubuntu.com; Mon, 09 May 2022 09:12:09 +0000 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 9A0983F1CA for ; Mon, 9 May 2022 09:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1652087528; bh=8SGbiMt1k2QGAr0RuXiOarQ9bzHt5FixYvo3L1UIkto=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=iKgfBesIiKVT2wZS8DdAoLkQaPqrcnWwTp07kaE5fYtjyy6BRgWJZCyNdiYzV9IKf cwx/V/Pm4Rn6Hf6JI7TNGP9tM0m3FH7BAUBfFSAwmgQl/JgIysrODbF+Ko+B6QOquI 22c+7AOacaZgWH8+HNXk3T5pWrcEYUy/l38wZEoEbITvTHBNGzGz4lGWFb1oajsnc0 x39y6PLppc7a1JXxWKJg/+SBGK2YbaC/Jp4SJlegxIHZl13JqJcnO2xihlKeJNUUUC W3k3LWG2gSIFJ3w3YxMwuM0z0dgi4JeDUbzFNcGyF7rxtOigFBMFKgPkx5lILN5mrx 5WJ/cRVgOb1sQ== Received: by mail-ej1-f71.google.com with SMTP id sh14-20020a1709076e8e00b006f4a5de6888so6397542ejc.8 for ; Mon, 09 May 2022 02:12:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8SGbiMt1k2QGAr0RuXiOarQ9bzHt5FixYvo3L1UIkto=; b=ifPaNSLnnlKr/pEElIB92j/bKFJz7aObiXztWPhWwQf+3n9g2NNtcnx9Ssk2C9K+A3 c7CdURxKeYaA5yHLB8ojepsqim/IkPf5nYzQx2ZeNL8rgP59AEMRfSeVVcTpUuzJczgU CrZxI6UXzfRuu1S3UmFSmpZ11+yiIMd10UAUiYeQNm8HaNYQQUJKaylU5yiOAuFbt6tm bpfUAyBBcx/Qa1ZO4CsXpsHNWMxK4YWyUPphzCHnODXEu2RKi4m9gdaIsVKaB+LHErG2 BTPo7SlA0N7xF5AQG1HVhqLj9EXUR4uTzQ8uJIuruZmcR7y6/13x/1LV1KSgYtbEOzue DGOQ== X-Gm-Message-State: AOAM533KXlcGp4VUW5+jpRi1xIGuoheehy5bnbNh3myrm19zukvQqAIx 2amcYIdgmXjAuvvgvK/IZsDAfxrj1au3I1pIPOIrP6vVXT6rakAyVfHF7/GoBApGTEvSERcji/+ H1ThnnsbuAaSVaf5I5RnoAOwdSuZivlWbc/p5V+tvWw== X-Received: by 2002:a17:906:a10e:b0:6f3:e70b:b572 with SMTP id t14-20020a170906a10e00b006f3e70bb572mr13185098ejy.546.1652087527603; Mon, 09 May 2022 02:12:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc4lgraWOWHbDNWzEajDQzjJMWE7oKi/bm4K9OwznolLygzuJJqM5nD0s4PKqWtpgIGFa29A== X-Received: by 2002:a17:906:a10e:b0:6f3:e70b:b572 with SMTP id t14-20020a170906a10e00b006f3e70bb572mr13185080ejy.546.1652087527371; Mon, 09 May 2022 02:12:07 -0700 (PDT) Received: from gollum.fritz.box ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id cn18-20020a0564020cb200b0042617ba639esm5923893edb.40.2022.05.09.02.12.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 02:12:06 -0700 (PDT) From: Juerg Haefliger X-Google-Original-From: Juerg Haefliger To: kernel-team@lists.ubuntu.com Subject: [Unstable][PATCH] UBUNTU: [Packaging] kernelconfig: Bubble up warnings and errors Date: Mon, 9 May 2022 11:12:06 +0200 Message-Id: <20220509091206.95819-1-juergh@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" Config annotation check failures and warnings due to incomplete config operations are really bad, so exit the script with a non-zero status if such errors or warnings are detected. Ignore: yes Signed-off-by: Juerg Haefliger Acked-by: Tim Gardner Acked-by: Andrea Righi --- debian/scripts/misc/kernelconfig | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/debian/scripts/misc/kernelconfig b/debian/scripts/misc/kernelconfig index f95396e28f28..31b4259a1fcb 100755 --- a/debian/scripts/misc/kernelconfig +++ b/debian/scripts/misc/kernelconfig @@ -192,7 +192,9 @@ for arch in $archs; do done done +rc=0 if [ "$fail" != 0 ]; then + rc=1 echo "" echo "*** ERROR: $fail config-check failures detected" echo "" @@ -201,7 +203,10 @@ fi rm -rf build if [ "$warning_partial" ]; then + rc=1 echo "" echo "WARNING: configuration operation applied only to a subset of architectures (skipped$warning_partial)" 1>&2 echo "" fi + +exit "${rc}"