Message ID | 20220503191027.3631545-1-cascardo@canonical.com |
---|---|
State | New |
Headers | show |
Series | [SRU,Bionic/Focal] vsock: remove ratelimit unknown ioctl message | expand |
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> On Tue, May 3, 2022 at 12:12 PM Thadeu Lima de Souza Cascardo < cascardo@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1971480 > > When exercising the kernel with stress-ng with some ioctl tests the > "Unknown ioctl" error message is spamming the kernel log at a high > rate. Remove this message. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > (cherry picked from commit 6bc8f20c1d9348bdf9ce387228c1b16ce4a301ad) > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > net/vmw_vsock/af_vsock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index d60d7caacbf5..bc972ecb01ee 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -1890,7 +1890,6 @@ static long vsock_dev_do_ioctl(struct file *filp, > break; > > default: > - pr_err("Unknown ioctl %d\n", cmd); > retval = -EINVAL; > } > > -- > 2.32.0 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 5/3/22 13:10, Thadeu Lima de Souza Cascardo wrote: > From: Colin Ian King <colin.king@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1971480 > > When exercising the kernel with stress-ng with some ioctl tests the > "Unknown ioctl" error message is spamming the kernel log at a high > rate. Remove this message. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > (cherry picked from commit 6bc8f20c1d9348bdf9ce387228c1b16ce4a301ad) > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > net/vmw_vsock/af_vsock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index d60d7caacbf5..bc972ecb01ee 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -1890,7 +1890,6 @@ static long vsock_dev_do_ioctl(struct file *filp, > break; > > default: > - pr_err("Unknown ioctl %d\n", cmd); > retval = -EINVAL; > } >
On 03.05.22 21:10, Thadeu Lima de Souza Cascardo wrote: > From: Colin Ian King <colin.king@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1971480 > > When exercising the kernel with stress-ng with some ioctl tests the > "Unknown ioctl" error message is spamming the kernel log at a high > rate. Remove this message. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > (cherry picked from commit 6bc8f20c1d9348bdf9ce387228c1b16ce4a301ad) > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- Applied to focal:linux/master-next. Thanks. -Stefan > net/vmw_vsock/af_vsock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index d60d7caacbf5..bc972ecb01ee 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -1890,7 +1890,6 @@ static long vsock_dev_do_ioctl(struct file *filp, > break; > > default: > - pr_err("Unknown ioctl %d\n", cmd); > retval = -EINVAL; > } >
Applied to bionic/linux master-next Thanks! - Luke On Tue, May 3, 2022 at 12:12 PM Thadeu Lima de Souza Cascardo < cascardo@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1971480 > > When exercising the kernel with stress-ng with some ioctl tests the > "Unknown ioctl" error message is spamming the kernel log at a high > rate. Remove this message. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > (cherry picked from commit 6bc8f20c1d9348bdf9ce387228c1b16ce4a301ad) > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > net/vmw_vsock/af_vsock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index d60d7caacbf5..bc972ecb01ee 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -1890,7 +1890,6 @@ static long vsock_dev_do_ioctl(struct file *filp, > break; > > default: > - pr_err("Unknown ioctl %d\n", cmd); > retval = -EINVAL; > } > > -- > 2.32.0 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index d60d7caacbf5..bc972ecb01ee 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1890,7 +1890,6 @@ static long vsock_dev_do_ioctl(struct file *filp, break; default: - pr_err("Unknown ioctl %d\n", cmd); retval = -EINVAL; }