From patchwork Thu Mar 17 15:34:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: patricia.domingues@canonical.com X-Patchwork-Id: 1606626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=WekmuKZA; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KKB7R6mSKz9s2R for ; Fri, 18 Mar 2022 02:36:03 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1nUsAO-00078T-Hn; Thu, 17 Mar 2022 15:35:56 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1nUsAN-000786-Mo for kernel-team@lists.ubuntu.com; Thu, 17 Mar 2022 15:35:55 +0000 Received: from localhost.localdomain (1.general.patriciasd.us.vpn [10.172.64.192]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id B09DF3F646 for ; Thu, 17 Mar 2022 15:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647531355; bh=j4aBGWNmC/VOhBp2Ll4UZOjCfZCokPUsZkW4MrOs/v8=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References; b=WekmuKZAg6A629jTJPBae9mD6Negf1FxLBHAxNXCiqZXyjXtmYt0bhpTZgXJ5GxQC BUjmIMfGpn60X5gpr+QqdddBPoepXAWcVDrk4PgS3n7+Kgs2MdKqNS35pwdLv0r2hP BqPQ7sw+IUknuFVJLP4a1hQW9OJ5T4lwD8FncN2PoGtgE4RCImdAA3tbCepJ/+BiG2 58mz3rH+rLXMgQBWpMWxYhcenHiPdXQNlPDc3wY/H5qh3q9w4Hx0A5Z1f0C9he96Hy E6C8rcqNJAFM72KDphR6QV/ON533/SH23WdXEFXjhhyPrwmCXadIhlwQpzK2X7zntQ X+l63NAZw7+Aw== From: patricia.domingues@canonical.com To: kernel-team@lists.ubuntu.com Subject: [J][PATCH 2/6] s390/pci: add simpler s390dbf traces for events Date: Thu, 17 Mar 2022 12:34:59 -0300 Message-Id: <20220317153503.12817-3-patricia.domingues@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220317153503.12817-1-patricia.domingues@canonical.com> References: <20220317153503.12817-1-patricia.domingues@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Niklas Schnelle BugLink: https://bugs.launchpad.net/bugs/1959532 We often need to figure out what operations were performed in response to an error or availability event. The operations are easily accessible in s390dbf/pci_msg but the events have to be correlated with these from either the kernel log or s390dbf/pci_err. Improve this situation by logging the most important data from error and availability events that is the FID, PEC and FH together with the operations. Reviewed-by: Matthew Rosato Signed-off-by: Niklas Schnelle Signed-off-by: Vasily Gorbik (cherry picked from commit 6526a597a2e856df9ae94512f9903caccd5196d6) Signed-off-by: Patricia Domingues --- arch/s390/pci/pci_event.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/s390/pci/pci_event.c b/arch/s390/pci/pci_event.c index 5b8d647523f9..6a5bfa9dc1f2 100644 --- a/arch/s390/pci/pci_event.c +++ b/arch/s390/pci/pci_event.c @@ -52,6 +52,8 @@ static void __zpci_event_error(struct zpci_ccdf_err *ccdf) struct zpci_dev *zdev = get_zdev_by_fid(ccdf->fid); struct pci_dev *pdev = NULL; + zpci_dbg(3, "err fid:%x, fh:%x, pec:%x\n", + ccdf->fid, ccdf->fh, ccdf->pec); zpci_err("error CCDF:\n"); zpci_err_hex(ccdf, sizeof(*ccdf)); @@ -96,6 +98,8 @@ static void __zpci_event_availability(struct zpci_ccdf_avail *ccdf) struct zpci_dev *zdev = get_zdev_by_fid(ccdf->fid); enum zpci_state state; + zpci_dbg(3, "avl fid:%x, fh:%x, pec:%x\n", + ccdf->fid, ccdf->fh, ccdf->pec); zpci_err("avail CCDF:\n"); zpci_err_hex(ccdf, sizeof(*ccdf));