From patchwork Mon Jan 17 14:18:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1580791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JcvCt1jMSz9s9c for ; Tue, 18 Jan 2022 01:19:05 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1n9SqW-0005UV-42; Mon, 17 Jan 2022 14:18:56 +0000 Received: from mail-pj1-f45.google.com ([209.85.216.45]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1n9SqQ-0005Sa-T4 for kernel-team@lists.ubuntu.com; Mon, 17 Jan 2022 14:18:51 +0000 Received: by mail-pj1-f45.google.com with SMTP id o3so20683398pjs.1 for ; Mon, 17 Jan 2022 06:18:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/oRtGYH9Hx+nmChBOblqhsQDgHVLa7FClEvXP7uwh1I=; b=vsPgc5LeBt78MtBVi73WUfp5KptaqPQj3IYe5K7f2gUtHLbeOea3gw5XBfbxALEkft 0FP0A5Nph+/ZRXyQYWXA2DCqTV54jxgDKwjzfyvYw1Vxgxvf8iYC0O9dmoSMFmc9Tv9w bkY2wphI0XA9Jn1WrJQuawDQ8OagA9OQrS0fERc1iKOyWU5dPGMvLmAcCDqz94YN/5Yt 4v2VGYUMVYQcF2xd0bvTXZT+3KAvNcYzxBOHh0eEoCUNAJT5/AgPrASAgYL9jcMK5xrP 7pVmm83ew3kyo9Zl8FAP5oUvtFs5QN+7tOk6+J6vXP1pyHqvtIj+zydVFBqV0Z9Oovab /udQ== X-Gm-Message-State: AOAM530vcKi6H/P7Y8M9xVZoXXhy2E8S5Wjx1CNJzo61eoUCAu/zozxm nuD9AReYLXLj9CqPDk0bHYkfe5tgCblXBA== X-Google-Smtp-Source: ABdhPJwpdbV72EHx48cO0TZK97LgOjJ+Zd5ne/c6ROM4xPGCE+JU80aRKbIPwK3KlTQiSNS4Zr76Fw== X-Received: by 2002:a17:90a:2a03:: with SMTP id i3mr23720070pjd.30.1642429128733; Mon, 17 Jan 2022 06:18:48 -0800 (PST) Received: from localhost (218-173-149-51.dynamic-ip.hinet.net. [218.173.149.51]) by smtp.gmail.com with ESMTPSA id mi3sm13307693pjb.26.2022.01.17.06.18.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 06:18:48 -0800 (PST) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][Jammy] drm/amd/display: explicitly set is_dsc_supported to false before use Date: Mon, 17 Jan 2022 22:18:44 +0800 Message-Id: <20220117141844.896683-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220117141844.896683-1-vicamo.yang@canonical.com> References: <20220117141844.896683-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.45; envelope-from=vicamo@gmail.com; helo=mail-pj1-f45.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Mario Limonciello BugLink: https://bugs.launchpad.net/bugs/1956497 When UBSAN is enabled a case is shown on unplugging the display that this variable hasn't been initialized by `update_dsc_caps`, presumably when the display was unplugged it wasn't copied from the DPCD. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956497 Signed-off-by: Mario Limonciello Acked-by: Alex Deucher Signed-off-by: Alex Deucher (cherry picked from commit 63ad5371cd1e379519395c49a4b6a652c36c98e5) Signed-off-by: You-Sheng Yang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 3b09b21f1ac2..e44eb17e2243 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -5811,6 +5811,7 @@ static void update_dsc_caps(struct amdgpu_dm_connector *aconnector, struct dsc_dec_dpcd_caps *dsc_caps) { stream->timing.flags.DSC = 0; + dsc_caps->is_dsc_supported = false; if (aconnector->dc_link && sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT) { dc_dsc_parse_dsc_dpcd(aconnector->dc_link->ctx->dc,