| Message ID | 20210816135916.48575-2-jeremy.szu@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,U/I/H] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8 Notebook PC | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 8/16/21 7:59 AM, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1939473 > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > using 0x02 to control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > Cc: <stable@vger.kernel.org> > Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com > Signed-off-by: Takashi Iwai <tiwai@suse.de> > (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51) > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index caaf0e8aac11..20679acb0291 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8429,6 +8429,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), >
On 16.08.21 15:59, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1939473 > > The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is > using 0x02 to control mute LED and 0x01 to control micmute LED. > Therefore, add a quirk to make it works. > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > Cc: <stable@vger.kernel.org> > Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com > Signed-off-by: Takashi Iwai <tiwai@suse.de> > (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51) > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > --- This submission is rather confusing. There is not cover-email but two patches (which both seem to be the same, a cherry pick). The subject targets things to U,I,H:linux, and F:linux-oem-5.13 but the bug report only has F:linux-oem-5.10 which is supposed to be released already. -Stefan > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index caaf0e8aac11..20679acb0291 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8429,6 +8429,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index caaf0e8aac11..20679acb0291 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8429,6 +8429,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), + SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),