diff mbox series

[SRU,Xenial] UBUNTU: SAUCE: Fix fuse regression in 4.4.0-207.239

Message ID 20210331104406.177696-1-stefan.bader@canonical.com
State New
Headers show
Series [SRU,Xenial] UBUNTU: SAUCE: Fix fuse regression in 4.4.0-207.239 | expand

Commit Message

Stefan Bader March 31, 2021, 10:44 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1921969

When converting fuse_do_setattr() to take a denry instead of an inode as
argument, there was one call to it missed in fuse_setattr(). This adds
the missing conversion.

Fixes: b3ce51efc535 "fuse: Propagate dentry down to inode_change_ok()"
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 fs/fuse/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza March 31, 2021, 10:47 a.m. UTC | #1
On 31.03.21 12:44, Stefan Bader wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921969
> 
> When converting fuse_do_setattr() to take a denry instead of an inode as
> argument, there was one call to it missed in fuse_setattr(). This adds
> the missing conversion.
> 
> Fixes: b3ce51efc535 "fuse: Propagate dentry down to inode_change_ok()"
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>   fs/fuse/dir.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 3456f6861293..6413273e42f7 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1769,7 +1769,7 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr)
>   	if (!attr->ia_valid)
>   		return 0;
>   
> -	ret = fuse_do_setattr(inode, attr, file);
> +	ret = fuse_do_setattr(entry, attr, file);
>   	if (!ret) {
>   		/* Directory mode changed, may need to revalidate access */
>   		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
>
Colin Ian King March 31, 2021, 10:48 a.m. UTC | #2
On 31/03/2021 11:44, Stefan Bader wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921969
> 
> When converting fuse_do_setattr() to take a denry instead of an inode as

s/denry/dentry/

> argument, there was one call to it missed in fuse_setattr(). This adds
> the missing conversion.
> 
> Fixes: b3ce51efc535 "fuse: Propagate dentry down to inode_change_ok()"
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  fs/fuse/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 3456f6861293..6413273e42f7 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1769,7 +1769,7 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr)
>  	if (!attr->ia_valid)
>  		return 0;
>  
> -	ret = fuse_do_setattr(inode, attr, file);
> +	ret = fuse_do_setattr(entry, attr, file);
>  	if (!ret) {
>  		/* Directory mode changed, may need to revalidate access */
>  		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
> 

Apart from that nitpick,

Acked-by: Colin Ian King <colin.king@canonical.com>
Kleber Sacilotto de Souza March 31, 2021, 12:46 p.m. UTC | #3
On 31.03.21 12:44, Stefan Bader wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921969
> 
> When converting fuse_do_setattr() to take a denry instead of an inode as
> argument, there was one call to it missed in fuse_setattr(). This adds
> the missing conversion.
> 
> Fixes: b3ce51efc535 "fuse: Propagate dentry down to inode_change_ok()"
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>   fs/fuse/dir.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 3456f6861293..6413273e42f7 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1769,7 +1769,7 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr)
>   	if (!attr->ia_valid)
>   		return 0;
>   
> -	ret = fuse_do_setattr(inode, attr, file);
> +	ret = fuse_do_setattr(entry, attr, file);
>   	if (!ret) {
>   		/* Directory mode changed, may need to revalidate access */
>   		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
> 

Applied to xenial/linux.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 3456f6861293..6413273e42f7 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1769,7 +1769,7 @@  static int fuse_setattr(struct dentry *entry, struct iattr *attr)
 	if (!attr->ia_valid)
 		return 0;
 
-	ret = fuse_do_setattr(inode, attr, file);
+	ret = fuse_do_setattr(entry, attr, file);
 	if (!ret) {
 		/* Directory mode changed, may need to revalidate access */
 		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))