diff mbox series

[SRU,groovy,3/9] futex: Replace pointless printk in fixup_owner()

Message ID 20210309170332.1068306-4-cascardo@canonical.com
State New
Headers show
Series CVE-2021-3347 | expand

Commit Message

Thadeu Lima de Souza Cascardo March 9, 2021, 5:03 p.m. UTC 
From: Thomas Gleixner <tglx@linutronix.de>

If that unexpected case of inconsistent arguments ever happens then the
futex state is left completely inconsistent and the printk is not really
helpful. Replace it with a warning and make the state consistent.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: stable@vger.kernel.org
(cherry picked from commit 04b79c55201f02ffd675e1231d731365e335c307)
CVE-2021-3347
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 kernel/futex.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/kernel/futex.c b/kernel/futex.c
index ec7043ce8515..22dd904016b1 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2573,14 +2573,10 @@  static int fixup_owner(u32 __user *uaddr, struct futex_q *q, int locked)
 
 	/*
 	 * Paranoia check. If we did not take the lock, then we should not be
-	 * the owner of the rt_mutex.
+	 * the owner of the rt_mutex. Warn and establish consistent state.
 	 */
-	if (rt_mutex_owner(&q->pi_state->pi_mutex) == current) {
-		printk(KERN_ERR "fixup_owner: ret = %d pi-mutex: %p "
-				"pi-state %p\n", ret,
-				q->pi_state->pi_mutex.owner,
-				q->pi_state->owner);
-	}
+	if (WARN_ON_ONCE(rt_mutex_owner(&q->pi_state->pi_mutex) == current))
+		return fixup_pi_state_owner(uaddr, q, current);
 
 	return ret;
 }