diff mbox series

[H/master] UBUNTU: SAUCE: selftests: memory-hotplug: bump timeout to 10min

Message ID 20210218145821.69906-1-paolo.pisati@canonical.com
State New
Headers show
Series [H/master] UBUNTU: SAUCE: selftests: memory-hotplug: bump timeout to 10min | expand

Commit Message

Paolo Pisati Feb. 18, 2021, 2:58 p.m. UTC
$ sudo make -C tools/testing/selftests/memory-hotplug run_tests
TAP version 13
1..1
...
15:11:09 DEBUG| [stdout] not ok 1 selftests: memory-hotplug: mem-on-off-test.sh # TIMEOUT 45 seconds

The memory-hotplug selftest can take up to several minutes, depending on memory
size and cpu speed of the testbench, so bump timeout to 10 minutes.

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 tools/testing/selftests/memory-hotplug/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/memory-hotplug/settings

Comments

Seth Forshee Feb. 18, 2021, 3:59 p.m. UTC | #1
On Thu, Feb 18, 2021 at 03:58:21PM +0100, Paolo Pisati wrote:
> $ sudo make -C tools/testing/selftests/memory-hotplug run_tests
> TAP version 13
> 1..1
> ...
> 15:11:09 DEBUG| [stdout] not ok 1 selftests: memory-hotplug: mem-on-off-test.sh # TIMEOUT 45 seconds
> 
> The memory-hotplug selftest can take up to several minutes, depending on memory
> size and cpu speed of the testbench, so bump timeout to 10 minutes.
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Don't we want this for unstable too? Also seems worth sending upstream.

> ---
>  tools/testing/selftests/memory-hotplug/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/memory-hotplug/settings
> 
> diff --git a/tools/testing/selftests/memory-hotplug/settings b/tools/testing/selftests/memory-hotplug/settings
> new file mode 100644
> index 000000000000..a62d2fa1275c
> --- /dev/null
> +++ b/tools/testing/selftests/memory-hotplug/settings
> @@ -0,0 +1 @@
> +timeout=600
> -- 
> 2.27.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Paolo Pisati Feb. 18, 2021, 4:46 p.m. UTC | #2
On Thu, Feb 18, 2021 at 09:59:56AM -0600, Seth Forshee wrote:
> On Thu, Feb 18, 2021 at 03:58:21PM +0100, Paolo Pisati wrote:
> > $ sudo make -C tools/testing/selftests/memory-hotplug run_tests
> > TAP version 13
> > 1..1
> > ...
> > 15:11:09 DEBUG| [stdout] not ok 1 selftests: memory-hotplug: mem-on-off-test.sh # TIMEOUT 45 seconds
> > 
> > The memory-hotplug selftest can take up to several minutes, depending on memory
> > size and cpu speed of the testbench, so bump timeout to 10 minutes.
> > 
> > Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> 
> Don't we want this for unstable too? Also seems worth sending upstream.

Yes, that is meant for 5.10+ - i'll send it upstream.
Andrea Righi Feb. 18, 2021, 4:48 p.m. UTC | #3
On Thu, Feb 18, 2021 at 03:58:21PM +0100, Paolo Pisati wrote:
> $ sudo make -C tools/testing/selftests/memory-hotplug run_tests
> TAP version 13
> 1..1
> ...
> 15:11:09 DEBUG| [stdout] not ok 1 selftests: memory-hotplug: mem-on-off-test.sh # TIMEOUT 45 seconds
> 
> The memory-hotplug selftest can take up to several minutes, depending on memory
> size and cpu speed of the testbench, so bump timeout to 10 minutes.
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Applied to unstable/5.11, thanks!

-Andrea

> ---
>  tools/testing/selftests/memory-hotplug/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/memory-hotplug/settings
> 
> diff --git a/tools/testing/selftests/memory-hotplug/settings b/tools/testing/selftests/memory-hotplug/settings
> new file mode 100644
> index 000000000000..a62d2fa1275c
> --- /dev/null
> +++ b/tools/testing/selftests/memory-hotplug/settings
> @@ -0,0 +1 @@
> +timeout=600
> -- 
> 2.27.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/tools/testing/selftests/memory-hotplug/settings b/tools/testing/selftests/memory-hotplug/settings
new file mode 100644
index 000000000000..a62d2fa1275c
--- /dev/null
+++ b/tools/testing/selftests/memory-hotplug/settings
@@ -0,0 +1 @@ 
+timeout=600