From patchwork Thu Jun 18 23:12:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1312455 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49nyRS2l5xz9sRk; Fri, 19 Jun 2020 09:13:40 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jm3iv-0008HG-S3; Thu, 18 Jun 2020 23:13:33 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jm3ih-00085c-5j for kernel-team@lists.ubuntu.com; Thu, 18 Jun 2020 23:13:19 +0000 Received: from mail-io1-f71.google.com ([209.85.166.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jm3ig-0008Q2-3e for kernel-team@lists.ubuntu.com; Thu, 18 Jun 2020 23:13:18 +0000 Received: by mail-io1-f71.google.com with SMTP id b3so3072407ion.17 for ; Thu, 18 Jun 2020 16:13:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BL5yL7oY/9Qnleyl5Itl0tw0Tibek5I6ZYbO8678NgE=; b=aG8ZD/B0pgCwSfFmCBmpwyvbzjwRvM7rfOqhVieuakaPD1DzXOJds/shoJWXpGlwh3 TkxAOLjSQo+hjAR8hwUzQ/mtsPfcYy8qlrNM0wOKFopr6nEFWry/4HtF57MfntSR4x4O HKNdHZ5Mxc2KsnDwL/ubRm1ZZZorttUFrdVCOiX3AurQxZJAOt5IdjvA7gLOoFRShbJK VhO8fvD2PI+EDu/1lKywfoy3Yino3A6jJDwR7PGRr76X1gJDNVsef42usw4PbPg2PTjq x+vP/2mhK9VBg6YgHz//PB4O7SOQRKTo+Dwx4CdCfk7ET/JnWMd7DPq4As3Dq8Qs0lTT Z0rQ== X-Gm-Message-State: AOAM5337clcot7TXNjNQD45sUZAObbzYNq70Wc+oylkarYTDI9skB4qm 9l2l5pIOs5sdWFfCd2agVKjTiX5OidwrwIv/ltKIQtQKtmQFhCwD188TlqPfnUfqvidlXKoNQQV EVSNvE9dYSgci0mAKFfUx5BY95IMVtVGuHr+UYiaHAA== X-Received: by 2002:a92:2515:: with SMTP id l21mr885844ill.64.1592521997012; Thu, 18 Jun 2020 16:13:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnwqb2DRZWer3eSaWIGYOObz7gcn+DP2r6RmyBsvCkRYDx6hqQ0FrjLKNcGHWEEZmKD8CQDw== X-Received: by 2002:a92:2515:: with SMTP id l21mr885828ill.64.1592521996753; Thu, 18 Jun 2020 16:13:16 -0700 (PDT) Received: from localhost ([2605:a601:ac0f:820:f090:1573:c2fc:6389]) by smtp.gmail.com with ESMTPSA id c5sm2344158ioq.9.2020.06.18.16.13.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 16:13:16 -0700 (PDT) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH 13/47][X] Annotate hardware config module parameters in drivers/gpio/ Date: Thu, 18 Jun 2020 18:12:24 -0500 Message-Id: <20200618231258.630575-14-seth.forshee@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200618231258.630575-1-seth.forshee@canonical.com> References: <20200618231258.630575-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: David Howells BugLink: https://bugs.launchpad.net/bugs/1884159 When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/gpio/. Suggested-by: Alan Cox Signed-off-by: David Howells Acked-by: William Breathitt Gray Acked-by: Linus Walleij cc: Alexandre Courbot cc: linux-gpio@vger.kernel.org (backported from commit d759f906794b3b2894780870227c3c05895d83c1) Signed-off-by: Seth Forshee --- drivers/gpio/gpio-104-idio-16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c index 5400d7d4d8fd..f48f72e20f2e 100644 --- a/drivers/gpio/gpio-104-idio-16.c +++ b/drivers/gpio/gpio-104-idio-16.c @@ -23,7 +23,7 @@ #include static unsigned idio_16_base; -module_param(idio_16_base, uint, 0); +module_param_hw(idio_16_base, uint, ioport, 0); MODULE_PARM_DESC(idio_16_base, "ACCES 104-IDIO-16 base address"); /**