From patchwork Thu Jun 18 21:28:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thadeu Lima de Souza Cascardo X-Patchwork-Id: 1312413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49nw6z51xCz9sRf; Fri, 19 Jun 2020 07:29:14 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jm25u-0001py-Ie; Thu, 18 Jun 2020 21:29:10 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jm25r-0001oz-KH for kernel-team@lists.ubuntu.com; Thu, 18 Jun 2020 21:29:07 +0000 Received: from 1.general.cascardo.us.vpn ([10.172.70.58] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jm25q-0000q8-Vb for kernel-team@lists.ubuntu.com; Thu, 18 Jun 2020 21:29:07 +0000 From: Thadeu Lima de Souza Cascardo To: kernel-team@lists.ubuntu.com Subject: [SRU Eoan 1/2] UBUNTU: SAUCE: selftests: net: ip_defrag: limit packet to 1000 fragments Date: Thu, 18 Jun 2020 18:28:49 -0300 Message-Id: <20200618212851.158837-2-cascardo@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618212851.158837-1-cascardo@canonical.com> References: <20200618212851.158837-1-cascardo@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1826848 The ip_defrag selftest will fail when run with a conntrack rule because it might push more than a 1000 fragments through loopback. This will hit the backlog limit, causing fragments to be dropped, leading to test failures. This is considered a real bug by Eric Dumazet, so the test change is just a workaround so we can keep testing for other regressions while avoiding this particular failure. Signed-off-by: Thadeu Lima de Souza Cascardo Signed-off-by: Seth Forshee --- tools/testing/selftests/net/ip_defrag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/ip_defrag.c b/tools/testing/selftests/net/ip_defrag.c index c0c9ecb891e1..b53fb67f8e5e 100644 --- a/tools/testing/selftests/net/ip_defrag.c +++ b/tools/testing/selftests/net/ip_defrag.c @@ -36,7 +36,7 @@ const struct in6_addr addr6 = IN6ADDR_LOOPBACK_INIT; static int payload_len; static int max_frag_len; -#define MSG_LEN_MAX 10000 /* Max UDP payload length. */ +#define MSG_LEN_MAX 8000 /* Max UDP payload length. */ #define IP4_MF (1u << 13) /* IPv4 MF flag. */ #define IP6_MF (1) /* IPv6 MF flag. */