From patchwork Wed Dec 18 14:30:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dann frazier X-Patchwork-Id: 1212459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47dHVX3g5Dz9sSH; Thu, 19 Dec 2019 01:30:44 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ihaLZ-0005Hw-7R; Wed, 18 Dec 2019 14:30:41 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ihaLX-0005HR-TV for kernel-team@lists.ubuntu.com; Wed, 18 Dec 2019 14:30:39 +0000 Received: from mail-il1-f198.google.com ([209.85.166.198]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ihaLX-0007Lj-H5 for kernel-team@lists.ubuntu.com; Wed, 18 Dec 2019 14:30:39 +0000 Received: by mail-il1-f198.google.com with SMTP id j17so1873215ilc.10 for ; Wed, 18 Dec 2019 06:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QTgHtrJ47aPRRs+xplh0yHPUHKLStwEaGstisgrDFco=; b=P5QPl46zWUK8MUxFtycWJ1h21WVaTC1X7nj+JBXQOZP2WAMkhqEFM73Kq6F86D+/T6 4r3UfIdUPdrqsrC39aoIwFfOQP+uUfNOXkyggOEUfxY4QWby+MEzh21JoShng30+Qksc 8n84o4wInmCJ3ZUnNeP/ASLgOyvB1oqew+++qi//GY1rR84HTnXkkcNtgByub+8uGlsN C0vZnYbfQ2If3Mf5lD3Y4vbHplnGJvDNY2XpPJqJCSQdf7NyabsznzrAlnHE7Gpidqzd I7KaR5RbwJdM5EzSCTd57nfDIs1L7hh9epBF3lfFLV1XYLRfX+RfZgGvqOcgK2/fg8IX aQ2w== X-Gm-Message-State: APjAAAV+MsyahOOHBWn7t5fMcWNFsmTEikovVN3du6CuAW84lrveZP2A n030GVD7EenHLXq0L4jOo3NEnGoWNl3DfwstckbVmHiY7rG0EBhtAO65HHaVqCeHE4jJUwMFp+l jX3KVmlDebHF7trMVsrZDCMUQW9mtyAIgnOFxzzg/+w== X-Received: by 2002:a92:4781:: with SMTP id e1mr2066969ilk.147.1576679438426; Wed, 18 Dec 2019 06:30:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwkMu9PRuxCuWC1UcHcaOJMlfUQjWRokFJQEoPfMhCP116SPEuF/KiG9+I3WxtIq8s5KAqQhg== X-Received: by 2002:a92:4781:: with SMTP id e1mr2066951ilk.147.1576679438211; Wed, 18 Dec 2019 06:30:38 -0800 (PST) Received: from xps13.canonical.com (c-71-56-235-36.hsd1.co.comcast.net. [71.56.235.36]) by smtp.gmail.com with ESMTPSA id w5sm51405iob.26.2019.12.18.06.30.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 06:30:37 -0800 (PST) From: dann frazier To: kernel-team@lists.ubuntu.com Subject: [PATCH 4/5][SRU Disco] md/raid0: Fix an error message in raid0_make_request() Date: Wed, 18 Dec 2019 07:30:30 -0700 Message-Id: <20191218143031.207870-4-dann.frazier@canonical.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191218143031.207870-1-dann.frazier@canonical.com> References: <20191218142041.206383-1-dann.frazier@canonical.com> <20191218143031.207870-1-dann.frazier@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Dan Carpenter BugLink: https://bugs.launchpad.net/bugs/1850540 [ Upstream commit e3fc3f3d0943b126f76b8533960e4168412d9e5a ] The first argument to WARN() is supposed to be a condition. The original code will just print the mdname() instead of the full warning message. Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.") Signed-off-by: Dan Carpenter Signed-off-by: Song Liu Signed-off-by: Sasha Levin Signed-off-by: dann frazier --- drivers/md/raid0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c index da757df6dded4..534a51e7d7b02 100644 --- a/drivers/md/raid0.c +++ b/drivers/md/raid0.c @@ -624,7 +624,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio) tmp_dev = map_sector(mddev, zone, sector, §or); break; default: - WARN("md/raid0:%s: Invalid layout\n", mdname(mddev)); + WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev)); bio_io_error(bio); return true; }