From patchwork Wed Aug 28 07:42:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1154276 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46JHlC4wdQz9sNF; Wed, 28 Aug 2019 17:42:31 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1i2sb5-0008ND-Vg; Wed, 28 Aug 2019 07:42:27 +0000 Received: from mail-pg1-f195.google.com ([209.85.215.195]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1i2sb2-0008ML-RE for kernel-team@lists.ubuntu.com; Wed, 28 Aug 2019 07:42:24 +0000 Received: by mail-pg1-f195.google.com with SMTP id n9so995339pgc.1 for ; Wed, 28 Aug 2019 00:42:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QfiEGymLWidwGnlNZL40HtmuiGDhj8BmjOI2IP+0pUg=; b=Xg+IKJ3H+MhJoZ9XXFg+IfqAGeaNMzO1XOAgx92MJ7ZybcRKyPFkYCxW5buHXuuWox 4VmxArYVpCt6BXiqotg4xDoIQCLXjQ3hGLxa7/WsK301XFL1E8wjLzop1wz6m0HX23zo CFc7u0+RJXEtZSmg4zGwnAxgbDAmhCSY/E+qZ5VyVrlHuRgwOYuxAE8E+8YvPUK3TKPp 8yclhKiP7hIkkdELfyNlv3Cgeta7cNDetU7AyMPaOpGTsJjSjiJyJd6tHBFjZGgtDcp7 LZzieYfw7ADIVR3e26LVEwdiJRExcYtje40LLWVyRmuZ74yCFlCjogKA6CkKsV09+aYP Z3GQ== X-Gm-Message-State: APjAAAUrLe9d36uPbRVm9QgmVlwHArGkb3kW2GshgnRh25SVFHj6YA5y etNDgmkbEPmz3bhclnndzJWmpnKb X-Google-Smtp-Source: APXvYqz1OkWyBH5lWTIglFaqtPp0f5DnqqEQ/w2qqHGajvoNBtD4HbONvZMxetXI7OJozJtLGxAMpQ== X-Received: by 2002:a63:607:: with SMTP id 7mr2280035pgg.240.1566978143011; Wed, 28 Aug 2019 00:42:23 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 1sm1828477pfy.169.2019.08.28.00.42.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Aug 2019 00:42:22 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on GeminiLake Date: Wed, 28 Aug 2019 15:42:17 +0800 Message-Id: <20190828074218.15518-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190828074218.15518-1-vicamo.yang@canonical.com> References: <20190828074218.15518-1-vicamo.yang@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Daniel Drake BugLink: https://bugs.launchpad.net/ubuntu/bug/1840236 On many (all?) the Gemini Lake systems we work with, there is frequent momentary graphical corruption at the top of the screen, and it seems that disabling framebuffer compression can avoid this. The ticket was reported 6 months ago and has already affected a multitude of users, without any real progress being made. So, lets disable framebuffer compression on GeminiLake until a solution is found. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108085 Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") Cc: Paulo Zanoni Cc: Daniel Vetter Cc: Jani Nikula Cc: # v4.11+ Reviewed-by: Paulo Zanoni Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20190423092810.28359-1-jian-hong@endlessm.com (cherry picked from commit 1d25724b41fad7eeb2c3058a5c8190d6ece73e08) Signed-off-by: You-Sheng Yang --- drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 8b9c92e80715b..6d3c5057b2413 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1279,6 +1279,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) if (!HAS_FBC(dev_priv)) return 0; + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ + if (IS_GEMINILAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1;