diff mbox series

[x/azure] blk-mq: remove the request_list usage

Message ID 20190422203218.2200-1-marcelo.cerri@canonical.com
State New
Headers show
Series [x/azure] blk-mq: remove the request_list usage | expand

Commit Message

Marcelo Henrique Cerri April 22, 2019, 8:32 p.m. UTC
From: Jens Axboe <axboe@kernel.dk>

BugLink: http://bugs.launchpad.net/bugs/1819689

We don't do anything with it, that's just the legacy path.

Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
(backported from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
[marcelo.cerri@canonical.com: fixed context]
Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
---
 block/blk-mq.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Kleber Sacilotto de Souza April 23, 2019, 1:25 p.m. UTC | #1
On 4/22/19 10:32 PM, Marcelo Henrique Cerri wrote:
> From: Jens Axboe <axboe@kernel.dk>
> 
> BugLink: http://bugs.launchpad.net/bugs/1819689
> 
> We don't do anything with it, that's just the legacy path.
> 
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Tested-by: Ming Lei <ming.lei@redhat.com>
> Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> (backported from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
> [marcelo.cerri@canonical.com: fixed context]
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

For both xenial and cosmic:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>


I have also fixed the bug nominations.

Kleber

> ---
>  block/blk-mq.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 2f8436314985..caeffd5b59f9 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -501,9 +501,6 @@ void blk_mq_free_request(struct request *rq)
>  
>  	wbt_done(q->rq_wb, &rq->issue_stat);
>  
> -	if (blk_rq_rl(rq))
> -		blk_put_rl(blk_rq_rl(rq));
> -
>  	clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
>  	clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
>  	if (rq->tag != -1)
> @@ -1637,8 +1634,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
>  {
>  	blk_init_request_from_bio(rq, bio);
>  
> -	blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
> -
>  	blk_account_io_start(rq, true);
>  }
>  
>
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 2f8436314985..caeffd5b59f9 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -501,9 +501,6 @@  void blk_mq_free_request(struct request *rq)
 
 	wbt_done(q->rq_wb, &rq->issue_stat);
 
-	if (blk_rq_rl(rq))
-		blk_put_rl(blk_rq_rl(rq));
-
 	clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
 	clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
 	if (rq->tag != -1)
@@ -1637,8 +1634,6 @@  static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
 {
 	blk_init_request_from_bio(rq, bio);
 
-	blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
-
 	blk_account_io_start(rq, true);
 }