diff mbox series

[SRU,B/OEM-B/C/D,v2,1/1] ALSA: hda/realtek - add two more pin configuration sets to quirk table

Message ID 20190418055214.8796-2-hui.wang@canonical.com
State Accepted
Headers show
Series headset-mic doesn't work on two Dell laptops | expand

Commit Message

Hui Wang April 18, 2019, 5:52 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1825272

We have two Dell laptops which have the codec 10ec0236 and 10ec0256
respectively, the headset mic on them can't work, need to apply the
quirk of ALC255_FIXUP_DELL1_MIC_NO_PRESENCE. So adding their pin
configurations in the pin quirk table.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit b26e36b7ef36a8a3a147b1609b2505f8a4ecf511
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stefan Bader April 18, 2019, 9:48 a.m. UTC | #1 
On 18.04.19 07:52, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1825272
> 
> We have two Dell laptops which have the codec 10ec0236 and 10ec0256
> respectively, the headset mic on them can't work, need to apply the
> quirk of ALC255_FIXUP_DELL1_MIC_NO_PRESENCE. So adding their pin
> configurations in the pin quirk table.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit b26e36b7ef36a8a3a147b1609b2505f8a4ecf511
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

I lowered the severity to "high" which is already rather to much for a headset
issue. Also added all nominations and additional source targets which I think
you wanted to have. Please double check this is what you want.

-Stefan

>  sound/pci/hda/patch_realtek.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 00c27b3b8c14..6fd08d8467c2 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7234,6 +7234,8 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x12, 0x90a60140},
>  		{0x14, 0x90170150},
>  		{0x21, 0x02211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x21, 0x02211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
>  		{0x14, 0x90170110},
>  		{0x21, 0x02211020}),
> @@ -7344,6 +7346,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x21, 0x0221101f}),
>  	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>  		ALC256_STANDARD_PINS),
> +	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x14, 0x90170110},
> +		{0x1b, 0x01011020},
> +		{0x21, 0x0221101f}),
>  	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS", ALC256_FIXUP_ASUS_MIC,
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>
Hui Wang April 18, 2019, 10:36 a.m. UTC | #2 
On 2019/4/18 下午5:48, Stefan Bader wrote:
> On 18.04.19 07:52, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1825272
>>
>> We have two Dell laptops which have the codec 10ec0236 and 10ec0256
>> respectively, the headset mic on them can't work, need to apply the
>> quirk of ALC255_FIXUP_DELL1_MIC_NO_PRESENCE. So adding their pin
>> configurations in the pin quirk table.
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> (cherry picked from commit b26e36b7ef36a8a3a147b1609b2505f8a4ecf511
>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
>> ---
> I lowered the severity to "high" which is already rather to much for a headset
> issue. Also added all nominations and additional source targets which I think
> you wanted to have. Please double check this is what you want.
>
> -Stefan

OK, that is fine.

Thanks,

Hui.

>>   sound/pci/hda/patch_realtek.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 00c27b3b8c14..6fd08d8467c2 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -7234,6 +7234,8 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>>   		{0x12, 0x90a60140},
>>   		{0x14, 0x90170150},
>>   		{0x21, 0x02211020}),
>> +	SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>> +		{0x21, 0x02211020}),
>>   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
>>   		{0x14, 0x90170110},
>>   		{0x21, 0x02211020}),
>> @@ -7344,6 +7346,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>>   		{0x21, 0x0221101f}),
>>   	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>>   		ALC256_STANDARD_PINS),
>> +	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>> +		{0x14, 0x90170110},
>> +		{0x1b, 0x01011020},
>> +		{0x21, 0x0221101f}),
>>   	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS", ALC256_FIXUP_ASUS_MIC,
>>   		{0x14, 0x90170110},
>>   		{0x1b, 0x90a70130},
>>
>
AceLan Kao April 19, 2019, 2:02 a.m. UTC | #3 
Acked-By: AceLan Kao <acelan.kao@canonical.com>
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 00c27b3b8c14..6fd08d8467c2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7234,6 +7234,8 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x12, 0x90a60140},
 		{0x14, 0x90170150},
 		{0x21, 0x02211020}),
+	SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x21, 0x02211020}),
 	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
 		{0x14, 0x90170110},
 		{0x21, 0x02211020}),
@@ -7344,6 +7346,10 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x21, 0x0221101f}),
 	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
 		ALC256_STANDARD_PINS),
+	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x14, 0x90170110},
+		{0x1b, 0x01011020},
+		{0x21, 0x0221101f}),
 	SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS", ALC256_FIXUP_ASUS_MIC,
 		{0x14, 0x90170110},
 		{0x1b, 0x90a70130},