diff mbox series

[4/4] UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y

Message ID 20180719101932.23954-5-kai.heng.feng@canonical.com
State New
Headers show
Series Enable AMD PCIe MP2 for AMDI0011 | expand

Commit Message

Kai-Heng Feng July 19, 2018, 10:19 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1773940
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 debian.master/config/config.common.ubuntu | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader July 25, 2018, 4:01 p.m. UTC | #1 
On 19.07.2018 12:19, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1773940
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 48f188cd2ad6..13a3f143fd69 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3897,6 +3897,7 @@ CONFIG_I2C_ALI15X3=m
>  CONFIG_I2C_AMD756=m
>  CONFIG_I2C_AMD756_S4882=m
>  CONFIG_I2C_AMD8111=m
> +CONFIG_I2C_AMD_MP2=y
>  CONFIG_I2C_ARB_GPIO_CHALLENGE=m
>  CONFIG_I2C_AXXIA=m
>  CONFIG_I2C_BCM2048=m
> 
Is it really necessary to build this in and not be a module like the other drivers?
Kai-Heng Feng July 26, 2018, 2:48 a.m. UTC | #2 
> On 2018Jul26, at 00:01, Stefan Bader <stefan.bader@canonical.com> wrote:
> 
> On 19.07.2018 12:19, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1773940
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> debian.master/config/config.common.ubuntu | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
>> index 48f188cd2ad6..13a3f143fd69 100644
>> --- a/debian.master/config/config.common.ubuntu
>> +++ b/debian.master/config/config.common.ubuntu
>> @@ -3897,6 +3897,7 @@ CONFIG_I2C_ALI15X3=m
>> CONFIG_I2C_AMD756=m
>> CONFIG_I2C_AMD756_S4882=m
>> CONFIG_I2C_AMD8111=m
>> +CONFIG_I2C_AMD_MP2=y
>> CONFIG_I2C_ARB_GPIO_CHALLENGE=m
>> CONFIG_I2C_AXXIA=m
>> CONFIG_I2C_BCM2048=m
>> 
> Is it really necessary to build this in and not be a module like the other drivers?

I didn’t dig too deep, but the driver only works when it’s builtin.

The driver for AMDI0010 is also builtin:
CONFIG_PINCTRL_AMD=y

Kai-Heng

> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 48f188cd2ad6..13a3f143fd69 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3897,6 +3897,7 @@  CONFIG_I2C_ALI15X3=m
 CONFIG_I2C_AMD756=m
 CONFIG_I2C_AMD756_S4882=m
 CONFIG_I2C_AMD8111=m
+CONFIG_I2C_AMD_MP2=y
 CONFIG_I2C_ARB_GPIO_CHALLENGE=m
 CONFIG_I2C_AXXIA=m
 CONFIG_I2C_BCM2048=m