diff mbox

[Artful] ACPI: APD: Fix HID for Hisilicon Hip07/08

Message ID 20170816175410.g7bncgbjqewwhl7a@xps13.dannf
State New
Headers show

Commit Message

dann frazier Aug. 16, 2017, 5:54 p.m. UTC 
From: Hanjun Guo <hanjun.guo@linaro.org>

BugLink: https://bugs.launchpad.net/bugs/1711182

ACPI HID for Hisilicon Hip07/08 should be HISI02A1/2,
not HISI0A21/2, HISI02A1/2 was tested ok but was modified
by the stupid typo when upstream the patches (by me),
correct them to the right IDs (matching the IDs in
drivers/i2c/busses/i2c-designware-platdrv.c).

Fixes: 6e14cf361a0c (ACPI / APD: Add clock frequency for Hisilicon Hip07/08 I2C controller)
Reported-by: Tao Tian <tiantao6@huawei.com>
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
(cherry picked from commit f7f3dd5b4cbb138ed4559b0d096bab76a8f476de)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
 drivers/acpi/acpi_apd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Seth Forshee Aug. 16, 2017, 7:36 p.m. UTC | #1 
On Wed, Aug 16, 2017 at 11:54:10AM -0600, dann frazier wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> BugLink: https://bugs.launchpad.net/bugs/1711182
> 
> ACPI HID for Hisilicon Hip07/08 should be HISI02A1/2,
> not HISI0A21/2, HISI02A1/2 was tested ok but was modified
> by the stupid typo when upstream the patches (by me),
> correct them to the right IDs (matching the IDs in
> drivers/i2c/busses/i2c-designware-platdrv.c).
> 
> Fixes: 6e14cf361a0c (ACPI / APD: Add clock frequency for Hisilicon Hip07/08 I2C controller)
> Reported-by: Tao Tian <tiantao6@huawei.com>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> (cherry picked from commit f7f3dd5b4cbb138ed4559b0d096bab76a8f476de)
> Signed-off-by: dann frazier <dann.frazier@canonical.com>

Applied to artful/master-next, thanks.
diff mbox

Patch

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index fc6c416f8724..d5999eb41c00 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -180,8 +180,8 @@  static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
 	{ "BRCM900D", APD_ADDR(vulcan_spi_desc) },
 	{ "CAV900D",  APD_ADDR(vulcan_spi_desc) },
-	{ "HISI0A21", APD_ADDR(hip07_i2c_desc) },
-	{ "HISI0A22", APD_ADDR(hip08_i2c_desc) },
+	{ "HISI02A1", APD_ADDR(hip07_i2c_desc) },
+	{ "HISI02A2", APD_ADDR(hip08_i2c_desc) },
 #endif
 	{ }
 };