diff mbox

[kteam-tools,v2,2/3,verify-release-ready] Relax the check for 'fix committed'

Message ID 20170704074456.10027-3-juerg.haefliger@canonical.com
State New
Headers show

Commit Message

Juerg Haefliger July 4, 2017, 7:44 a.m. UTC
If the script is run after the fixes have been released already, it
should not warn about fixes not being committed. So accept the status
'Fix Released' as well when checking the status of the individual fixes.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 maintscripts/verify-release-ready | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza July 6, 2017, 4:47 p.m. UTC | #1
On 07/04/17 09:44, Juerg Haefliger wrote:
> If the script is run after the fixes have been released already, it
> should not warn about fixes not being committed. So accept the status
> 'Fix Released' as well when checking the status of the individual fixes.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  maintscripts/verify-release-ready | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index a17824af39f9..55d9ff0d56d1 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -385,7 +385,7 @@ class VerifyReleaseReady():
>                         (changelog_series == s.lp_devel_series.displayname.lower()):
>                          is_targeted_to_series = True
>                          # if we are on a devel or series targeted task check status of that task
> -                        if task.status == u'Fix Committed':
> +                        if task.status in (u'Fix Committed', u'Fix Released'):
>                              is_fix_committed = True
>  
>              # display status based on results
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
diff mbox

Patch

diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
index a17824af39f9..55d9ff0d56d1 100755
--- a/maintscripts/verify-release-ready
+++ b/maintscripts/verify-release-ready
@@ -385,7 +385,7 @@  class VerifyReleaseReady():
                        (changelog_series == s.lp_devel_series.displayname.lower()):
                         is_targeted_to_series = True
                         # if we are on a devel or series targeted task check status of that task
-                        if task.status == u'Fix Committed':
+                        if task.status in (u'Fix Committed', u'Fix Released'):
                             is_fix_committed = True
 
             # display status based on results