Message ID | 20170630151201.21593-1-juerg.haefliger@canonical.com |
---|---|
State | New |
Headers | show |
On Fri, Jun 30, 2017 at 05:12:01PM +0200, Juerg Haefliger wrote: > Derivatives have a different tag format than what the tool reads from > debian/gbp.conf. Specifically, it's Ubuntu-<derivative>-<version> and > not just Ubuntu-<version>. So adjust the format accordingly. > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > --- > maintscripts/verify-release-ready | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready > index b22c5aa48639..cfe52d072eeb 100755 > --- a/maintscripts/verify-release-ready > +++ b/maintscripts/verify-release-ready > @@ -36,7 +36,7 @@ class VerifyReleaseReady(): > s.defaults['verbose'] = False > s.passed = 0 > s.failed = 0 > - s.delimiter = 40 > + s.delimiter = 50 > # add launchpadlib support > s.lp = Launchpad.login_anonymously(s.__class__.__name__, 'production') > s.lp_ubuntu = s.lp.distributions['ubuntu'] > @@ -199,6 +199,14 @@ class VerifyReleaseReady(): > config = ConfigParser.RawConfigParser() > if config.read('debian/gbp.conf'): > expect_tag_format = config.get('buildpackage', 'debian-tag') > + > + # juergh: Derivatives have a different tag format, e.g., Ubuntu-raspi2-<version> > + pkg = cl1['package'] > + if pkg.startswith('linux-') and not pkg.startswith('linux-lts-'): > + deriv = pkg[6:] # strip 'linux-' > + expect_tag_format = expect_tag_format.replace('%(version)', > + deriv + '-%(version)') My biggest pet peeve with DEP8 is the 80 character line limit. The above line is not more readable or understandable by being formatted to fit in 80 characters. expect_tag_format = expect_tag_format.replace('%(version)', deriv + '-%(version)') That is more readable. Having spent a little time working with punch cards I fail to understand why we continue to constrain ourselves. You will see in the code I write I don't. > + > v = version > # Starting with trusty, the lts backports closing commit and the tag > # contain '~<series_version>' (e.g. '~14.04.1') > -- > 2.11.0 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 30.06.2017 17:12, Juerg Haefliger wrote: > Derivatives have a different tag format than what the tool reads from > debian/gbp.conf. Specifically, it's Ubuntu-<derivative>-<version> and > not just Ubuntu-<version>. So adjust the format accordingly. > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- > maintscripts/verify-release-ready | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready > index b22c5aa48639..cfe52d072eeb 100755 > --- a/maintscripts/verify-release-ready > +++ b/maintscripts/verify-release-ready > @@ -36,7 +36,7 @@ class VerifyReleaseReady(): > s.defaults['verbose'] = False > s.passed = 0 > s.failed = 0 > - s.delimiter = 40 > + s.delimiter = 50 > # add launchpadlib support > s.lp = Launchpad.login_anonymously(s.__class__.__name__, 'production') > s.lp_ubuntu = s.lp.distributions['ubuntu'] > @@ -199,6 +199,14 @@ class VerifyReleaseReady(): > config = ConfigParser.RawConfigParser() > if config.read('debian/gbp.conf'): > expect_tag_format = config.get('buildpackage', 'debian-tag') > + > + # juergh: Derivatives have a different tag format, e.g., Ubuntu-raspi2-<version> > + pkg = cl1['package'] > + if pkg.startswith('linux-') and not pkg.startswith('linux-lts-'): > + deriv = pkg[6:] # strip 'linux-' > + expect_tag_format = expect_tag_format.replace('%(version)', > + deriv + '-%(version)') > + > v = version > # Starting with trusty, the lts backports closing commit and the tag > # contain '~<series_version>' (e.g. '~14.04.1') >
Applied on kteam-tools master branch. Thanks.
diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready index b22c5aa48639..cfe52d072eeb 100755 --- a/maintscripts/verify-release-ready +++ b/maintscripts/verify-release-ready @@ -36,7 +36,7 @@ class VerifyReleaseReady(): s.defaults['verbose'] = False s.passed = 0 s.failed = 0 - s.delimiter = 40 + s.delimiter = 50 # add launchpadlib support s.lp = Launchpad.login_anonymously(s.__class__.__name__, 'production') s.lp_ubuntu = s.lp.distributions['ubuntu'] @@ -199,6 +199,14 @@ class VerifyReleaseReady(): config = ConfigParser.RawConfigParser() if config.read('debian/gbp.conf'): expect_tag_format = config.get('buildpackage', 'debian-tag') + + # juergh: Derivatives have a different tag format, e.g., Ubuntu-raspi2-<version> + pkg = cl1['package'] + if pkg.startswith('linux-') and not pkg.startswith('linux-lts-'): + deriv = pkg[6:] # strip 'linux-' + expect_tag_format = expect_tag_format.replace('%(version)', + deriv + '-%(version)') + v = version # Starting with trusty, the lts backports closing commit and the tag # contain '~<series_version>' (e.g. '~14.04.1')
Derivatives have a different tag format than what the tool reads from debian/gbp.conf. Specifically, it's Ubuntu-<derivative>-<version> and not just Ubuntu-<version>. So adjust the format accordingly. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> --- maintscripts/verify-release-ready | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)